> be
>>>>> then I'll work on recreating and removing the warnings.
>>>> If the patch looks good to you, I'll check it in and we should be good.
>>> yeah, go ahead.
>>
>> We now have connection pnotes as of r386784.
>>
>> Documentation
you, I'll check it in and we should be good.
yeah, go ahead.
We now have connection pnotes as of r386784.
Documentation patch is still necessary.
Here's a suggested patch. I've created a separate pod file for
Apache2::ConnectionUtil. I've referenced Apache2::RequestU
he tests once they are
>>>committed. to that end, let's get the functionality to where it needs to be
>>>then I'll work on recreating and removing the warnings.
>>
>>If the patch looks good to you, I'll check it in and we should be good.
>
> yeah, go a
> This seems to make the problem go away, but I am not sure if that's where it
> belongs:
>
> sub handler {
>
> my $r = shift;
>
> # make it ok to call ok() here while plan()ing elsewhere
> Apache::Test::init_test_pm($r);
>
> + Test::_reset_globals() if Test->can('_reset_globals'
Geoffrey Young wrote:
>>Passes all tests, but I see tons (66 to be precise) of this warning in the
>>error_log, geoff ?
>>
>>"Use of uninitialized value in caller at /usr/lib/perl5/5.8.6/Test.pm line
>>374."
>
> yeah, I suspect that's because I'm playing around with how things are
> planned, etc.
> Passes all tests, but I see tons (66 to be precise) of this warning in the
> error_log, geoff ?
>
> "Use of uninitialized value in caller at /usr/lib/perl5/5.8.6/Test.pm line
> 374."
yeah, I suspect that's because I'm playing around with how things are
planned, etc.
it will probably be easie
Philip M. Gollucci wrote:
>>I'll work something up when I have the chance... in a month or two :)
>
> God do I know the feeling.
>
> Thanks for the good eyes Gozer.
No problem, and attached is a modified patch that:
1 - Doesn't leak a HV * on each pass
2 - Merges the pnotes logic between r->pno
I'll work something up when I have the chance... in a month or two :)
God do I know the feeling.
Thanks for the good eyes Gozer.
--
Philip M. Gollucci ([EMAIL PROTECTED]) 323 219 4708
Consultant / http://p6m7g8.net/Resume/
> What I mean is that you are leaking a HV. Every connection, if someone uses
> c->pnotes, you will run this code:
>
> if (!ccfg->pnotes) {
> ccfg->pnotes = newHV();
> }
>
> And you have nothing in place to cleanup this newly created HV (and it's
> contents)
ah, yeah. d'oh!
I
Geoffrey Young wrote:
>>All tests pass for me on various platforms, but...
>>
>>Where do you cleanup HV *modperl_config_con_t->pnotes ? Looks to me
>>like you are leaking it. You'd need something similar to what we
>>are doing for request pnotes:
>>
>>apr_status_t modperl_config_request_cleanup(pTH
> All tests pass for me on various platforms, but...
>
> Where do you cleanup HV *modperl_config_con_t->pnotes ? Looks to me
> like you are leaking it. You'd need something similar to what we
> are doing for request pnotes:
>
> apr_status_t modperl_config_request_cleanup(pTHX_ request_rec *r)
>
Geoffrey Young wrote:
>>-plan $r, tests => 9;
>>+# make it ok to call ok() here while plan()ing elsewhere
>>+Apache::Test::init_test_pm($r);
>>+$Test::ntest = 1 + (22 * ($r->args - 1));
>>+$Test::planned = 22;
>
> and of course everyone is wondering what this is. it would he
Geoffrey Young wrote:
--- /dev/null 2006-01-27 10:40:15.572121608 -0500
+++ xs/Apache2/ConnectionUtil/Apache2__ConnectionUtil.h 2005-10-25
13:33:27.0 -0400
AFAIK, the only thing that was a problem is that
Apache2/ConnectionUtil isn't an SVN dir. So when you apply the patch
locally,
> -plan $r, tests => 9;
> +# make it ok to call ok() here while plan()ing elsewhere
> +Apache::Test::init_test_pm($r);
> +$Test::ntest = 1 + (22 * ($r->args - 1));
> +$Test::planned = 22;
and of course everyone is wondering what this is. it would help if my
(third) patch ac
>>I think I was waiting for him to get back to me with some real test results,
>>which IIRC he said he would do when he could upgrade :)
>>
>>remarks on the list as to the thread safety made me a bit nervous about
>>commiting this particular bit, just because I don't have a clue when it
>>comes to
ConnectionUtil.xs: In function 'XS_Apache2__Connection_pnotes':
ConnectionUtil.xs:36: warning: implicit declaration of function
'mpxs_Apache2__Connection_pnotes'
ConnectionUtil.xs:36: warning: assignment makes pointer from integer without a
cast
make[3]: *** [ConnectionUtil.o] Error 1
I vaguely
Geoffrey Young wrote:
>
> Philip M. Gollucci wrote:
>
>>Geoff,
>>
>>http://aspn.activestate.com/ASPN/Mail/Message/modperl/2871864
>>
>>I never saw this get committed .. ?
>>
>>What needs to happen for that ?
>
>
> I think I was waiting for him to get back to me with some real test resul
Philip M. Gollucci wrote:
> Geoff,
>
> http://aspn.activestate.com/ASPN/Mail/Message/modperl/2871864
>
> I never saw this get committed .. ?
>
> What needs to happen for that ?
I think I was waiting for him to get back to me with some real test results,
which IIRC he said he would do
Geoff,
http://aspn.activestate.com/ASPN/Mail/Message/modperl/2871864
I never saw this get committed .. ?
What needs to happen for that ?
--
"Love is not the one you can picture yourself marrying,
but the one you c
19 matches
Mail list logo
