Github user 7shurik commented on the pull request:
https://github.com/apache/phoenix/pull/68#issuecomment-93865916
@samarthjain @JamesRTaylor are you still reviewing? I've uploaded the
version with suggested changes, including a single implementation of
PhoenixArray.toString().
Se
Github user samarthjain commented on the pull request:
https://github.com/apache/phoenix/pull/68#issuecomment-93872039
+1, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user 7shurik opened a pull request:
https://github.com/apache/phoenix/pull/70
JIRA Phoenix 1872
I'm fixing https://issues.apache.org/jira/browse/PHOENIX-1872. The fix is
to use PrimitiveBooleanArray of boolean[] instead of PhoenixArray of Boolean[].
I considered usi
[
https://issues.apache.org/jira/browse/PHOENIX-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498922#comment-14498922
]
Aakash Pradeep commented on PHOENIX-1710:
-
Postgres has these operators to read
[
https://issues.apache.org/jira/browse/PHOENIX-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498891#comment-14498891
]
James Taylor commented on PHOENIX-1835:
---
[~tdsilva] - another potential way of dea
[
https://issues.apache.org/jira/browse/PHOENIX-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498889#comment-14498889
]
Sergey Benner commented on PHOENIX-1618:
A small question here.
Is it more than
[
https://issues.apache.org/jira/browse/PHOENIX-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498825#comment-14498825
]
James Taylor commented on PHOENIX-1872:
---
Sure, that's fine too.
> Support Primiti
[
https://issues.apache.org/jira/browse/PHOENIX-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498823#comment-14498823
]
Alex Warshavsky commented on PHOENIX-1872:
--
Since getArrayFactory is already an
[
https://issues.apache.org/jira/browse/PHOENIX-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498783#comment-14498783
]
James Taylor commented on PHOENIX-1872:
---
Ah, that explains why we didn't do it ori
Geoffrey Jacoby created PHOENIX-1880:
Summary: Connections from QueryUtil.getConnection don't work on
secure clusters
Key: PHOENIX-1880
URL: https://issues.apache.org/jira/browse/PHOENIX-1880
Proj
[
https://issues.apache.org/jira/browse/PHOENIX-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498756#comment-14498756
]
Maryann Xue commented on PHOENIX-1879:
--
[~julianhyde] Could you please give some id
Maryann Xue created PHOENIX-1879:
Summary: Provide prepare statement hooks for Phoenix/Calcite
Integration
Key: PHOENIX-1879
URL: https://issues.apache.org/jira/browse/PHOENIX-1879
Project: Phoenix
[
https://issues.apache.org/jira/browse/PHOENIX-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498738#comment-14498738
]
Maryann Xue commented on PHOENIX-1878:
--
[~julianhyde] Could you please review our c
Maryann Xue created PHOENIX-1878:
Summary: Implement PhoenixSchema and PhoenixTable in
Phoenix/Calcite Integration
Key: PHOENIX-1878
URL: https://issues.apache.org/jira/browse/PHOENIX-1878
Project: Ph
[
https://issues.apache.org/jira/browse/PHOENIX-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498690#comment-14498690
]
Alex Warshavsky edited comment on PHOENIX-1872 at 4/16/15 8:41 PM:
---
[
https://issues.apache.org/jira/browse/PHOENIX-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498690#comment-14498690
]
Alex Warshavsky commented on PHOENIX-1872:
--
[~jamestaylor] BooleanCodec doesn't
[
https://issues.apache.org/jira/browse/PHOENIX-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498617#comment-14498617
]
James Taylor commented on PHOENIX-1877:
---
[~jmahonin], [~maghamravikiran] - do thes
[
https://issues.apache.org/jira/browse/PHOENIX-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498615#comment-14498615
]
ASF GitHub Bot commented on PHOENIX-1733:
-
GitHub user abisek opened a pull requ
GitHub user abisek opened a pull request:
https://github.com/apache/phoenix/pull/69
PHOENIX-1733: sqlline.py doesn't allow connecting with a tenant-specific...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/abisek/phoenix 4.x-HB
[
https://issues.apache.org/jira/browse/PHOENIX-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498604#comment-14498604
]
James Taylor commented on PHOENIX-1710:
---
Good ideas, [~aakash.pradeep]. It seems t
[
https://issues.apache.org/jira/browse/PHOENIX-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Taylor updated PHOENIX-1710:
--
Assignee: Aakash Pradeep (was: NIsala Niroshana)
> Implement the json_extract_path_text built
[
https://issues.apache.org/jira/browse/PHOENIX-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498584#comment-14498584
]
Aakash Pradeep edited comment on PHOENIX-1710 at 4/16/15 7:54 PM:
[
https://issues.apache.org/jira/browse/PHOENIX-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498584#comment-14498584
]
Aakash Pradeep edited comment on PHOENIX-1710 at 4/16/15 7:52 PM:
[
https://issues.apache.org/jira/browse/PHOENIX-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498584#comment-14498584
]
Aakash Pradeep commented on PHOENIX-1710:
-
IMHO we should make this method more
[
https://issues.apache.org/jira/browse/PHOENIX-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498581#comment-14498581
]
Abhishek Sreenivasa commented on PHOENIX-1733:
--
Wrapping the argument passe
[
https://issues.apache.org/jira/browse/PHOENIX-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498569#comment-14498569
]
James Taylor commented on PHOENIX-1863:
---
[~Dumindux] - thanks for the new tests -
[
https://issues.apache.org/jira/browse/PHOENIX-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Taylor updated PHOENIX-1861:
--
Fix Version/s: 4.3.2
> Padding character should be inverted if sort order is descending
>
[
https://issues.apache.org/jira/browse/PHOENIX-1876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Taylor resolved PHOENIX-1876.
---
Resolution: Fixed
Fix Version/s: 4.4.0
5.0.0
4.3
James Taylor created PHOENIX-1877:
-
Summary: Spark end2end tests are breaking the build
Key: PHOENIX-1877
URL: https://issues.apache.org/jira/browse/PHOENIX-1877
Project: Phoenix
Issue Type:
[
https://issues.apache.org/jira/browse/PHOENIX-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498402#comment-14498402
]
Hudson commented on PHOENIX-1870:
-
FAILURE: Integrated in Phoenix-master #684 (See
[htt
[
https://issues.apache.org/jira/browse/PHOENIX-1876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498401#comment-14498401
]
Hudson commented on PHOENIX-1876:
-
FAILURE: Integrated in Phoenix-master #684 (See
[htt
Github user 7shurik commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/68#discussion_r28532568
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PhoenixArray.java ---
@@ -561,6 +666,23 @@ public int estimateByteSize(int pos) {
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/68#discussion_r28529952
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PhoenixArray.java ---
@@ -561,6 +666,23 @@ public int estimateByteSize(int pos) {
[
https://issues.apache.org/jira/browse/PHOENIX-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Taylor updated PHOENIX-1870:
--
Attachment: PHOENIX-1870_v2.patch
[~shuxi0ng] - here's an updated patch that fixes a number of
Github user 7shurik commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/68#discussion_r28529111
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PhoenixArray.java ---
@@ -561,6 +666,23 @@ public int estimateByteSize(int pos) {
[
https://issues.apache.org/jira/browse/PHOENIX-1876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498310#comment-14498310
]
Samarth Jain commented on PHOENIX-1876:
---
+1 for 4.3
> Check for null function arg
[
https://issues.apache.org/jira/browse/PHOENIX-1876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Taylor updated PHOENIX-1876:
--
Attachment: PHOENIX-1876.patch
Another one we should get into 4.3 branch, IMO [~samarthjain].
[
https://issues.apache.org/jira/browse/PHOENIX-1876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Taylor reassigned PHOENIX-1876:
-
Assignee: James Taylor
> Check for null function arguments before evaluating when const
James Taylor created PHOENIX-1876:
-
Summary: Check for null function arguments before evaluating when
constant
Key: PHOENIX-1876
URL: https://issues.apache.org/jira/browse/PHOENIX-1876
Project: Phoeni
[
https://issues.apache.org/jira/browse/PHOENIX-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498267#comment-14498267
]
Rajeshbabu Chintaguntla commented on PHOENIX-538:
-
bq. We could have a lo
[
https://issues.apache.org/jira/browse/PHOENIX-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498256#comment-14498256
]
James Taylor commented on PHOENIX-1856:
---
Yes, only populate the existing MIN/MAX f
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/68#discussion_r28526475
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PhoenixArray.java ---
@@ -561,6 +666,23 @@ public int estimateByteSize(int pos) {
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/68#discussion_r28526230
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PhoenixArray.java ---
@@ -561,6 +666,23 @@ public int estimateByteSize(int pos) {
[
https://issues.apache.org/jira/browse/PHOENIX-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajeshbabu Chintaguntla updated PHOENIX-538:
Attachment: PHOENIX-538_v2.patch
> Support UDFs
>
>
>
Github user 7shurik commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/68#discussion_r28524479
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java ---
@@ -1098,8 +1098,10 @@ public String toStringLiteral(byte[] b, int off
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/68#discussion_r28524298
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java ---
@@ -1098,8 +1098,10 @@ public String toStringLiteral(byte[] b, int
[
https://issues.apache.org/jira/browse/PHOENIX-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498227#comment-14498227
]
James Taylor commented on PHOENIX-538:
--
bq. Can we have a check(make classname as pa
[
https://issues.apache.org/jira/browse/PHOENIX-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maryann Xue updated PHOENIX-1851:
-
Description:
The RelMetadataProvider is to provide information required for calculating cost
fo
[
https://issues.apache.org/jira/browse/PHOENIX-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maryann Xue updated PHOENIX-1851:
-
Summary: Implement PhoenixRelMetadataProvider in Phoenix/Calcite
Integration (was: Implement Ph
[
https://issues.apache.org/jira/browse/PHOENIX-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498068#comment-14498068
]
Dumindu Buddhika commented on PHOENIX-1861:
---
Oh... right.
I am sorry for havin
Dumindu Buddhika created PHOENIX-1875:
-
Summary: implement ARRAY_PREPEND built in function
Key: PHOENIX-1875
URL: https://issues.apache.org/jira/browse/PHOENIX-1875
Project: Phoenix
Issue
[
https://issues.apache.org/jira/browse/PHOENIX-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498020#comment-14498020
]
ramkrishna.s.vasudevan commented on PHOENIX-1856:
-
I think at the table
[
https://issues.apache.org/jira/browse/PHOENIX-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498010#comment-14498010
]
ramkrishna.s.vasudevan commented on PHOENIX-1856:
-
[~giacomotaylor]
You
[
https://issues.apache.org/jira/browse/PHOENIX-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497862#comment-14497862
]
Rajeshbabu Chintaguntla commented on PHOENIX-538:
-
bq. Will you dynamical
[
https://issues.apache.org/jira/browse/PHOENIX-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497839#comment-14497839
]
James Taylor commented on PHOENIX-538:
--
bq. It's same at client and server side. Mak
[
https://issues.apache.org/jira/browse/PHOENIX-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1449#comment-1449
]
Rajeshbabu Chintaguntla edited comment on PHOENIX-538 at 4/16/15 8:39 AM:
-
[
https://issues.apache.org/jira/browse/PHOENIX-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1449#comment-1449
]
Rajeshbabu Chintaguntla commented on PHOENIX-538:
-
Thanks [~jamestaylor]
[
https://issues.apache.org/jira/browse/PHOENIX-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497724#comment-14497724
]
James Taylor commented on PHOENIX-538:
--
Thanks for the revisions, [~rajeshbabu].
bq
[
https://issues.apache.org/jira/browse/PHOENIX-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497685#comment-14497685
]
Serhiy Bilousov commented on PHOENIX-1759:
--
I had little time to go over. Will
59 matches
Mail list logo
