[jira] [Commented] (PHOENIX-2021) Implement ARRAY_CAT built in function

2015-06-18 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593105#comment-14593105 ] ramkrishna.s.vasudevan commented on PHOENIX-2021: - [~Dumindux] The forma

[jira] [Updated] (PHOENIX-2021) Implement ARRAY_CAT built in function

2015-06-18 Thread Dumindu Buddhika (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dumindu Buddhika updated PHOENIX-2021: -- Attachment: PHOENIX-2021-v4.patch New patch > Implement ARRAY_CAT built in function >

[jira] [Updated] (PHOENIX-2046) Metadata for queries returns wrong precision and scale

2015-06-18 Thread Pasupathy M (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pasupathy M updated PHOENIX-2046: - Description: We have a query (typical query to a sample foodmart in mondrian) select "time_by_da

[jira] [Updated] (PHOENIX-2046) Metadata for queries returns wrong precision and scale

2015-06-18 Thread Pasupathy M (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pasupathy M updated PHOENIX-2046: - Environment: Phoenix 4.4 and Hbase 1.1 (was: We have a query (typical query to a sample foodmar

[jira] [Updated] (PHOENIX-2045) Metadata for tables that has index has null columns

2015-06-18 Thread Pasupathy M (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pasupathy M updated PHOENIX-2045: - Environment: Phoenix 4.4/ Hbase 1.1 (was: phoenix 4.4/ Hbase 1.1) > Metadata for tables that ha

[jira] [Updated] (PHOENIX-2045) Metadata for tables that has index has null columns

2015-06-18 Thread Pasupathy M (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pasupathy M updated PHOENIX-2045: - Description: We have a table create table t1(x varchar primary key, y integer) and an index is c

[jira] [Updated] (PHOENIX-2045) Metadata for tables that has index has null columns

2015-06-18 Thread Pasupathy M (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pasupathy M updated PHOENIX-2045: - Environment: phoenix 4.4/ Hbase 1.1 (was: We have a table create table t1(x varchar primary key,

[jira] [Commented] (PHOENIX-2057) Acquire lock in MetaDataEndPointImpl.addRowsToChildViews() before calling doGetTable()

2015-06-18 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592947#comment-14592947 ] Samarth Jain commented on PHOENIX-2057: --- Thanks! Pushed to 4.x-HBase-0.98, master

[jira] [Commented] (PHOENIX-2057) Acquire lock in MetaDataEndPointImpl.addRowsToChildViews() before calling doGetTable()

2015-06-18 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592931#comment-14592931 ] James Taylor commented on PHOENIX-2057: --- +1. Thanks for the quick turnaround, [~sa

[jira] [Updated] (PHOENIX-2057) Acquire lock in MetaDataEndPointImpl.addRowsToChildViews() before calling doGetTable()

2015-06-18 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-2057: -- Fix Version/s: 4.5.0 5.0.0 > Acquire lock in MetaDataEndPointImpl.addRowsTo

[jira] [Updated] (PHOENIX-2057) Acquire lock in MetaDataEndPointImpl.addRowsToChildViews() before calling doGetTable()

2015-06-18 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-2057: -- Attachment: PHOENIX-2057.patch Attached patch. [~jamestaylor] - please review when you get a c

[jira] [Created] (PHOENIX-2058) Check for existence and compatibility of columns being added in view

2015-06-18 Thread James Taylor (JIRA)
James Taylor created PHOENIX-2058: - Summary: Check for existence and compatibility of columns being added in view Key: PHOENIX-2058 URL: https://issues.apache.org/jira/browse/PHOENIX-2058 Project: Pho

[jira] [Created] (PHOENIX-2057) Acquire lock in MetaDataEndPointImpl.addRowsToChildViews() before calling doGetTable()

2015-06-18 Thread James Taylor (JIRA)
James Taylor created PHOENIX-2057: - Summary: Acquire lock in MetaDataEndPointImpl.addRowsToChildViews() before calling doGetTable() Key: PHOENIX-2057 URL: https://issues.apache.org/jira/browse/PHOENIX-2057

[jira] [Updated] (PHOENIX-2056) Ensure PK column from base table is added to any indexes on views

2015-06-18 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-2056: -- Description: Given that we allow a nullable PK column to be added to a base table and push it

[jira] [Commented] (PHOENIX-2042) Windows need hadoop native libraries to run tests

2015-06-18 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592711#comment-14592711 ] Enis Soztutar commented on PHOENIX-2042: The patch looks good. We did the same t

[jira] [Created] (PHOENIX-2056) Ensure PK column from base table is added to any indexes on views

2015-06-18 Thread James Taylor (JIRA)
James Taylor created PHOENIX-2056: - Summary: Ensure PK column from base table is added to any indexes on views Key: PHOENIX-2056 URL: https://issues.apache.org/jira/browse/PHOENIX-2056 Project: Phoen

[jira] [Updated] (PHOENIX-2055) Allow view with views to add column

2015-06-18 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-2055: -- Description: Minor follow on to PHOENIX-1504. Due to the potential slowness of the check for w

[jira] [Updated] (PHOENIX-1504) Support adding column to a table that has views

2015-06-18 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-1504: -- Attachment: PHOENIX-1504-4.x-1.0.patch PHOENIX-1504_master.patch Thanks for th

[jira] [Commented] (PHOENIX-2055) Allow view with views to add column

2015-06-18 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592691#comment-14592691 ] James Taylor commented on PHOENIX-2055: --- [~samarthjain] - what do you think? If yo

[jira] [Created] (PHOENIX-2055) Allow view with views to add column

2015-06-18 Thread James Taylor (JIRA)
James Taylor created PHOENIX-2055: - Summary: Allow view with views to add column Key: PHOENIX-2055 URL: https://issues.apache.org/jira/browse/PHOENIX-2055 Project: Phoenix Issue Type: Bug

[jira] [Updated] (PHOENIX-2054) Automatically add columns added to a view to all its child views

2015-06-18 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-2054: -- Description: Similar to PHOENIX-1504, but specific to a VIEW that has child VIEWs. When a colu

[jira] [Created] (PHOENIX-2054) Automatically add columns added to a view to all its child views

2015-06-18 Thread James Taylor (JIRA)
James Taylor created PHOENIX-2054: - Summary: Automatically add columns added to a view to all its child views Key: PHOENIX-2054 URL: https://issues.apache.org/jira/browse/PHOENIX-2054 Project: Phoenix

[jira] [Commented] (PHOENIX-1504) Support adding column to a table that has views

2015-06-18 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592531#comment-14592531 ] James Taylor commented on PHOENIX-1504: --- +1. Looks great, [~samarthjain]. > Suppo

[jira] [Commented] (PHOENIX-2053) The Expression IN has Bug when the params are less than zero

2015-06-18 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592512#comment-14592512 ] James Taylor commented on PHOENIX-2053: --- Please provide the Phoenix version and th

[jira] [Updated] (PHOENIX-1504) Support adding column to a table that has views

2015-06-18 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-1504: -- Attachment: PHOENIX-1504_v3.patch Updated patch. > Support adding column to a table that has

Re: [DISCUSS] drop 4.x-HBase-1.1 branch

2015-06-18 Thread James Taylor
Do you know of a good way to verify that? There will legitimately be differences, though (for example, PHOENIX-1681). I know too that 4.x-HBase-1.1 is missing commits from master. On Thu, Jun 18, 2015 at 1:28 PM, Nick Dimiduk wrote: > Fair point, commits should be starting at master and working t

Re: [DISCUSS] drop 4.x-HBase-1.1 branch

2015-06-18 Thread Nick Dimiduk
Fair point, commits should be starting at master and working their way back. We'll still need to verify that all the 4.x branches have the same patches as master. On Thu, Jun 18, 2015 at 12:09 PM, James Taylor wrote: > I don't know how to verify they have the same patches, but why would > master

Re: Reconsidering the shim later

2015-06-18 Thread James Taylor
I agree, this is becoming unmanageable. Do we think that post HBase 1.1 and us being on supported APIs (even in coprocessor land) that we'll need a shim layer? If likely not, then our branches will shrink over time (hopefully sooner rather than later), so maybe we can live with the current strategy

Re: [DISCUSS] drop 4.x-HBase-1.1 branch

2015-06-18 Thread James Taylor
I don't know how to verify they have the same patches, but why would master be missing commits from the 4.x-HBase-1.1 branch? I do see commits missing from the 4.x-HBase-1.1 branch, though. When I run the unit tests on this branch after adding some of the missing commits, I get failures while the

[GitHub] phoenix pull request: Mixed R/W workload support

2015-06-18 Thread codymarcel
Github user codymarcel commented on a diff in the pull request: https://github.com/apache/phoenix/pull/89#discussion_r32766179 --- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java --- @@ -135,10 +154,7 @@ public synchronized boolean shouldStop() {

[GitHub] phoenix pull request: Mixed R/W workload support

2015-06-18 Thread codymarcel
Github user codymarcel commented on a diff in the pull request: https://github.com/apache/phoenix/pull/89#discussion_r32765859 --- Diff: phoenix-pherf/src/it/java/org/apache/phoenix/pherf/PherfMainIT.java --- @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] phoenix pull request: Mixed R/W workload support

2015-06-18 Thread samarthjain
Github user samarthjain commented on a diff in the pull request: https://github.com/apache/phoenix/pull/89#discussion_r32765259 --- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java --- @@ -135,10 +154,7 @@ public synchronized boolean shouldStop() {

[GitHub] phoenix pull request: Mixed R/W workload support

2015-06-18 Thread samarthjain
Github user samarthjain commented on a diff in the pull request: https://github.com/apache/phoenix/pull/89#discussion_r32764360 --- Diff: phoenix-pherf/src/it/java/org/apache/phoenix/pherf/PherfMainIT.java --- @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundat

Re: [DISCUSS] drop 4.x-HBase-1.1 branch

2015-06-18 Thread Nick Dimiduk
I'd feel better if a check was done to verify they carry the same patches. I'd also like this to be followed up with a discussion about fix versions in JIRA and how they relate to git branches. For instance, we've had 5.0.0 for ages, but it seems even master will be 4.5.0-SNAPSHOT-HBase-1.1. Shoul

[GitHub] phoenix pull request: Mixed R/W workload support

2015-06-18 Thread samarthjain
Github user samarthjain commented on a diff in the pull request: https://github.com/apache/phoenix/pull/89#discussion_r32764170 --- Diff: phoenix-pherf/src/it/java/org/apache/phoenix/pherf/DataIngestIT.java --- @@ -18,70 +18,122 @@ package org.apache.phoenix.pherf;

[GitHub] phoenix pull request: Mixed R/W workload support

2015-06-18 Thread codymarcel
Github user codymarcel commented on a diff in the pull request: https://github.com/apache/phoenix/pull/89#discussion_r32763915 --- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/QueryExecutor.java --- @@ -18,227 +18,271 @@ package org.apache.phoenix

Re: [DISCUSS] drop 4.x-HBase-1.1 branch

2015-06-18 Thread James Taylor
Ok, I'll plan to drop the 4.x-HBase-1.1 branch by EOD this Friday, 6/19. Thanks, James On Thu, Jun 18, 2015 at 6:44 AM, rajeshb...@apache.org wrote: > +1 to drop. > > On Wed, Jun 17, 2015 at 3:08 AM, James Taylor > wrote: > >> Until master would diverge from 4.x-HBase-1.1 branch, I don't think w

[jira] [Commented] (PHOENIX-1504) Support adding column to a table that has views

2015-06-18 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592133#comment-14592133 ] James Taylor commented on PHOENIX-1504: --- +1 to allowing nullable PK columns to be

[jira] [Comment Edited] (PHOENIX-590) Provide multiple versions support in external HBase tables

2015-06-18 Thread Sergey (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591995#comment-14591995 ] Sergey edited comment on PHOENIX-590 at 6/18/15 3:42 PM: - This fe

[jira] [Commented] (PHOENIX-590) Provide multiple versions support in external HBase tables

2015-06-18 Thread Sergey (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591995#comment-14591995 ] Sergey commented on PHOENIX-590: This feature also gives us a chance to utilize built-in

[jira] [Commented] (PHOENIX-590) Provide multiple versions support in external HBase tables

2015-06-18 Thread Sergey (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591886#comment-14591886 ] Sergey commented on PHOENIX-590: This feature also gives us a chance to utilize built-in

Re: [DISCUSS] drop 4.x-HBase-1.1 branch

2015-06-18 Thread rajeshb...@apache.org
+1 to drop. On Wed, Jun 17, 2015 at 3:08 AM, James Taylor wrote: > Until master would diverge from 4.x-HBase-1.1 branch, I don't think we > need it, so I propose we drop it. It's just added overhead at this > point and is missing commits from master as well. > > Please let me know if you think w

[jira] [Updated] (PHOENIX-2030) CsvBulkLoadTool should use logical name of the table for output directory suffix

2015-06-18 Thread Rajeshbabu Chintaguntla (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajeshbabu Chintaguntla updated PHOENIX-2030: - Attachment: PHOENIX-2030.patch Here is the simple patch. > CsvBulkLoad

[jira] [Created] (PHOENIX-2053) The Expression IN has Bug when the params are less than zero

2015-06-18 Thread PeiLiping (JIRA)
PeiLiping created PHOENIX-2053: -- Summary: The Expression IN has Bug when the params are less than zero Key: PHOENIX-2053 URL: https://issues.apache.org/jira/browse/PHOENIX-2053 Project: Phoenix

[jira] [Created] (PHOENIX-2052) Division Bug In Group By SQL The result turn to NULL

2015-06-18 Thread PeiLiping (JIRA)
PeiLiping created PHOENIX-2052: -- Summary: Division Bug In Group By SQL The result turn to NULL Key: PHOENIX-2052 URL: https://issues.apache.org/jira/browse/PHOENIX-2052 Project: Phoenix Issue

[jira] [Updated] (PHOENIX-1504) Support adding column to a table that has views

2015-06-18 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-1504: -- Attachment: PHOENIX-1504_v2.patch Updated patch. I added a test AlterTableIT#testChangingPKOf