[GitHub] phoenix issue #320: PHOENIX-4820

Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/320 Thanks for the earlier comment, @maryannxue. Do you think this approach is a good first step? Can you think of any cases where this approach will be problematic? ---

[GitHub] phoenix pull request #320: PHOENIX-4820

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/320#discussion_r206717157 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java --- @@ -2951,7 +2951,129 @@ public void

[GitHub] phoenix pull request #320: PHOENIX-4820

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/320#discussion_r206715618 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java --- @@ -2951,7 +2951,129 @@ public void

[GitHub] phoenix issue #298: PHOENIX-4666 Persistent subquery cache for hash joins

Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/298 Looks really good to me. Nice work, @ortutay! Any further comments, @maryannxue? ---

[GitHub] phoenix issue #308: Client-side hash aggregation

Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/308 +1. Nice work, @geraldss. @twdsilva - would you (or maybe someone else?) have some spare cycles to check this in assuming the test run comes back clean? ---

[GitHub] phoenix pull request #317: PHOENIX-3547 Supporting more number of indices pe...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/317#discussion_r206328431 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ExplainTable.java --- @@ -204,14 +205,19 @@ private void appendPKColumnValue

[GitHub] phoenix pull request #317: PHOENIX-3547 Supporting more number of indices pe...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/317#discussion_r206326382 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -1431,11 +1438,42 @@ private PTable getTable

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r206295564 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/ClientAggregatePlan.java --- @@ -135,17 +142,25 @@ public ResultIterator iterator

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r206295347 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ClientHashAggregateIT.java --- @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache

[GitHub] phoenix pull request #314: PHOENIX-4820

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/314#discussion_r205981788 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/Expression.java --- @@ -88,4 +88,10 @@ * @return

[GitHub] phoenix pull request #314: PHOENIX-4820

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/314#discussion_r205981903 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/ExpressionUtil.java --- @@ -68,4 +74,85 @@ public static boolean isPkPositionChanging

[GitHub] phoenix pull request #314: PHOENIX-4820

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/314#discussion_r205982004 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java --- @@ -559,8 +559,16 @@ protected QueryPlan

[GitHub] phoenix issue #308: Client-side hash aggregation

Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/308 Looks like the move of 5.x branch to become master messed up this PR. Can you please start a new pull request against the 4.x-HBase-1.4 branch (this is what was master before), @geraldss? FYI

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r205232207 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/ClientAggregatePlan.java --- @@ -183,13 +198,15 @@ public ExplainPlan getExplainPlan

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r205229353 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ClientHashAggregateIT.java --- @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r205231380 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/ClientAggregatePlan.java --- @@ -135,17 +142,25 @@ public ResultIterator iterator

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r205230186 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/ClientAggregatePlan.java --- @@ -135,17 +142,25 @@ public ResultIterator iterator

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r204197328 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/ClientAggregatePlan.java --- @@ -135,17 +142,24 @@ public ResultIterator iterator

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r204196968 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java --- @@ -0,0 +1,189

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r204167291 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java --- @@ -0,0 +1,189

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r204161104 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java --- @@ -0,0 +1,189

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r204176238 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java --- @@ -0,0 +1,189

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r204168576 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java --- @@ -0,0 +1,189

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r203867850 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java --- @@ -0,0 +1,173

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r203882988 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashSizeException.java --- @@ -0,0 +1,33 @@ +/* + * Licensed to the

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r203868079 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java --- @@ -0,0 +1,173

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r203879864 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/ClientAggregatePlan.java --- @@ -135,17 +142,24 @@ public ResultIterator iterator

[GitHub] phoenix pull request #308: Client-side hash aggregation

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r202842452 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java --- @@ -0,0 +1,155

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r200208444 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java --- @@ -1893,26 +1981,45 @@ public static void upgradeTable

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r200208319 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -1779,13 +2174,65 @@ public void createTable

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r200209126 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java --- @@ -372,6 +378,31 @@ public void testViewAndTableAndDrop() throws

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r200206862 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -1809,180 +2256,97 @@ public void createTable

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r200208028 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -447,7 +447,7 @@ static

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r200208160 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/TableProperty.java --- @@ -231,36 +231,26 @@ public Object getPTableValue(PTable table

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r200207759 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -1957,6 +1968,17 @@ private PTable createTableInternal

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r200207594 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -3642,30 +3596,62 @@ private void dropIndexes

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r200207388 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -2573,307 +2897,139 @@ else if (pkCount

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r200205809 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -586,48 +590,359 @@ public void getTable

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r200206109 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -586,48 +590,359 @@ public void getTable

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r200207100 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -2147,46 +2566,29 @@ private

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r200206293 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -1457,28 +1791,110 @@ private static void

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r200206428 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -1488,20 +1904,19 @@ public void createTable

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r200206792 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -1809,180 +2256,97 @@ public void createTable

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r200206389 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -1457,28 +1791,110 @@ private static void

[GitHub] phoenix issue #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG table

Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/303 +1 to the patch. Great work @twdsilva and @churrodog! I made some minor comments for some potential follow up work and had a few questions, but let's get this committed first. I'd

[GitHub] phoenix pull request #305: Omid2

GitHub user JamesRTaylor opened a pull request: https://github.com/apache/phoenix/pull/305 Omid2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/phoenix omid2 Alternatively you can review and apply these changes as the

[GitHub] phoenix issue #298: PHOENIX-4666 Persistent subquery cache for hash joins

Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/298 Is this ready to go, @ortutay? It looks pretty clean now. ---

[GitHub] phoenix pull request #298: PHOENIX-4666 Persistent subquery cache for hash j...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/298#discussion_r195421295 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java --- @@ -1305,14 +1305,25 @@ public ScanWrapper(Scan scan

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r192570609 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java --- @@ -388,51 +435,65 @@ public void testViewAndTableInDifferentSchemas

[GitHub] phoenix issue #300: Omid transaction support in Phoenix

Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/300 Opened on behalf of @ohadshacham . ---

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r192309043 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java --- @@ -388,51 +435,65 @@ public void testViewAndTableInDifferentSchemas

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r192308674 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/coprocessor/MetaDataEndpointImplTest.java --- @@ -0,0 +1,299 @@ +package

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r191944884 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java --- @@ -388,51 +435,65 @@ public void testViewAndTableInDifferentSchemas

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r191942250 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -2227,35 +2551,36 @@ private

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r191940463 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -1995,36 +2287,46 @@ public void dropTable

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r191939788 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -1457,28 +1761,69 @@ private static void

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r191938147 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -586,48 +573,336 @@ public void getTable

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r191936918 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/coprocessor/MetaDataEndpointImplTest.java --- @@ -0,0 +1,299 @@ +package

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r191936296 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java --- @@ -1253,7 +1253,9 @@ public void

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r191935338 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/PColumnImpl.java --- @@ -156,14 +209,14 @@ public String toString

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r191933107 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2967,6 +2982,11 @@ protected PhoenixConnection

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r191932416 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java --- @@ -479,179 +498,355 @@ private void addTenantIdFilter

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r191931341 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java --- @@ -479,179 +498,355 @@ private void addTenantIdFilter

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r191927956 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java --- @@ -293,6 +293,7 @@ public SQLException newException

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r191926624 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java --- @@ -388,51 +435,65 @@ public void testViewAndTableInDifferentSchemas

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r191925360 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ExplainPlanWithStatsEnabledIT.java --- @@ -1202,33 +1202,44 @@ private void

[GitHub] phoenix pull request #301: PHOENIX-4728 The upsert select must project tuple...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/301#discussion_r190381688 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java --- @@ -549,7 +549,7 @@ public MutationPlan compile

[GitHub] phoenix pull request #300: Omid transaction support in Phoenix

GitHub user JamesRTaylor opened a pull request: https://github.com/apache/phoenix/pull/300 Omid transaction support in Phoenix You can merge this pull request into a Git repository by running: $ git pull https://github.com/ohadshacham/phoenix 4.x-HBase-1.3-Omid-2

[GitHub] phoenix pull request #299: 4.x h base 1.3 omid 2

Github user JamesRTaylor closed the pull request at: https://github.com/apache/phoenix/pull/299 ---

[GitHub] phoenix pull request #299: 4.x h base 1.3 omid 2

GitHub user JamesRTaylor opened a pull request: https://github.com/apache/phoenix/pull/299 4.x h base 1.3 omid 2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ohadshacham/phoenix 4.x-HBase-1.3-Omid-2 Alternatively you can

[GitHub] phoenix pull request #298: PHOENIX-4666 Persistent subquery cache for hash j...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/298#discussion_r187393698 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/cache/ServerCacheClient.java --- @@ -216,22 +234,146 @@ public void close() throws

[GitHub] phoenix issue #297: PHOENIX-4575: Phoenix metadata KEEP_DELETED_CELLS and VE...

Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/297 +1. Thanks for taking this to the finish line, @ChinmaySKulkarni. Is this on top of your patch for PHOENIX-4579? What order should I commit them? ---

[GitHub] phoenix issue #295: PHOENIX-4579: Add a config to conditionally create Phoen...

Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/295 +1. Nice work, @ChinmaySKulkarni! I'll get this committed. Might need some help with a patch that applied to 5.x-HBase-2.0 branch. ---

[GitHub] phoenix issue #295: PHOENIX-4579: Add a config to conditionally create Phoen...

Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/295 If possible, we shouldn't modify SYSTEM table metadata after the HBase table has been created even if auto-upgrade is enabled. ---

[GitHub] phoenix issue #295: PHOENIX-4579: Add a config to conditionally create Phoen...

Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/295 Thanks for the updates, @ChinmaySKulkarni. Looks like you still need to rebase it. Also, one test that would be really valuable would be to: * disable auto upgrade * run execute upgrade

[GitHub] phoenix issue #295: PHOENIX-4579: Add a config to conditionally create Phoen...

Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/295 This looks good. Couple of minor things for the tests, and then rebase it and I think we'll be good to go. Nice work, @ChinmaySKulkarni. ---

[GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/295#discussion_r180946851 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogCreationOnConnectionIT.java --- @@ -0,0 +1,577 @@ +/* + * Licensed

[GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/295#discussion_r180945785 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogCreationOnConnectionIT.java --- @@ -0,0 +1,577 @@ +/* + * Licensed

[GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/295#discussion_r180945611 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogCreationOnConnectionIT.java --- @@ -0,0 +1,577 @@ +/* + * Licensed

[GitHub] phoenix issue #296: PHOENIX-4668: Remove unnecessary table descriptor modifi...

Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/296 +1. Will commit soon. ---

[GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/295#discussion_r179000414 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2643,6 +2661,26 @@ public void

[GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/295#discussion_r178935257 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2643,6 +2661,26 @@ public void

[GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/295#discussion_r178936752 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogCreationOnConnectionIT.java --- @@ -0,0 +1,533 @@ +/* + * Licensed

[GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/295#discussion_r178933517 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -1039,10 +1065,20 @@ private HTableDescriptor

[GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/295#discussion_r178936507 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogCreationOnConnectionIT.java --- @@ -0,0 +1,533 @@ +/* + * Licensed

[GitHub] phoenix issue #295: PHOENIX-4579: Add a config to conditionally create Phoen...

Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/295 I think it's ok to make these changes. Not a problem to make DO_NOT_UPGRADE public if need be. Feel free to add new arguments if necessary to ensureTableCreated. I think any special

[GitHub] phoenix issue #294: PHOENIX-4643 Implement ARRAY_REMOVE built in function

Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/294 +1. Thanks for the contribution, @xjodoin. I'll commit this to the various branches. ---

[GitHub] phoenix issue #295: PHOENIX-4579: Add a config to conditionally create Phoen...

Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/295 Thinking more, I think it’s fine to go through the CREATE TABLE code path and move the logic in the try block of init down into ensureTableCreated. It’s only called once on the first

[GitHub] phoenix issue #295: PHOENIX-4579: Add a config to conditionally create Phoen...

Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/295 Ok, sounds like a good plan. ---

[GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/295#discussion_r176783002 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2405,16 +2413,26 @@ public Void call() throws

[GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/295#discussion_r176520222 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2405,16 +2413,26 @@ public Void call() throws

[GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/295#discussion_r176506809 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2405,16 +2413,26 @@ public Void call() throws

[GitHub] phoenix issue #295: WIP: Added check for system catalog timestamp while doin...

Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/295 Please amend your commit message to be in the form: PHOENIX-4579 That way, PR comments will automatically appear as JIRA comments. ---

[GitHub] phoenix issue #294: PHOENIX-4643 Implement ARRAY_REMOVE built in function

Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/294 Looks good - one minor nit and then I think we'll be good to go. ---

[GitHub] phoenix pull request #294: PHOENIX-4643 Implement ARRAY_REMOVE built in func...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/294#discussion_r175620626 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ArrayRemoveFunctionIT.java --- @@ -0,0 +1,383 @@ +/* + * Licensed to the Apache

[GitHub] phoenix pull request #294: PHOENIX-4643 Implement ARRAY_REMOVE built in func...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/294#discussion_r175225740 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ArrayRemoveFunctionIT.java --- @@ -0,0 +1,425 @@ +/* + * Licensed to the Apache

[GitHub] phoenix pull request #294: PHOENIX-4643 Implement ARRAY_REMOVE built in func...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/294#discussion_r175225898 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ArrayRemoveFunctionIT.java --- @@ -0,0 +1,425 @@ +/* + * Licensed to the Apache

[GitHub] phoenix pull request #294: PHOENIX-4643 Implement ARRAY_REMOVE built in func...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/294#discussion_r175226865 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ArrayRemoveFunctionIT.java --- @@ -0,0 +1,425 @@ +/* + * Licensed to the Apache

[GitHub] phoenix issue #294: PHOENIX-4643 Implement ARRAY_REMOVE built in function

Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/294 Changes look good. I've committed PHOENIX-4644, so can you make sure everything works without specify a default value for the second argument for ARRAY_REMOVE? ---

[GitHub] phoenix pull request #294: PHOENIX-4643 Implement ARRAY_REMOVE built in func...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/294#discussion_r173612840 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/ArrayRemoveFunction.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to

  1   2   3   4   5   6   7   8   9   10   >