Re: Phoenix code quality

2017-09-22 Thread Kevin Liew
Parts of the codebase can be quite intimidating due to the amount of state that needs to be tracked. In future patches, there could be an attempt to take cues from functional programming styles and decompose larger functions into "pure functions". This would make the project more accessible to new

[jira] [Commented] (PHOENIX-2314) Cannot prepare parameterized statement with a 'like' predicate

2017-09-03 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152072#comment-16152072 ] Kevin Liew commented on PHOENIX-2314: - Failures seem unrelated to patch.

[jira] [Updated] (PHOENIX-2314) Cannot prepare parameterized statement with a 'like' predicate

2017-09-03 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-2314: Attachment: PHOENIX-2314.5.patch > Cannot prepare parameterized statement with a 'like&#x

[jira] [Updated] (PHOENIX-2314) Cannot prepare parameterized statement with a 'like' predicate

2017-09-02 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-2314: Attachment: PHOENIX-2314.4.patch > Cannot prepare parameterized statement with a 'like&#x

[jira] [Updated] (PHOENIX-2314) Cannot prepare parameterized statement with a 'like' predicate

2017-09-01 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-2314: Attachment: PHOENIX-2314.3.patch Attaching patch. Will wait for test results before committing

[jira] [Assigned] (PHOENIX-3732) Support for dynamic columns in UPSERT in Phoenix-Calcite

2017-03-18 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew reassigned PHOENIX-3732: --- Assignee: Kevin Liew > Support for dynamic columns in UPSERT in Phoenix-Calc

[jira] [Commented] (PHOENIX-3732) Support for dynamic columns in UPSERT in Phoenix-Calcite

2017-03-13 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923496#comment-15923496 ] Kevin Liew commented on PHOENIX-3732: - To clarify, Phoenix supports the follo

[jira] [Commented] (PHOENIX-3732) Support for dynamic columns in UPSERT in Phoenix-Calcite

2017-03-13 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906936#comment-15906936 ] Kevin Liew commented on PHOENIX-3732: - Also, though Phoenix doesn't s

[jira] [Comment Edited] (PHOENIX-3732) Support for dynamic columns in UPSERT in Phoenix-Calcite

2017-03-12 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906933#comment-15906933 ] Kevin Liew edited comment on PHOENIX-3732 at 3/13/17 6:5

[jira] [Commented] (PHOENIX-3732) Support for dynamic columns in UPSERT in Phoenix-Calcite

2017-03-12 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906933#comment-15906933 ] Kevin Liew commented on PHOENIX-3732: - The Phoenix grammar for dynamic column

[jira] [Updated] (PHOENIX-3732) Support for dynamic columns in UPSERT in Phoenix-Calcite

2017-03-12 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3732: Description: https://phoenix.apache.org/dynamic_columns.html {quote} To upsert a row with

[jira] [Commented] (PHOENIX-3468) Double quote SYSTEM, USER,DATE keywords in IT tests

2017-03-12 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906452#comment-15906452 ] Kevin Liew commented on PHOENIX-3468: - FYI once CALCITE-1256 is fixed, we shoul

[jira] [Updated] (PHOENIX-3733) Calcite BOOLEAN returns precision of 1 but does not allow specifying a precision when creating an instance

2017-03-10 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3733: Attachment: PHOENIX-3733.patch [~maryannxue], [~rajeshbabu] please review > Calcite BOOL

[jira] [Created] (PHOENIX-3733) Calcite BOOLEAN returns precision of 1 but does not allow specifying a precision when creating an instance

2017-03-10 Thread Kevin Liew (JIRA)
Kevin Liew created PHOENIX-3733: --- Summary: Calcite BOOLEAN returns precision of 1 but does not allow specifying a precision when creating an instance Key: PHOENIX-3733 URL: https://issues.apache.org/jira/browse

[jira] [Assigned] (PHOENIX-3411) Support for Dynamic Columns in Phoenix-Calcite

2017-03-10 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew reassigned PHOENIX-3411: --- Assignee: Kevin Liew (was: Rajeshbabu Chintaguntla) > Support for Dynamic Columns

[jira] [Updated] (PHOENIX-3411) Support for Dynamic Columns in Phoenix-Calcite

2017-03-10 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3411: Attachment: PHOENIX-3411.patch [~rajeshbabu], [~maryannxue], I attached a patch that adds support

[jira] [Created] (PHOENIX-3732) Support for dynamic columns in UPSERT in Phoenix-Calcite

2017-03-10 Thread Kevin Liew (JIRA)
Kevin Liew created PHOENIX-3732: --- Summary: Support for dynamic columns in UPSERT in Phoenix-Calcite Key: PHOENIX-3732 URL: https://issues.apache.org/jira/browse/PHOENIX-3732 Project: Phoenix

[jira] [Commented] (PHOENIX-3730) Handle unspecified precision and scale for VARCHAR and VARBINARY in Phoenix-Calcite

2017-03-10 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906060#comment-15906060 ] Kevin Liew commented on PHOENIX-3730: - We can eventually change {{PD

[jira] [Updated] (PHOENIX-3731) Support modifiable views in Phoenix-Calcite

2017-03-10 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3731: Attachment: PHOENIX-3731.patch [~maryannxue], [~rajeshbabu] please review > Support modifia

[jira] [Created] (PHOENIX-3731) Support modifiable views in Phoenix-Calcite

2017-03-10 Thread Kevin Liew (JIRA)
Kevin Liew created PHOENIX-3731: --- Summary: Support modifiable views in Phoenix-Calcite Key: PHOENIX-3731 URL: https://issues.apache.org/jira/browse/PHOENIX-3731 Project: Phoenix Issue Type

[jira] [Updated] (PHOENIX-3730) Handle unspecified precision and scale for VARCHAR and VARBINARY in Phoenix-Calcite

2017-03-10 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3730: Attachment: PHOENIX-3730.patch [~rajeshbabu], [~maryannxue] please review the patch > Han

[jira] [Created] (PHOENIX-3730) Handle unspecified precision and scale for VARCHAR and VARBINARY in Phoenix-Calcite

2017-03-10 Thread Kevin Liew (JIRA)
Kevin Liew created PHOENIX-3730: --- Summary: Handle unspecified precision and scale for VARCHAR and VARBINARY in Phoenix-Calcite Key: PHOENIX-3730 URL: https://issues.apache.org/jira/browse/PHOENIX-3730

[jira] [Commented] (PHOENIX-2314) Cannot prepare parameterized statement with a 'like' predicate

2017-03-09 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902885#comment-15902885 ] Kevin Liew commented on PHOENIX-2314: - Ping [~jamestaylor], PHOENIX-3510 was li

[jira] [Commented] (PHOENIX-3712) Column alias can't be resolved in GROUP BY clause

2017-03-08 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901772#comment-15901772 ] Kevin Liew commented on PHOENIX-3712: - I will pick up that JIRA, though I m

[jira] [Comment Edited] (PHOENIX-3712) Column alias can't be resolved in GROUP BY clause

2017-03-04 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895889#comment-15895889 ] Kevin Liew edited comment on PHOENIX-3712 at 3/4/17 9:4

[jira] [Commented] (PHOENIX-3712) Column alias can't be resolved in GROUP BY clause

2017-03-04 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895889#comment-15895889 ] Kevin Liew commented on PHOENIX-3712: - Changing the test case is fine but we sh

[jira] [Commented] (PHOENIX-3690) Support declaring default values in Phoenix-Calcite

2017-02-24 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883983#comment-15883983 ] Kevin Liew commented on PHOENIX-3690: - I suggest we set PhoenixSchema.typeFac

[jira] [Comment Edited] (PHOENIX-3411) Support for Dynamic Columns in Phoenix-Calcite

2017-02-23 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881511#comment-15881511 ] Kevin Liew edited comment on PHOENIX-3411 at 2/23/17 11:0

[jira] [Comment Edited] (PHOENIX-3411) Support for Dynamic Columns in Phoenix-Calcite

2017-02-23 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881511#comment-15881511 ] Kevin Liew edited comment on PHOENIX-3411 at 2/23/17 10:5

[jira] [Comment Edited] (PHOENIX-3411) Support for Dynamic Columns in Phoenix-Calcite

2017-02-23 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881511#comment-15881511 ] Kevin Liew edited comment on PHOENIX-3411 at 2/23/17 10:5

[jira] [Commented] (PHOENIX-3411) Support for Dynamic Columns in Phoenix-Calcite

2017-02-23 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881511#comment-15881511 ] Kevin Liew commented on PHOENIX-3411: - Modifiable views depend on the Cal

[jira] [Comment Edited] (PHOENIX-476) Support declaration of DEFAULT in CREATE statement

2017-02-17 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15873022#comment-15873022 ] Kevin Liew edited comment on PHOENIX-476 at 2/18/17 6:5

[jira] [Commented] (PHOENIX-476) Support declaration of DEFAULT in CREATE statement

2017-02-17 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15873022#comment-15873022 ] Kevin Liew commented on PHOENIX-476: Hi [~tdsilva], support for sequence express

[jira] [Comment Edited] (PHOENIX-3214) Kafka Phoenix Consumer

2017-02-08 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858298#comment-15858298 ] Kevin Liew edited comment on PHOENIX-3214 at 2/8/17 5:4

[jira] [Comment Edited] (PHOENIX-3214) Kafka Phoenix Consumer

2017-02-08 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858298#comment-15858298 ] Kevin Liew edited comment on PHOENIX-3214 at 2/8/17 5:4

[jira] [Commented] (PHOENIX-3214) Kafka Phoenix Consumer

2017-02-08 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858298#comment-15858298 ] Kevin Liew commented on PHOENIX-3214: - [~jmahonin], Hudson can usually be trigg

[jira] [Comment Edited] (PHOENIX-3214) Kafka Phoenix Consumer

2017-02-08 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856348#comment-15856348 ] Kevin Liew edited comment on PHOENIX-3214 at 2/8/17 5:4

[jira] [Comment Edited] (PHOENIX-3214) Kafka Phoenix Consumer

2017-02-07 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856348#comment-15856348 ] Kevin Liew edited comment on PHOENIX-3214 at 2/7/17 9:2

[jira] [Commented] (PHOENIX-3214) Kafka Phoenix Consumer

2017-02-07 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856348#comment-15856348 ] Kevin Liew commented on PHOENIX-3214: - Thanks for the contribution [~kalyanha

[jira] [Updated] (PHOENIX-3413) Ineffective null check in LiteralExpression#newConstant()

2017-02-06 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3413: Attachment: PHOENIX-3413.3.patch Hopefully those issues have been resolve and it passes this time

[jira] [Comment Edited] (PHOENIX-2314) Cannot prepare parameterized statement with a 'like' predicate

2017-02-06 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853594#comment-15853594 ] Kevin Liew edited comment on PHOENIX-2314 at 2/7/17 3:4

[jira] [Resolved] (PHOENIX-3510) Phoenix LIKE operator with bind parameters - Error -1 (00000) : while preparing SQL; Binded parameter in the SELECT clause

2017-02-05 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew resolved PHOENIX-3510. - Resolution: Duplicate Fix Version/s: 4.10.0 > Phoenix LIKE operator with bind paramet

[jira] [Updated] (PHOENIX-2314) Cannot prepare parameterized statement with a 'like' predicate

2017-02-05 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-2314: Attachment: PHOENIX-2314.2.patch Thanks [~jamestaylor]. I attached another patch including the

[jira] [Commented] (PHOENIX-3579) INSERT/UPSERT should allow values less than number of columns in Calcite-Phoenix

2017-01-10 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15815317#comment-15815317 ] Kevin Liew commented on PHOENIX-3579: - Hi [~maryannxue], the test cases did fai

[jira] [Updated] (PHOENIX-3579) INSERT/UPSERT should allow values less than number of columns in Calcite-Phoenix

2017-01-09 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3579: Attachment: PHOENIX-3579.2.patch > INSERT/UPSERT should allow values less than number of colu

[jira] [Comment Edited] (PHOENIX-3579) INSERT/UPSERT should allow values less than number of columns in Calcite-Phoenix

2017-01-09 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15811152#comment-15811152 ] Kevin Liew edited comment on PHOENIX-3579 at 1/9/17 9:2

[jira] [Updated] (PHOENIX-3579) INSERT/UPSERT should allow values less than number of columns in Calcite-Phoenix

2017-01-09 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3579: Attachment: PHOENIX-3579.patch Preliminary patch attached. Some test cases fail due to column

[jira] [Created] (PHOENIX-3579) INSERT/UPSERT should allow values less than number of columns in Calcite-Phoenix

2017-01-09 Thread Kevin Liew (JIRA)
Kevin Liew created PHOENIX-3579: --- Summary: INSERT/UPSERT should allow values less than number of columns in Calcite-Phoenix Key: PHOENIX-3579 URL: https://issues.apache.org/jira/browse/PHOENIX-3579

[jira] [Assigned] (PHOENIX-3562) NPE from BaseTest#deletePriorSchemas() due to missing schema

2017-01-04 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew reassigned PHOENIX-3562: --- Assignee: Kevin Liew > NPE from BaseTest#deletePriorSchemas() due to missing sch

[jira] [Updated] (PHOENIX-3413) Ineffective null check in LiteralExpression#newConstant()

2017-01-03 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3413: Attachment: PHOENIX-3413.2.patch > Ineffective null check in LiteralExpression#newConst

[jira] [Commented] (PHOENIX-3413) Ineffective null check in LiteralExpression#newConstant()

2017-01-03 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797332#comment-15797332 ] Kevin Liew commented on PHOENIX-3413: - If the value is not null, the data-

[jira] [Updated] (PHOENIX-3413) Ineffective null check in LiteralExpression#newConstant()

2017-01-03 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3413: Attachment: PHOENIX-3413.patch > Ineffective null check in LiteralExpression#newConst

[jira] [Commented] (PHOENIX-2314) Cannot prepare parameterized statement with a 'like' predicate

2017-01-03 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797303#comment-15797303 ] Kevin Liew commented on PHOENIX-2314: - [~elserj], this is okay to commit, r

[jira] [Assigned] (PHOENIX-2371) DatabaseMetadata.getColumns() returns bad COLUMN_SIZE for varchar and varbinary columns

2017-01-03 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew reassigned PHOENIX-2371: --- Assignee: Kevin Liew > DatabaseMetadata.getColumns() returns bad COLUMN_SIZE for varc

[jira] [Assigned] (PHOENIX-3413) Ineffective null check in LiteralExpression#newConstant()

2017-01-03 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew reassigned PHOENIX-3413: --- Assignee: Kevin Liew > Ineffective null check in LiteralExpression#newConst

[jira] [Commented] (PHOENIX-1386) ANY function only works with absolute value and doesn't work with other parameters

2016-12-30 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15788224#comment-15788224 ] Kevin Liew commented on PHOENIX-1386: - {quote} James Taylor added a comment

[jira] [Assigned] (PHOENIX-2482) Recognize the ANSI SUBSTRING function

2016-12-23 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew reassigned PHOENIX-2482: --- Assignee: Kevin Liew > Recognize the ANSI SUBSTRING funct

[jira] [Updated] (PHOENIX-3545) Add integration tests for string upper and lower

2016-12-23 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3545: Description: Phoenix 4.5.0 had an issue matching strings against the `lower` function with

[jira] [Updated] (PHOENIX-3545) Add integration tests for string upper and lower

2016-12-23 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3545: Description: Phoenix 4.5.0 had an issue (was: Phoenix 4.5.0 had an issue parsing concatenated

[jira] [Updated] (PHOENIX-2798) Case insensitive column on case sensitive table fails to find column in result set

2016-12-23 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-2798: Attachment: PHOENIX-2798.patch Hi [~jamestaylor] Are you able to provide a unit test to reproduce

[jira] [Updated] (PHOENIX-2798) Case insensitive column on case sensitive table fails to find column in result set

2016-12-23 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-2798: Description: If a table is created as case sensitive, but the columns are case insensitive, then

[jira] [Updated] (PHOENIX-3545) Add integration tests for string upper and lower

2016-12-22 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3545: Attachment: PHOENIX-3545.patch > Add integration tests for string upper and lo

[jira] [Updated] (PHOENIX-3545) Add integration tests for string upper and lower

2016-12-22 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3545: Description: Phoenix 4.5.0 had an issue parsing concatenated strings in a string function. {code

[jira] [Commented] (PHOENIX-2170) WHERE condition with string expression returns incorrect results

2016-12-22 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15771314#comment-15771314 ] Kevin Liew commented on PHOENIX-2170: - Okay, I will resolve this JIRA after fur

[jira] [Created] (PHOENIX-3545) Add integration tests for string upper and lower

2016-12-22 Thread Kevin Liew (JIRA)
Kevin Liew created PHOENIX-3545: --- Summary: Add integration tests for string upper and lower Key: PHOENIX-3545 URL: https://issues.apache.org/jira/browse/PHOENIX-3545 Project: Phoenix Issue

[jira] [Commented] (PHOENIX-2170) WHERE condition with string expression returns incorrect results

2016-12-22 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770796#comment-15770796 ] Kevin Liew commented on PHOENIX-2170: - Yes, the unit tests passed locally. >

[jira] [Comment Edited] (PHOENIX-2170) WHERE condition with string expression returns incorrect results

2016-12-22 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770796#comment-15770796 ] Kevin Liew edited comment on PHOENIX-2170 at 12/22/16 6:5

[jira] [Assigned] (PHOENIX-2798) Case insensitive column on case sensitive table fails to find column in result set

2016-12-22 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew reassigned PHOENIX-2798: --- Assignee: Kevin Liew > Case insensitive column on case sensitive table fails to f

[jira] [Updated] (PHOENIX-2170) WHERE condition with string expression returns incorrect results

2016-12-22 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-2170: Attachment: PHOENIX-2170.patch > WHERE condition with string expression returns incorrect resu

[jira] [Updated] (PHOENIX-2170) WHERE condition with string expression returns incorrect results

2016-12-22 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-2170: Description: Results incorrect for string expression in where clause. {code:sql} create table

[jira] [Assigned] (PHOENIX-2170) WHERE condition with string expression returns incorrect results

2016-12-22 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew reassigned PHOENIX-2170: --- Assignee: Kevin Liew > WHERE condition with string expression returns incorrect resu

[jira] [Updated] (PHOENIX-2314) Cannot prepare parameterized statement with a 'like' predicate

2016-12-19 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-2314: Attachment: PHOENIX-2314.patch Attached patch. I didn't include the queryserver test in

[jira] [Commented] (PHOENIX-3214) Kafka Phoenix Consumer

2016-12-18 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15759801#comment-15759801 ] Kevin Liew commented on PHOENIX-3214: - Can we import and use those macros

[jira] [Commented] (PHOENIX-3214) Kafka Phoenix Consumer

2016-12-18 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15759762#comment-15759762 ] Kevin Liew commented on PHOENIX-3214: - Many of the macros in KafkaConstants

[jira] [Resolved] (PHOENIX-3531) Apply integration tests to the queryserver

2016-12-15 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew resolved PHOENIX-3531. - Resolution: Duplicate > Apply integration tests to the queryser

[jira] [Commented] (PHOENIX-3531) Apply integration tests to the queryserver

2016-12-15 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751855#comment-15751855 ] Kevin Liew commented on PHOENIX-3531: - Hi [~elserj] To catch a bug like PHO

[jira] [Assigned] (PHOENIX-3531) Apply integration tests to the queryserver

2016-12-13 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew reassigned PHOENIX-3531: --- Assignee: Kevin Liew > Apply integration tests to the queryser

[jira] [Updated] (PHOENIX-3531) Apply integration tests to the queryserver

2016-12-13 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3531: Description: We can add queryserver tests that extend the direct tests. ie

[jira] [Created] (PHOENIX-3531) Apply integration tests to the queryserver

2016-12-13 Thread Kevin Liew (JIRA)
Kevin Liew created PHOENIX-3531: --- Summary: Apply integration tests to the queryserver Key: PHOENIX-3531 URL: https://issues.apache.org/jira/browse/PHOENIX-3531 Project: Phoenix Issue Type

[jira] [Commented] (PHOENIX-2314) Cannot prepare parameterized statement with a 'like' predicate

2016-12-12 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743582#comment-15743582 ] Kevin Liew commented on PHOENIX-2314: - The fix is to change {code:java} re

[jira] [Assigned] (PHOENIX-2314) Cannot prepare parameterized statement with a 'like' predicate

2016-12-12 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew reassigned PHOENIX-2314: --- Assignee: Kevin Liew (was: Josh Elser) > Cannot prepare parameterized statement wit

[jira] [Commented] (PHOENIX-3530) Queries with 'like/wildcard %' in the predicate not returning all rows

2016-12-12 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743187#comment-15743187 ] Kevin Liew commented on PHOENIX-3530: - Hi [~dlupinski], I'd deleted my

[jira] [Commented] (PHOENIX-3510) Phoenix LIKE operator with bind parameters - Error -1 (00000) : while preparing SQL; Binded parameter in the SELECT clause

2016-12-12 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742926#comment-15742926 ] Kevin Liew commented on PHOENIX-3510: - Actually, I am able to reproduce this

[jira] [Issue Comment Deleted] (PHOENIX-3530) Queries with 'like/wildcard %' in the predicate not returning all rows

2016-12-12 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3530: Comment: was deleted (was: This may have been fixed in 4.7.0 by PHOENIX-2643. Can you reproduce

[jira] [Assigned] (PHOENIX-3530) Queries with 'like/wildcard %' in the predicate not returning all rows

2016-12-12 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew reassigned PHOENIX-3530: --- Assignee: Kevin Liew > Queries with 'like/wildcard %' in the predicate not

[jira] [Commented] (PHOENIX-3530) Queries with 'like/wildcard %' in the predicate not returning all rows

2016-12-12 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742881#comment-15742881 ] Kevin Liew commented on PHOENIX-3530: - This may have been fixed in 4.7.0 by PHO

[jira] [Updated] (PHOENIX-3530) Queries with 'like/wildcard %' in the predicate not returning all rows

2016-12-12 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3530: Description: Here is the background: This query returns back 18 rows: {code:sql} select

[jira] [Updated] (PHOENIX-3530) Queries with 'like/wildcard %' in the predicate not returning all rows

2016-12-12 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3530: Description: Here is the background: This query returns back 18 rows: {code:sql} select

[jira] [Commented] (PHOENIX-3510) Phoenix LIKE operator with bind parameters - Error -1 (00000) : while preparing SQL; Binded parameter in the SELECT clause

2016-12-12 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742651#comment-15742651 ] Kevin Liew commented on PHOENIX-3510: - I added the following test case for both

[jira] [Commented] (PHOENIX-3479) Modulo support for non integer-types

2016-11-30 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709492#comment-15709492 ] Kevin Liew commented on PHOENIX-3479: - I was thinking that if other datab

[jira] [Updated] (PHOENIX-3510) Phoenix LIKE operator with bind parameters - Error -1 (00000) : while preparing SQL; Binded parameter in the SELECT clause

2016-11-29 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3510: Description: I am using phoenix-4.9.0-HBase-1.2-thin-client.jar. When trying to execute SQL

[jira] [Assigned] (PHOENIX-3510) Phoenix LIKE operator with bind parameters - Error -1 (00000) : while preparing SQL; Binded parameter in the SELECT clause

2016-11-29 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew reassigned PHOENIX-3510: --- Assignee: Kevin Liew > Phoenix LIKE operator with bind parameters - Error -1 (00

[jira] [Updated] (PHOENIX-3479) Modulo support for non integer-types

2016-11-25 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3479: Attachment: PHOENIX-3479.3.patch New patch for review. > Modulo support for non integer-ty

[jira] [Commented] (PHOENIX-3479) Modulo support for non integer-types

2016-11-25 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15696632#comment-15696632 ] Kevin Liew commented on PHOENIX-3479: - Actually, I'm concerned

[jira] [Commented] (PHOENIX-3479) Modulo support for non integer-types

2016-11-25 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15696560#comment-15696560 ] Kevin Liew commented on PHOENIX-3479: - Please review the patch [~jamesta

[jira] [Updated] (PHOENIX-3479) Modulo support for non integer-types

2016-11-25 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3479: Attachment: PHOENIX-3479.2.patch > Modulo support for non integer-ty

[jira] [Commented] (PHOENIX-3479) Modulo support for non integer-types

2016-11-24 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694360#comment-15694360 ] Kevin Liew commented on PHOENIX-3479: - WIP patch. I used `RoundingMode.HAL

[jira] [Updated] (PHOENIX-3479) Modulo support for non integer-types

2016-11-24 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3479: Attachment: PHOENIX-3479.patch > Modulo support for non integer-ty

Re: [ANNOUNCE] New Apache Phoenix committer - Kevin Liew

2016-11-14 Thread Kevin Liew
Thank you James and PMC. I'm excited to see how Apache Phoenix will evolve, and I am grateful for the opportunity to contribute as a committer. On 2016-11-10 11:07 (-0800), James Taylor wrote: > On behalf of the Apache Phoenix PMC, I'm pleased to announce that Kevin > Liew

[jira] [Updated] (PHOENIX-3312) Dividing int constant values should result in decimal

2016-11-12 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-3312: Attachment: PHOENIX-3312.patch I attached a patch with the proposed fix. I used rounding instead

  1   2   3   4   >