[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4

stoty commented on code in PR #105: URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r898788305 ## pom.xml: ## @@ -190,8 +175,8 @@ 1.10 1.3 -2.13.0 -3.4.9 +4.3.0 Review Comment: Right again, fixing it. --

[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4

stoty commented on code in PR #105: URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r898788288 ## pom.xml: ## @@ -147,33 +146,19 @@ - -hbase1.x -hbase2.x - - omid-hbase-shims-${hbase1.artifactId.suffix} - omid-hbase-shims

[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4

stoty commented on code in PR #105: URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875445938 ## pom.xml: ## @@ -612,20 +570,28 @@ hbase-1 - - - - -hbase-2 - -${shims2.a

[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4

stoty commented on code in PR #105: URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875445600 ## pom.xml: ## @@ -147,33 +146,19 @@ - -hbase1.x -hbase2.x - - omid-hbase-shims-${hbase1.artifactId.suffix} - omid-hbase-shims

[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4

stoty commented on code in PR #105: URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875445204 ## pom.xml: ## @@ -147,33 +146,19 @@ - -hbase1.x -hbase2.x - - omid-hbase-shims-${hbase1.artifactId.suffix} - omid-hbase-shims

[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4

stoty commented on code in PR #105: URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875444085 ## pom.xml: ## @@ -147,33 +146,19 @@ - -hbase1.x -hbase2.x - - omid-hbase-shims-${hbase1.artifactId.suffix} - omid-hbase-shims

[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4

stoty commented on code in PR #105: URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875444085 ## pom.xml: ## @@ -147,33 +146,19 @@ - -hbase1.x -hbase2.x - - omid-hbase-shims-${hbase1.artifactId.suffix} - omid-hbase-shims

[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4

stoty commented on code in PR #105: URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875443116 ## hbase-client/src/test/java/org/apache/omid/transaction/TestCellUtils.java: ## @@ -137,7 +136,7 @@ public void testCorrectMapingOfCellsToShadowCells() throws IOExcep

[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4

stoty commented on code in PR #105: URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875439934 ## pom.xml: ## @@ -612,20 +570,28 @@ hbase-1 - - - - -hbase-2 - -${shims2.a

[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4

stoty commented on code in PR #105: URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875438343 ## pom.xml: ## @@ -147,33 +146,19 @@ - -hbase1.x -hbase2.x - - omid-hbase-shims-${hbase1.artifactId.suffix} - omid-hbase-shims