Github user 7shurik closed the pull request at:
https://github.com/apache/phoenix/pull/68
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
GitHub user 7shurik reopened a pull request:
https://github.com/apache/phoenix/pull/68
Phoenix 1759
This is a fix for https://issues.apache.org/jira/browse/PHOENIX-1759.
There's a set of unit tests as well as an integration test.
Main code change is adding a PhoenixArray.to
Github user 7shurik commented on the pull request:
https://github.com/apache/phoenix/pull/68#issuecomment-96093375
I'm fixing the Apache license header in
PrimitiveIntPhoenixArrayToStringTest.java.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user 7shurik commented on the pull request:
https://github.com/apache/phoenix/pull/68#issuecomment-93865916
@samarthjain @JamesRTaylor are you still reviewing? I've uploaded the
version with suggested changes, including a single implementation of
PhoenixArray.toString().
Se
Github user samarthjain commented on the pull request:
https://github.com/apache/phoenix/pull/68#issuecomment-93872039
+1, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user 7shurik commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/68#discussion_r28532568
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PhoenixArray.java ---
@@ -561,6 +666,23 @@ public int estimateByteSize(int pos) {
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/68#discussion_r28529952
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PhoenixArray.java ---
@@ -561,6 +666,23 @@ public int estimateByteSize(int pos) {
Github user 7shurik commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/68#discussion_r28529111
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PhoenixArray.java ---
@@ -561,6 +666,23 @@ public int estimateByteSize(int pos) {
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/68#discussion_r28526475
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PhoenixArray.java ---
@@ -561,6 +666,23 @@ public int estimateByteSize(int pos) {
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/68#discussion_r28526230
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PhoenixArray.java ---
@@ -561,6 +666,23 @@ public int estimateByteSize(int pos) {
Github user 7shurik commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/68#discussion_r28524479
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java ---
@@ -1098,8 +1098,10 @@ public String toStringLiteral(byte[] b, int off
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/68#discussion_r28524298
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java ---
@@ -1098,8 +1098,10 @@ public String toStringLiteral(byte[] b, int
GitHub user 7shurik opened a pull request:
https://github.com/apache/phoenix/pull/68
Phoenix 1759
This is a fix for https://issues.apache.org/jira/browse/PHOENIX-1759.
There's a set of unit tests as well as an integration test.
Main code change is adding a PhoenixArray.toSt
13 matches
Mail list logo
