Github user prakul closed the pull request at:
https://github.com/apache/phoenix/pull/189
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74842947
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexExpressionIT.java
---
@@ -10,10 +10,7 @@
package org.apache.phoenix.end2en
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74842182
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SubqueryUsingSortMergeJoinIT.java
---
@@ -66,16 +66,16 @@
@RunWith(Parameterize
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74841351
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SkipScanAfterManualSplitIT.java
---
@@ -43,7 +43,7 @@
import com.google.common.collec
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74808858
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexMetadataIT.java
---
@@ -482,20 +482,22 @@ public void testBinaryNonnullableInde
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74678543
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -23,6 +23,7 @@
import static
org.apache.phoenix.mo
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74652145
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/LocalIndexIT.java ---
@@ -76,24 +76,18 @@
import com.google.common.collect.Maps;
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74651889
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexMetadataIT.java
---
@@ -354,27 +355,29 @@ public void testAlterIndexWithLowerCa
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74651475
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexExpressionIT.java
---
@@ -515,22 +531,27 @@ public void testSelectDistinctMutab
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74651437
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexExpressionIT.java
---
@@ -461,14 +472,19 @@ public void testGroupByCountMutable
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74651379
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexExpressionIT.java
---
@@ -307,16 +309,21 @@ public void
testDeleteIndexedExpre
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74651407
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexExpressionIT.java
---
@@ -380,16 +387,20 @@ public void testDeleteCoveredColMut
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74650871
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/DropMetadataIT.java
---
@@ -84,14 +77,17 @@ public static void doSetup() throws Exce
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74637772
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/UpsertBigValuesIT.java ---
@@ -62,7 +62,7 @@ public void testIntegerPK() throws Exception {
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74636561
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/TenantIdTypeIT.java ---
@@ -74,7 +74,8 @@ public TenantIdTypeIT(String dataType, String ten
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74631717
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinMoreIT.java ---
@@ -39,10 +39,10 @@
import com.google.common.collec
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74523807
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SkipScanQueryIT.java ---
@@ -246,15 +248,15 @@ public void testVarCharXIntInQuery() throws
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74523759
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SkipScanQueryIT.java ---
@@ -111,10 +113,10 @@ private void initSelectAfterUpsertTable(Conn
Github user prakul commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74483839
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/HashJoinMoreIT.java ---
@@ -43,7 +43,7 @@
import com.google.common.collect.Maps;
Github user prakul commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74357363
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseQueryIT.java ---
@@ -90,7 +90,8 @@ public BaseQueryIT(String indexDDL) {
@Before
Github user prakul commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74357264
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseHBaseManagedTimeTableReuseIT.java
---
@@ -47,6 +48,10 @@
@NotThreadSafe
@Category
Github user prakul commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74356832
--- Diff: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
---
@@ -1052,16 +1057,20 @@ private static void deletePriorSequences(long ts,
Con
Github user prakul commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74356585
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/AppendOnlySchemaIT.java ---
@@ -274,36 +285,15 @@ public void testTableAddColumnsDifferentClient
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74335513
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SpooledTmpFileDeleteIT.java
---
@@ -38,11 +38,12 @@
-public class Sp
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74335011
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/RowValueConstructorIT.java
---
@@ -65,7 +65,7 @@
public void testRowValueConstruc
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74313800
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/ReverseScanIT.java ---
@@ -52,11 +52,11 @@
import com.google.common.collect.Maps;
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74313609
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/ReverseScanIT.java ---
@@ -52,11 +52,11 @@
import com.google.common.collect.Maps;
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74312995
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/RegexpSubstrFunctionIT.java
---
@@ -33,13 +33,15 @@
import org.junit.Test;
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74312941
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/RegexpReplaceFunctionIT.java
---
@@ -33,13 +33,15 @@
import org.junit.Test;
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74312842
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryIT.java
---
@@ -148,7 +148,7 @@ public void testToDateOnString() throws Exception { //
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74312676
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseQueryIT.java ---
@@ -61,7 +61,7 @@
protected static final String tenantId = ge
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74312374
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java
---
@@ -1066,7 +1065,7 @@ public void testAddPKColumn() throw
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74312396
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java
---
@@ -1106,7 +1105,7 @@ public void testDropKVColumn() thro
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74312230
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/PhoenixRuntimeIT.java ---
@@ -95,53 +96,62 @@ private static Filter getUserTableAndViewsFil
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74311348
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/LnLogFunctionEnd2EndIT.java
---
@@ -33,10 +33,12 @@
/**
* End to end tests for
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74310790
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/HashJoinMoreIT.java ---
@@ -43,7 +43,7 @@
import com.google.common.collect.Maps;
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74310422
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/ExtendedQueryExecIT.java ---
@@ -51,7 +51,7 @@ public void testToDateFunctionBind() throws
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74310182
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/ExpFunctionEnd2EndIT.java
---
@@ -34,21 +34,26 @@
/**
* End to end tests for {@
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74309672
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/DynamicColumnIT.java ---
@@ -59,16 +59,18 @@
*/
-public class Dynamic
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74307945
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/DateTimeIT.java ---
@@ -18,20 +18,7 @@
package org.apache.phoenix.end2end;
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74308894
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/DerivedTableIT.java ---
@@ -72,7 +72,7 @@ public DerivedTableIT(String[] indexDDL, String[]
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74307236
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/CSVCommonsLoaderIT.java ---
@@ -45,15 +45,15 @@
import org.apache.phoenix.util.Phoenix
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74308491
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/DateTimeIT.java ---
@@ -57,12 +44,13 @@
import org.junit.Test;
-public
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74306317
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseQueryIT.java ---
@@ -61,7 +61,7 @@
protected static final String tenantId = ge
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74306178
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseQueryIT.java ---
@@ -90,7 +90,8 @@ public BaseQueryIT(String indexDDL) {
@Befo
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74305946
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseHBaseManagedTimeTableReuseIT.java
---
@@ -47,6 +48,10 @@
@NotThreadSafe
@Cat
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74304816
--- Diff: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
---
@@ -1052,16 +1057,20 @@ private static void deletePriorSequences(long ts,
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74304218
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/AppendOnlySchemaIT.java ---
@@ -274,36 +285,15 @@ public void testTableAddColumnsDifferentC
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r73924877
--- Diff: pom.xml ---
@@ -226,6 +226,7 @@
maven-failsafe-plugin
${maven-failsafe-plugin.version}
+
-
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r73924704
--- Diff: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
---
@@ -2063,5 +2080,35 @@ protected static void
populateMultiCFTestTable(St
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r73924614
--- Diff: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
---
@@ -2063,5 +2080,35 @@ protected static void
populateMultiCFTestTable(St
GitHub user prakul opened a pull request:
https://github.com/apache/phoenix/pull/189
PHOENIX-3036 Modify phoenix IT tests to extend BaseHBaseManagedTimeTâ¦
â¦ableReuseIT
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prakul/ph
52 matches
Mail list logo
