[jira] [Commented] (PHOENIX-3298) Create Table: Single column primary key may not be null

2016-10-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553543#comment-15553543 ] ASF GitHub Bot commented on PHOENIX-3298: - Github user lomoree closed the pull request at:

[jira] [Commented] (PHOENIX-3298) Create Table: Single column primary key may not be null

2016-10-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553542#comment-15553542 ] ASF GitHub Bot commented on PHOENIX-3298: - Github user lomoree commented on a diff in the pull

[jira] [Commented] (PHOENIX-3298) Create Table: Single column primary key may not be null

2016-10-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553180#comment-15553180 ] ASF GitHub Bot commented on PHOENIX-3298: - Github user maryannxue commented on a diff in the

[jira] [Commented] (PHOENIX-3298) Create Table: Single column primary key may not be null

2016-10-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552825#comment-15552825 ] ASF GitHub Bot commented on PHOENIX-3298: - Github user maryannxue commented on the issue:

[jira] [Commented] (PHOENIX-3298) Create Table: Single column primary key may not be null

2016-10-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552645#comment-15552645 ] ASF GitHub Bot commented on PHOENIX-3298: - Github user JamesRTaylor commented on the issue:

[jira] [Commented] (PHOENIX-3298) Create Table: Single column primary key may not be null

2016-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15543427#comment-15543427 ] ASF GitHub Bot commented on PHOENIX-3298: - GitHub user lomoree opened a pull request:

[jira] [Commented] (PHOENIX-3298) Create Table: Single column primary key may not be null

2016-09-29 Thread Eric Lomore (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533846#comment-15533846 ] Eric Lomore commented on PHOENIX-3298: -- Ah! I didn't realize they were non-primitive on the Phoenix

[jira] [Commented] (PHOENIX-3298) Create Table: Single column primary key may not be null

2016-09-29 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533579#comment-15533579 ] James Taylor commented on PHOENIX-3298: --- The ColumnDef object in Phoenix declares isNull as

[jira] [Commented] (PHOENIX-3298) Create Table: Single column primary key may not be null

2016-09-29 Thread Eric Lomore (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533521#comment-15533521 ] Eric Lomore commented on PHOENIX-3298: -- Quick summary of what I was talking about: During grammar

[jira] [Commented] (PHOENIX-3298) Create Table: Single column primary key may not be null

2016-09-26 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523354#comment-15523354 ] James Taylor commented on PHOENIX-3298: --- Yes, we'd still want to throw an exception in that case.

[jira] [Commented] (PHOENIX-3298) Create Table: Single column primary key may not be null

2016-09-26 Thread Eric Lomore (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523313#comment-15523313 ] Eric Lomore commented on PHOENIX-3298: -- Before I finish up on this, I wanted to find out the

[jira] [Commented] (PHOENIX-3298) Create Table: Single column primary key may not be null

2016-09-20 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505747#comment-15505747 ] James Taylor commented on PHOENIX-3298: --- Phoenix assumes that a single column PK is not nullable