Thanks Nick. I will change it.
Thanks.
Rajeshbabu.
On Sun, Apr 26, 2015 at 11:57 PM, Nick Dimiduk wrote:
> Sure Rajesh, I have no problem with that, so long as Apache doesn't raise
> alarm. This is simple enough to do by editing the runTests method [0]. You
> want to give it a go? Let me know
Sure Rajesh, I have no problem with that, so long as Apache doesn't raise
alarm. This is simple enough to do by editing the runTests method [0]. You
want to give it a go? Let me know if you have any troubles.
[0]: https://github.com/apache/phoenix/blob/master/dev/test-patch.sh#L833
On Sat, Apr 25
Great work Nick.
Just one thing now it's running only unit tests it seems. What about
integration tests? It would be better to make the scripts run integration
tests as well.
Thanks,
Rajeshbabu.
On Fri, Apr 24, 2015 at 9:18 AM, Nick Dimiduk wrote:
> On Thu, Apr 23, 2015 at 7:19 PM, James Taylo
On Thu, Apr 23, 2015 at 7:19 PM, James Taylor
wrote:
> Excellent, Nick. For us non HBasers, what's the recommended workflow?
>
Generate a patch from your sandbox. Committers will be committing a local
patch before pushing upstream, so you'll have the commit there. You can
generate a patch with `
Excellent, Nick. For us non HBasers, what's the recommended workflow?
Only check-in if our BuildBot passes?
On Thu, Apr 23, 2015 at 4:37 PM, Enis Söztutar wrote:
> Great work! You the man.
>
> Enis
>
> On Thu, Apr 23, 2015 at 4:35 PM, Mujtaba Chohan wrote:
>
>> That's awesome Nick!
>>
>> On Thu,
Great work! You the man.
Enis
On Thu, Apr 23, 2015 at 4:35 PM, Mujtaba Chohan wrote:
> That's awesome Nick!
>
> On Thu, Apr 23, 2015 at 4:30 PM, Eli Levine wrote:
>
> > Great work, Nick! Thanks for doing this.
> >
> > Eli
> >
> > On Thu, Apr 23, 2015 at 4:01 PM, Nick Dimiduk
> wrote:
> >
> >
That's awesome Nick!
On Thu, Apr 23, 2015 at 4:30 PM, Eli Levine wrote:
> Great work, Nick! Thanks for doing this.
>
> Eli
>
> On Thu, Apr 23, 2015 at 4:01 PM, Nick Dimiduk wrote:
>
> > Devs --
> >
> > We now have a pre-commit BuildBot [0]! Our pedantic build-checking robot
> > servant passed i
Great work, Nick! Thanks for doing this.
Eli
On Thu, Apr 23, 2015 at 4:01 PM, Nick Dimiduk wrote:
> Devs --
>
> We now have a pre-commit BuildBot [0]! Our pedantic build-checking robot
> servant passed its first judgement [1] this afternoon. It is a clone [2] of
> the buildbot from HBase, so it
Devs --
We now have a pre-commit BuildBot [0]! Our pedantic build-checking robot
servant passed its first judgement [1] this afternoon. It is a clone [2] of
the buildbot from HBase, so it's somber tone should be familiar to many of
you. Same rules apply -- attach your patch, hit "Submit Patch" and
