[jira] [Commented] (PIG-4920) Fail to use Javascript UDF in spark yarn client mode

2016-10-25 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15607235#comment-15607235 ] Mohit Sabharwal commented on PIG-4920: -- LGTM, +1 (non-binding) > Fail

[jira] [Updated] (PIG-4553) Implement secondary sort using one shuffle

2016-07-15 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohit Sabharwal updated PIG-4553: - Summary: Implement secondary sort using one shuffle (was: Implement secondary sort using 1 shuffle

[jira] [Commented] (PIG-4553) Implement secondary sort using 1 shuffle not twice

2016-07-15 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380386#comment-15380386 ] Mohit Sabharwal commented on PIG-4553: -- LGTM, +1 (non-binding) > Implement se

[jira] [Commented] (PIG-4941) TestRank3#testRankWithSplitInMap hangs after upgrade to spark 1.6.1

2016-07-08 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368050#comment-15368050 ] Mohit Sabharwal commented on PIG-4941: -- Following seems like the relevant th

[jira] [Commented] (PIG-4919) Upgrade spark.version to 1.6.1

2016-06-13 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328855#comment-15328855 ] Mohit Sabharwal commented on PIG-4919: -- +1 (non-binding) > Upgrade spark.ver

[jira] [Commented] (PIG-4898) Fix unit test failure after PIG-4771's patch was checked in

2016-05-23 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297587#comment-15297587 ] Mohit Sabharwal commented on PIG-4898: -- +1 (non-binding) > Fix unit test

[jira] [Commented] (PIG-4771) Implement FR Join for spark engine

2016-05-16 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286004#comment-15286004 ] Mohit Sabharwal commented on PIG-4771: -- +1 (non-binding) > Implement FR J

[jira] [Commented] (PIG-4886) Add PigSplit#getLocationInfo to fix the NPE found in log in spark mode

2016-05-16 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286003#comment-15286003 ] Mohit Sabharwal commented on PIG-4886: -- Thanks, [~kellyzly] - left couple of comm

[jira] [Commented] (PIG-4771) Implement FR Join for spark engine

2016-05-16 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285953#comment-15285953 ] Mohit Sabharwal commented on PIG-4771: -- Thanks, [~kellyzly] Left couple comments o

[jira] [Commented] (PIG-4876) OutputConsumeIterator can't handle the last buffered tuples for some Operators

2016-05-16 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285832#comment-15285832 ] Mohit Sabharwal commented on PIG-4876: -- Thanks, [~kexianda], [~kellyzly], let&

[jira] [Commented] (PIG-4876) OutputConsumeIterator can't handle the last buffered tuples for some Operators

2016-04-28 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263299#comment-15263299 ] Mohit Sabharwal commented on PIG-4876: -- It's not clear to me why adding beg

[jira] [Updated] (PIG-4854) Merge spark branch to trunk

2016-04-26 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohit Sabharwal updated PIG-4854: - Issue Type: Sub-task (was: Task) Parent: PIG-4059 > Merge spark branch to tr

[jira] [Commented] (PIG-4876) OutputConsumeIterator can't handle the last buffered tuples for some Operators

2016-04-22 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253898#comment-15253898 ] Mohit Sabharwal commented on PIG-4876: -- Another question: Does it make sense to

[jira] [Commented] (PIG-4876) OutputConsumeIterator can't handle the last buffered tuples for some Operators

2016-04-21 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253377#comment-15253377 ] Mohit Sabharwal commented on PIG-4876: -- Thanks for the explanation [~kexianda]. Le

[jira] [Commented] (PIG-4859) Need upgrade snappy-java.version to 1.1.1.3

2016-04-04 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225017#comment-15225017 ] Mohit Sabharwal commented on PIG-4859: -- +1 (non-binding) > Need upgrade

[jira] [Commented] (PIG-4857) Last record is missing in STREAM operator

2016-03-30 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218544#comment-15218544 ] Mohit Sabharwal commented on PIG-4857: -- [~kexianda], since the StreamOperator

[jira] [Commented] (PIG-4837) TestNativeMapReduce test fix

2016-03-28 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215345#comment-15215345 ] Mohit Sabharwal commented on PIG-4837: -- +1 (non-binding) for PIG-4837_3.p

[jira] [Commented] (PIG-4842) Collected group doesn't work in some cases

2016-03-28 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215327#comment-15215327 ] Mohit Sabharwal commented on PIG-4842: -- +1 (non-binding) > Collected group

[jira] [Commented] (PIG-4837) TestNativeMapReduce test fix

2016-03-28 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215102#comment-15215102 ] Mohit Sabharwal commented on PIG-4837: -- I agree with [~pallavi.rao]. Running MR jo

[jira] [Commented] (PIG-4836) Fix TestEvalPipeline test failure

2016-03-10 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189445#comment-15189445 ] Mohit Sabharwal commented on PIG-4836: -- [~xuefuz], please commit when you get g

[jira] [Commented] (PIG-4836) Fix TestEvalPipeline test failure

2016-03-10 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189224#comment-15189224 ] Mohit Sabharwal commented on PIG-4836: -- +1 Thanks, [~pallavi.rao]. &

[jira] [Commented] (PIG-4835) Fix TestPigRunner test failure

2016-03-09 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15188578#comment-15188578 ] Mohit Sabharwal commented on PIG-4835: -- yes, sorry, commented on wrong jira :) &

[jira] [Commented] (PIG-4836) Fix TestEvalPipeline test failure

2016-03-09 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15188577#comment-15188577 ] Mohit Sabharwal commented on PIG-4836: -- [~pallavi.rao], quick question: looks

[jira] [Commented] (PIG-4835) Fix TestPigRunner test failure

2016-03-09 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15188562#comment-15188562 ] Mohit Sabharwal commented on PIG-4835: -- [~pallavi.rao], quick question: looks

[jira] [Commented] (PIG-4827) Fix TestSample UT failure

2016-03-08 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185290#comment-15185290 ] Mohit Sabharwal commented on PIG-4827: -- +1 Thanks, [~pallavi.rao]. > Fix Tes

[jira] [Commented] (PIG-4825) Fix TestMultiQuery failure

2016-03-07 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184365#comment-15184365 ] Mohit Sabharwal commented on PIG-4825: -- Agreed. We saw this pattern of fail

[jira] [Commented] (PIG-4827) Fix TestSample UT failure

2016-03-07 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15183327#comment-15183327 ] Mohit Sabharwal commented on PIG-4827: -- Needs minor error message update. Other

[jira] [Commented] (PIG-4788) the value BytesRead metric info always returns 0 even the length of input file is not 0 in spark engine

2016-02-29 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173194#comment-15173194 ] Mohit Sabharwal commented on PIG-4788: -- Custom LoadFunc for example can be writte

[jira] [Commented] (PIG-4788) the value BytesRead metric info always returns 0 even the length of input file is not 0 in spark engine

2016-02-29 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173189#comment-15173189 ] Mohit Sabharwal commented on PIG-4788: -- Ah, of course, sorry - FileSplit can&

[jira] [Commented] (PIG-4788) the value BytesRead metric info always returns 0 even the length of input file is not 0 in spark engine

2016-02-29 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173164#comment-15173164 ] Mohit Sabharwal commented on PIG-4788: -- [~kellyzly], if you change {{PigSplit}

[jira] [Commented] (PIG-4601) Implement Merge CoGroup for Spark engine

2016-02-16 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149022#comment-15149022 ] Mohit Sabharwal commented on PIG-4601: -- +1 (non-binding), sorry about the d

[jira] [Commented] (PIG-4709) Improve performance of GROUPBY operator on Spark

2016-01-15 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102914#comment-15102914 ] Mohit Sabharwal commented on PIG-4709: -- Thanks, [~pallavi.rao]. Sorry about the d

Re: Review Request 40743: PIG-4709 Improve performance of GROUPBY operator on Spark

2016-01-15 Thread Mohit Sabharwal
if this needs to be earlier. Probably safer to keep this right after the combiner optimization. src/org/apache/pig/backend/hadoop/executionengine/spark/converter/GlobalRearrangeConverter.java <https://reviews.apache.org/r/40743/#comment171099> any particular reason you're moving

[jira] [Commented] (PIG-4601) Implement Merge CoGroup for Spark engine

2016-01-15 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102751#comment-15102751 ] Mohit Sabharwal commented on PIG-4601: -- Thanks, [~kellyzly]! Have couple of quest

[jira] [Commented] (PIG-4611) Fix remaining unit test failures about "TestHBaseStorage" in spark mode

2016-01-14 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15101131#comment-15101131 ] Mohit Sabharwal commented on PIG-4611: -- +1 (non-binding) > Fix remaining un

[jira] [Commented] (PIG-4675) Operators with multiple predecessors fail under multiquery optimization

2015-12-17 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063531#comment-15063531 ] Mohit Sabharwal commented on PIG-4675: -- +1(non-binding) > Operators with m

[jira] [Commented] (PIG-4754) Fix UT failures in TestScriptLanguage

2015-12-17 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063427#comment-15063427 ] Mohit Sabharwal commented on PIG-4754: -- +1(non-binding). LGTM. could you please a

[jira] [Commented] (PIG-4675) Operators with multiple predecessors fail under multiquery optimization

2015-12-17 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063353#comment-15063353 ] Mohit Sabharwal commented on PIG-4675: -- Thanks, [~kellyzly]. I had one minor com

[jira] [Commented] (PIG-4293) Enable unit test "TestNativeMapReduce" for spark

2015-12-17 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063344#comment-15063344 ] Mohit Sabharwal commented on PIG-4293: -- +1 (non-binding) > Enable un

[jira] [Updated] (PIG-4675) Operators with multiple predecessors fail under multiquery optimization

2015-12-04 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohit Sabharwal updated PIG-4675: - Summary: Operators with multiple predecessors fail under multiquery optimization (was: Operators

[jira] [Updated] (PIG-4675) Operators with multiple predecessors fail under

2015-12-04 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohit Sabharwal updated PIG-4675: - Summary: Operators with multiple predecessors fail under (was: FR+Limit case fails when enable

[jira] [Commented] (PIG-4675) FR+Limit case fails when enable MultiQuery because the predecessor information is wrongly calculated in current code.

2015-12-03 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15039755#comment-15039755 ] Mohit Sabharwal commented on PIG-4675: -- Thanks, [~kellyzly], this looks like a pr

[jira] [Commented] (PIG-4621) Enable Illustrate in spark

2015-12-03 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15039706#comment-15039706 ] Mohit Sabharwal commented on PIG-4621: -- Thanks, left some comments on RB.

Re: Review Request 40692: PIG-4621: Enable Illustrate in spark

2015-12-03 Thread Mohit Sabharwal
s 75 - 76) <https://reviews.apache.org/r/40692/#comment168393> remove extra lines - Mohit Sabharwal On Nov. 25, 2015, 4:59 a.m., Zulfi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

[jira] [Commented] (PIG-4293) Enable unit test "TestNativeMapReduce" for spark

2015-12-03 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15039693#comment-15039693 ] Mohit Sabharwal commented on PIG-4293: -- Thanks, [~kellyzly]! Left couple of comm

[jira] [Commented] (PIG-4709) Improve performance of GROUPBY operator on Spark

2015-11-30 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032245#comment-15032245 ] Mohit Sabharwal commented on PIG-4709: -- Thanks, [~pallavi.rao], will take a

[jira] [Commented] (PIG-4634) Fix records count issues in output statistics

2015-10-30 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14982908#comment-14982908 ] Mohit Sabharwal commented on PIG-4634: -- Thanks, [~kexianda]! +1 (non-binding) &

[jira] [Commented] (PIG-4634) Fix records count issues in output statistics

2015-10-26 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975606#comment-14975606 ] Mohit Sabharwal commented on PIG-4634: -- Thanks, [~xianda]. I had couple of

[jira] [Commented] (PIG-4634) Fix records count issues in output statistics

2015-10-05 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944450#comment-14944450 ] Mohit Sabharwal commented on PIG-4634: -- [~xianda], RB is returning this error wh

[jira] [Commented] (PIG-4655) Support InputStats in spark mode

2015-09-04 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731809#comment-14731809 ] Mohit Sabharwal commented on PIG-4655: -- That's right, depends on PIG-4634

[jira] [Commented] (PIG-4655) Support InputStats in spark mode

2015-09-04 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731605#comment-14731605 ] Mohit Sabharwal commented on PIG-4655: -- +1 (non-binding) > Support InputS

[jira] [Commented] (PIG-4634) Fix records count issues in output statistics

2015-09-04 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731603#comment-14731603 ] Mohit Sabharwal commented on PIG-4634: -- Thanks, [~kexianda], left some comments o

[jira] [Commented] (PIG-4655) Support InputStats in spark mode

2015-08-28 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720869#comment-14720869 ] Mohit Sabharwal commented on PIG-4655: -- Please move this to the top of the class

[jira] [Commented] (PIG-4655) Support InputStats in spark mode

2015-08-28 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720861#comment-14720861 ] Mohit Sabharwal commented on PIG-4655: -- [~kexianda] could you please create RB req

[jira] [Commented] (PIG-4634) Fix records count issues in output statistics

2015-08-28 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720863#comment-14720863 ] Mohit Sabharwal commented on PIG-4634: -- [~kexianda] could you create a RB request

[jira] [Commented] (PIG-4661) Fix UT failures in TestPigServerLocal

2015-08-28 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720688#comment-14720688 ] Mohit Sabharwal commented on PIG-4661: -- +1 (non-binding) Thanks, [~kexianda] &

[jira] [Commented] (PIG-4659) Fix unit test failures in org.apache.pig.test.TestScriptLanguageJavaScript

2015-08-18 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702402#comment-14702402 ] Mohit Sabharwal commented on PIG-4659: -- Thanks, [~kexianda]. +1 (non-binding) &

[jira] [Commented] (PIG-4645) Support hadoop-like Counter using spark accumulator

2015-08-10 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681119#comment-14681119 ] Mohit Sabharwal commented on PIG-4645: -- Thanks, [~kexianda]. LGTM. +1 (non-bin

[jira] [Commented] (PIG-4645) Support hadoop-like Counter using spark accumulator

2015-08-07 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662738#comment-14662738 ] Mohit Sabharwal commented on PIG-4645: -- Thanks, [~kexianda], I was wondering i

[jira] [Commented] (PIG-4633) Update hadoop version to enable Spark output statistics

2015-07-13 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625712#comment-14625712 ] Mohit Sabharwal commented on PIG-4633: -- Thanks, [~kexianda], +1 (non-binding). C

[jira] [Commented] (PIG-4594) Enable "TestMultiQuery" in spark mode

2015-07-13 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625707#comment-14625707 ] Mohit Sabharwal commented on PIG-4594: -- The general approach here seems reasonabl

[jira] [Commented] (PIG-4633) Update hadoop version to enable Spark output statistics

2015-07-13 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625669#comment-14625669 ] Mohit Sabharwal commented on PIG-4633: -- Thanks, [~kexianda]. Just curious - how

[jira] [Updated] (PIG-4633) Update hadoop version to enable Spark output statistics

2015-07-13 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohit Sabharwal updated PIG-4633: - Summary: Update hadoop version to enable Spark output statistics (was: fix libaray version to

[jira] [Commented] (PIG-4611) Fix remaining unit test failures about "TestHBaseStorage"

2015-07-06 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616247#comment-14616247 ] Mohit Sabharwal commented on PIG-4611: -- Thanks, [~kellyzly]. One more sugges

[jira] [Commented] (PIG-4611) Fix remaining unit test failures about "TestHBaseStorage"

2015-07-06 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615915#comment-14615915 ] Mohit Sabharwal commented on PIG-4611: -- Thanks for the explanation and addressing

[jira] [Commented] (PIG-4622) Skip TestCubeOperator.testIllustrate and TestMultiQueryLocal.testMultiQueryWithIllustrate

2015-07-06 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615874#comment-14615874 ] Mohit Sabharwal commented on PIG-4622: -- Thanks, [~kellyzly]. +1 (non-binding) &g

[jira] [Commented] (PIG-4619) Cleanup: change the indent size of some files of pig on spark project from 2 to 4 space

2015-07-03 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613115#comment-14613115 ] Mohit Sabharwal commented on PIG-4619: -- Thanks, [~kellyzly] +1 (non-bin

[jira] [Commented] (PIG-4613) Fix unit test failures about TestAssert

2015-07-03 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613113#comment-14613113 ] Mohit Sabharwal commented on PIG-4613: -- Thanks, [~kexianda], [~kellyzly], LGTM

[jira] [Commented] (PIG-4613) Fix unit test failures about TestAssert

2015-07-01 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611428#comment-14611428 ] Mohit Sabharwal commented on PIG-4613: -- My vote is for 2) since Spark engine g

[jira] [Commented] (PIG-4594) Enable "TestMultiQuery" in spark mode

2015-07-01 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611416#comment-14611416 ] Mohit Sabharwal commented on PIG-4594: -- Thanks, [~kellyzly]. Could you give

[jira] [Commented] (PIG-4613) Fix unit test failures about TestAssert

2015-07-01 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611392#comment-14611392 ] Mohit Sabharwal commented on PIG-4613: -- Thanks, [~kexianda]. LGTM. Just to be

[jira] [Commented] (PIG-4611) Fix remaining unit test failures about "TestHBaseStorage"

2015-07-01 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611367#comment-14611367 ] Mohit Sabharwal commented on PIG-4611: -- Thanks, [~kellyzly], this looks li

[jira] [Commented] (PIG-4614) Enable "TestLocationInPhysicalPlan" in spark mode

2015-06-30 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609567#comment-14609567 ] Mohit Sabharwal commented on PIG-4614: -- Thanks, [~kellyzly]! +1 (non-bin

[jira] [Updated] (PIG-4059) Pig on Spark

2015-06-30 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohit Sabharwal updated PIG-4059: - Attachment: Pig-on-Spark-Scope.pdf > Pig on Spark > > > K

[jira] [Commented] (PIG-4614) Enable "TestLocationInPhysicalPlan" in spark mode

2015-06-29 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606955#comment-14606955 ] Mohit Sabharwal commented on PIG-4614: -- Thanks, [~kellyzly], I had a questio

[jira] [Updated] (PIG-4614) Enable "TestLocationInPhysicalPlan" in spark mode

2015-06-29 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohit Sabharwal updated PIG-4614: - Description: in https://builds.apache.org/job/Pig-spark/228/#showFailuresLink, it shows following

[jira] [Commented] (PIG-4615) Fix null keys join in SkewedJoin in spark mode

2015-06-29 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606893#comment-14606893 ] Mohit Sabharwal commented on PIG-4615: -- Thanks, [~kellyzly]! LGTM. +1 (non-bin

[jira] [Commented] (PIG-4607) Enable "TestRank1","TestRank3" unit tests in spark mode

2015-06-29 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606887#comment-14606887 ] Mohit Sabharwal commented on PIG-4607: -- Thanks, [~kexianda]! +1 (non-bin

[jira] [Commented] (PIG-4594) Enable "TestMultiQuery" in spark mode

2015-06-27 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14604546#comment-14604546 ] Mohit Sabharwal commented on PIG-4594: -- Thanks, [~kellyzly]! In case 3 a

[jira] [Commented] (PIG-4607) Enable "TestRank1","TestRank3" unit tests in spark mode

2015-06-26 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14603803#comment-14603803 ] Mohit Sabharwal commented on PIG-4607: -- Thanks for the explanation, [~kexianda]!

[jira] [Commented] (PIG-4610) Enable "TestOrcStorageā€œ unit test in spark mode

2015-06-22 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597045#comment-14597045 ] Mohit Sabharwal commented on PIG-4610: -- +1 (non-binding) > Enable "Te

[jira] [Commented] (PIG-4607) Enable "TestRank1","TestRank3" unit tests in spark mode

2015-06-19 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14594189#comment-14594189 ] Mohit Sabharwal commented on PIG-4607: -- Looks like TestRank2 was not failing

[jira] [Commented] (PIG-4607) Enable "TestRank1","TestRank3" unit tests in spark mode

2015-06-19 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593762#comment-14593762 ] Mohit Sabharwal commented on PIG-4607: -- Thanks, [~kexianda] I discovered t

[jira] [Commented] (PIG-4606) Enable "TestDefaultDateTimeZone" unit tests in spark mode

2015-06-17 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591201#comment-14591201 ] Mohit Sabharwal commented on PIG-4606: -- Thank you so much, [~kellyzly]! +1

[jira] [Commented] (PIG-4606) Enable "TestDefaultDateTimeZone" unit tests in spark mode

2015-06-17 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590386#comment-14590386 ] Mohit Sabharwal commented on PIG-4606: -- Thanks, [~kellyzly], the fix LGTM. W

[jira] [Commented] (PIG-4604) Clean up: refactor the package import order in the files under pig/src/org/apache/pig/backend/hadoop/executionengine/spark according to certain rule

2015-06-16 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589075#comment-14589075 ] Mohit Sabharwal commented on PIG-4604: -- LGTM. +1 (non-binding) > Clean up: r

[jira] [Created] (PIG-4601) Implement Merge CoGroup for Spark engine

2015-06-12 Thread Mohit Sabharwal (JIRA)
Mohit Sabharwal created PIG-4601: Summary: Implement Merge CoGroup for Spark engine Key: PIG-4601 URL: https://issues.apache.org/jira/browse/PIG-4601 Project: Pig Issue Type: Sub-task

[jira] [Commented] (PIG-4597) Enable "TestNullConstant" unit test in spark mode

2015-06-11 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14582647#comment-14582647 ] Mohit Sabharwal commented on PIG-4597: -- Thanks, [~kexianda]! LGTM. +1 (non-bin

[jira] [Resolved] (PIG-4189) Make cross join work with Spark

2015-06-10 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohit Sabharwal resolved PIG-4189. -- Resolution: Duplicate Assignee: Mohit Sabharwal CROSS operation is implemented in two

[jira] [Updated] (PIG-4585) Use newAPIHadoopRDD instead of newAPIHadoopFile

2015-06-10 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohit Sabharwal updated PIG-4585: - Attachment: PIG-4585.2.patch > Use newAPIHadoopRDD instead of newAPIHadoopF

[jira] [Commented] (PIG-4593) Enable "TestMultiQueryLocal" in spark mode

2015-06-10 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580954#comment-14580954 ] Mohit Sabharwal commented on PIG-4593: -- +1 (non-binding) >

[jira] [Commented] (PIG-4595) Fix unit test failures about TestFRJoinNullValue in spark mode

2015-06-10 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580953#comment-14580953 ] Mohit Sabharwal commented on PIG-4595: -- +1 (non-binding) > Fix unit test f

[jira] [Commented] (PIG-4596) Fix unit test failures about MergeJoinConverter in spark mode

2015-06-09 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14579431#comment-14579431 ] Mohit Sabharwal commented on PIG-4596: -- +1 (non-binding) > Fix unit test f

[jira] [Commented] (PIG-4593) Enable "TestMultiQueryLocal" in spark mode

2015-06-09 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14579417#comment-14579417 ] Mohit Sabharwal commented on PIG-4593: -- +1 (non-binding) >

[jira] [Updated] (PIG-4585) Use newAPIHadoopRDD instead of newAPIHadoopFile

2015-06-09 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohit Sabharwal updated PIG-4585: - Attachment: PIG-4585.1.patch > Use newAPIHadoopRDD instead of newAPIHadoopF

[jira] [Updated] (PIG-4588) Move tests under 'test-spark' target

2015-06-09 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohit Sabharwal updated PIG-4588: - Attachment: PIG-4588.1.patch > Move tests under 'test-spark

[jira] [Commented] (PIG-4589) Fix unit test failure in TestCase

2015-06-08 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578125#comment-14578125 ] Mohit Sabharwal commented on PIG-4589: -- +1 (non-binding) > Fix unit test fai

[jira] [Commented] (PIG-4586) Cleanup: Rename POConverter to RDDConverter

2015-06-04 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573206#comment-14573206 ] Mohit Sabharwal commented on PIG-4586: -- [~kellyzly], the "PO" pre

[jira] [Commented] (PIG-4283) Enable unit test "TestGrunt" for spark

2015-06-03 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572160#comment-14572160 ] Mohit Sabharwal commented on PIG-4283: -- +1 (non-binding) > Enable un

[jira] [Commented] (PIG-4588) Move tests under 'test-spark' target

2015-06-03 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572144#comment-14572144 ] Mohit Sabharwal commented on PIG-4588: -- [~kellyzly], [~kexianda], [~xuefuz] Kee

  1   2   3   4   >