[jira] [Commented] (PIG-1429) Add Boolean Data Type to Pig

[ https://issues.apache.org/jira/browse/PIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13083081#comment-13083081 ] Zhijie Shen commented on PIG-1429: -- Hi Daniel, Thanks for your review, I've fixed 1, 3, 4.

[jira] [Commented] (PIG-1429) Add Boolean Data Type to Pig

[ https://issues.apache.org/jira/browse/PIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13083219#comment-13083219 ] Daniel Dai commented on PIG-1429: - You are right. But I mean change the keyword to boolean

[jira] [Commented] (PIG-1429) Add Boolean Data Type to Pig

[ https://issues.apache.org/jira/browse/PIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13082766#comment-13082766 ] Daniel Dai commented on PIG-1429: - I was impressed by the completeness of the patch. Good

[jira] [Commented] (PIG-1429) Add Boolean Data Type to Pig

[ https://issues.apache.org/jira/browse/PIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13080093#comment-13080093 ] Daniel Dai commented on PIG-1429: - Hi, Zhijie, Discussed with Thejas, here is the things we

[jira] [Commented] (PIG-1429) Add Boolean Data Type to Pig

[ https://issues.apache.org/jira/browse/PIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13079455#comment-13079455 ] Zhijie Shen commented on PIG-1429: -- Hi Thejas, I agree with you on the first two points.

[jira] [Commented] (PIG-1429) Add Boolean Data Type to Pig

[ https://issues.apache.org/jira/browse/PIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13078605#comment-13078605 ] Daniel Dai commented on PIG-1429: - Hi, Zhijie, patch in generally looks good. I tested load

[jira] [Commented] (PIG-1429) Add Boolean Data Type to Pig

[ https://issues.apache.org/jira/browse/PIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13078639#comment-13078639 ] Zhijie Shen commented on PIG-1429: -- Hi Daniel, thanks for your review. I'm adding the test

[jira] [Commented] (PIG-1429) Add Boolean Data Type to Pig

[ https://issues.apache.org/jira/browse/PIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13078852#comment-13078852 ] Zhijie Shen commented on PIG-1429: -- I just found there is one more issue to deal with: sort

[jira] [Commented] (PIG-1429) Add Boolean Data Type to Pig

[ https://issues.apache.org/jira/browse/PIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13078885#comment-13078885 ] Daniel Dai commented on PIG-1429: - Yes, you are right, you will need to add

[jira] [Commented] (PIG-1429) Add Boolean Data Type to Pig

[ https://issues.apache.org/jira/browse/PIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13078999#comment-13078999 ] Thejas M Nair commented on PIG-1429: My opinion on what should be the behavior for casts

[jira] [Commented] (PIG-1429) Add Boolean Data Type to Pig

[ https://issues.apache.org/jira/browse/PIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13079043#comment-13079043 ] Thejas M Nair commented on PIG-1429: Olga, I was referring to only implicit conversions.

[jira] [Commented] (PIG-1429) Add Boolean Data Type to Pig

[ https://issues.apache.org/jira/browse/PIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13079065#comment-13079065 ] Olga Natkovich commented on PIG-1429: - Oh, I missed that one was explicit and one was

[jira] [Commented] (PIG-1429) Add Boolean Data Type to Pig

[ https://issues.apache.org/jira/browse/PIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13070419#comment-13070419 ] Gianmarco De Francisci Morales commented on PIG-1429: - bq. 2. Similarly,

[jira] [Commented] (PIG-1429) Add Boolean Data Type to Pig

[ https://issues.apache.org/jira/browse/PIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13066469#comment-13066469 ] Zhijie Shen commented on PIG-1429: -- So how about treating DataByteArray as a string, and

[jira] [Commented] (PIG-1429) Add Boolean Data Type to Pig

[ https://issues.apache.org/jira/browse/PIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13066476#comment-13066476 ] Dmitriy V. Ryaboy commented on PIG-1429: We already have a public bytesToBoolean

[jira] [Commented] (PIG-1429) Add Boolean Data Type to Pig

[ https://issues.apache.org/jira/browse/PIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13066358#comment-13066358 ] Zhijie Shen commented on PIG-1429: -- Does anyone have the opinion of casting DataByteArray

[jira] [Commented] (PIG-1429) Add Boolean Data Type to Pig

[ https://issues.apache.org/jira/browse/PIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13009273#comment-13009273 ] Gianmarco De Francisci Morales commented on PIG-1429: - Hi, I was

[jira] [Commented] (PIG-1429) Add Boolean Data Type to Pig

[ https://issues.apache.org/jira/browse/PIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13009302#comment-13009302 ] Daniel Dai commented on PIG-1429: - Hi, Gianmarco, We didn't hear back from original author