[
https://issues.apache.org/jira/browse/PIG-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231648#comment-13231648
]
Jonathan Coveney commented on PIG-2551:
---
Does this look good to y'all now?
[
https://issues.apache.org/jira/browse/PIG-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228737#comment-13228737
]
Dmitriy V. Ryaboy commented on PIG-2551:
Jon, describe the benchmark methodology?
[
https://issues.apache.org/jira/browse/PIG-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228744#comment-13228744
]
Daniel Dai commented on PIG-2551:
-
Hi, Jon, we don't need a big disclaimer, but it's better
[
https://issues.apache.org/jira/browse/PIG-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228745#comment-13228745
]
Jonathan Coveney commented on PIG-2551:
---
I have LongSum, COUNT, AlgSum, and AlgCount.
[
https://issues.apache.org/jira/browse/PIG-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228749#comment-13228749
]
Jonathan Coveney commented on PIG-2551:
---
Sounds fair, Daniel. Anything else I should
[
https://issues.apache.org/jira/browse/PIG-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228754#comment-13228754
]
Daniel Dai commented on PIG-2551:
-
+1 as long as we have proper javadoc and header
[
https://issues.apache.org/jira/browse/PIG-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228854#comment-13228854
]
Daniel Dai commented on PIG-2551:
-
Still missing header for HelperEvalFuncUtils.java.
[
https://issues.apache.org/jira/browse/PIG-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225781#comment-13225781
]
Daniel Dai commented on PIG-2551:
-
Generally it looks good. In addition to Julien's comment,
[
https://issues.apache.org/jira/browse/PIG-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225790#comment-13225790
]
Dmitriy V. Ryaboy commented on PIG-2551:
We should benchmark the performance loss on
[
https://issues.apache.org/jira/browse/PIG-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13222477#comment-13222477
]
Julien Le Dem commented on PIG-2551:
Thanks Jonathan
Here are a few comments:
* in
10 matches
Mail list logo