[
https://issues.apache.org/jira/browse/PIG-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14003734#comment-14003734
]
Aniket Mokashi commented on PIG-3913:
-
Committed to trunk! (review updated and patch att
[
https://issues.apache.org/jira/browse/PIG-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002486#comment-14002486
]
Aniket Mokashi commented on PIG-3913:
-
Thanks [~jira.shegalov] and [~cheolsoo] for the r
[
https://issues.apache.org/jira/browse/PIG-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002474#comment-14002474
]
Cheolsoo Park commented on PIG-3913:
+1. Let's commit this.
Btw, the patch needs to be
[
https://issues.apache.org/jira/browse/PIG-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993148#comment-13993148
]
Aniket Mokashi commented on PIG-3913:
-
Looking at this, it seems main difference is - in
[
https://issues.apache.org/jira/browse/PIG-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999581#comment-13999581
]
Gera Shegalov commented on PIG-3913:
+1 (non-binding) modulo nits on RB
> Pig should us
[
https://issues.apache.org/jira/browse/PIG-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997002#comment-13997002
]
Jonathan Coveney commented on PIG-3913:
---
Can you throw this in the apache reviewboard?
[
https://issues.apache.org/jira/browse/PIG-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997880#comment-13997880
]
Aniket Mokashi commented on PIG-3913:
-
#GoodIdea: https://reviews.apache.org/r/21454/
>
[
https://issues.apache.org/jira/browse/PIG-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13994005#comment-13994005
]
Aniket Mokashi commented on PIG-3913:
-
Added a new patch for this.
> Pig should use job
[
https://issues.apache.org/jira/browse/PIG-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13994315#comment-13994315
]
Gera Shegalov commented on PIG-3913:
[~aniket486], PIG-3913-3 patch is incomplete, Downg
[
https://issues.apache.org/jira/browse/PIG-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995297#comment-13995297
]
Aniket Mokashi commented on PIG-3913:
-
I've attached PIG-3913-5.patch.
> Pig should use
[
https://issues.apache.org/jira/browse/PIG-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985851#comment-13985851
]
Aniket Mokashi commented on PIG-3913:
-
Thanks for the review, [~julienledem]. I realized
[
https://issues.apache.org/jira/browse/PIG-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985005#comment-13985005
]
Julien Le Dem commented on PIG-3913:
This looks good to me.
Please add javadoc for depre
12 matches
Mail list logo