[
https://issues.apache.org/jira/browse/PIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976979#action_12976979
]
Alan Gates commented on PIG-1675:
-
+1 on the latest patch, changes look good.
To comment o
[
https://issues.apache.org/jira/browse/PIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974987#action_12974987
]
Dmitriy V. Ryaboy commented on PIG-1675:
Granted, we labeled PigServer as stable..
[
https://issues.apache.org/jira/browse/PIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974986#action_12974986
]
Dmitriy V. Ryaboy commented on PIG-1675:
I am not terribly happy with the explosion o
[
https://issues.apache.org/jira/browse/PIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922599#action_12922599
]
Alan Gates commented on PIG-1675:
-
In your change you close the InputStream no matter what.
[
https://issues.apache.org/jira/browse/PIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922593#action_12922593
]
Alan Gates commented on PIG-1675:
-
I also ran all the unit tests, and they pass.
> Suggest t
[
https://issues.apache.org/jira/browse/PIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922574#action_12922574
]
Jeff Zhang commented on PIG-1675:
-
Alan, it complains that I may not close the FileInputStrea
[
https://issues.apache.org/jira/browse/PIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922389#action_12922389
]
Alan Gates commented on PIG-1675:
-
Feedback from testpatch.sh
{code}
[exec] -1 overall.
[
https://issues.apache.org/jira/browse/PIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922319#action_12922319
]
Alan Gates commented on PIG-1675:
-
+1
> Suggest to allow PigServer can register pig script f
[
https://issues.apache.org/jira/browse/PIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920656#action_12920656
]
Alan Gates commented on PIG-1675:
-
I think this is a good change. One concern is that in the