Re: Review Request 45667: Support Pig On Spark

2016-10-26 Thread Pallavi Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45667/ --- (Updated Oct. 27, 2016, 3:17 a.m.) Review request for pig, Daniel Dai and Rohin

Re: Review Request 45667: Support Pig On Spark

2016-10-26 Thread kelly zhang
> On May 22, 2016, 9:57 p.m., Rohini Palaniswamy wrote: > > src/org/apache/pig/backend/hadoop/hbase/HBaseStorage.java, line 313 > > > > > > Just change the code to use UDFContext.getUDFContext().getJobConf() > > whi

Re: Review Request 45667: Support Pig On Spark

2016-07-10 Thread Pallavi Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45667/ --- (Updated July 11, 2016, 4:32 a.m.) Review request for pig, Daniel Dai and Rohin

Re: Review Request 45667: Support Pig On Spark

2016-07-07 Thread kelly zhang
> On May 22, 2016, 9:57 p.m., Rohini Palaniswamy wrote: > > test/org/apache/pig/test/TestCombiner.java, lines 189-191 > > > > > > Can be removed with the change to checkCombinerUsed can not change checkCombinerUsed(

Re: Review Request 45667: Support Pig On Spark

2016-06-13 Thread Pallavi Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45667/ --- (Updated June 14, 2016, 4:39 a.m.) Review request for pig, Daniel Dai and Rohin

RE: Review Request 45667: Support Pig On Spark

2016-06-13 Thread Zhang, Liyun
: Tuesday, June 14, 2016 11:25 AM To: Rohini Palaniswamy; Daniel Dai Cc: Zhang, Liyun; Pallavi Rao; pig Subject: Re: Review Request 45667: Support Pig On Spark > On May 22, 2016, 9:57 p.m., Rohini Palaniswamy wrote: > > test/org/apache/pig/test/TestBuiltin.java, line 3255 > > <https://

Re: Review Request 45667: Support Pig On Spark

2016-06-13 Thread kelly zhang
> On May 22, 2016, 9:57 p.m., Rohini Palaniswamy wrote: > > test/org/apache/pig/test/TestBuiltin.java, line 3255 > > > > > > This testcase is broken if you have 0-0 repeating twice. It is not > > UniqueID anymore.

Re: Review Request 45667: Support Pig On Spark

2016-05-22 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45667/#review134255 --- Review comments for all non-spark classes. bin/pig (line 365)