Re: Review Request: Need better error message for Jython errors

2011-01-14 Thread Julien Le Dem
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/320/#review122 --- Ship it! Interesting! - Julien On 2011-01-14 14:18:18, Richard Ding

Re: Review Request: Need better error message for Jython errors

2011-01-14 Thread Richard Ding
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/320/ --- (Updated 2011-01-14 14:18:18.495783) Review request for pig and Julien Le Dem.

Re: Review Request: Need better error message for Jython errors

2011-01-14 Thread Richard Ding
> On 2011-01-14 10:22:23, Julien Le Dem wrote: > > 1) I like the simplification of not requiring the - in FS commands > > > > 2) In "catch (PyException e)" whether the message is null or not I would > > use e.toString() which includes the Exception class name + message. A good > > example of n

Re: Review Request: Need better error message for Jython errors

2011-01-14 Thread Richard Ding
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/320/ --- (Updated 2011-01-14 14:15:22.814927) Review request for pig and Julien Le Dem.

Re: Review Request: Need better error message for Jython errors

2011-01-14 Thread Julien Le Dem
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/320/#review119 --- 1) I like the simplification of not requiring the - in FS commands 2) I

Re: Review Request: Need better error message for Jython errors

2011-01-14 Thread Richard Ding
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/320/ --- (Updated 2011-01-14 09:51:20.910864) Review request for pig and Julien Le Dem.

Review Request: Need better error message for Jython errors

2011-01-13 Thread Richard Ding
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/320/ --- Review request for pig. Summary --- Current Pig exception handling does not