Re: Review Request 14552: PIG-3480 TFile-based tmpfile compression crashes in some cases

> On Oct. 13, 2013, 11:40 a.m., Julien Le Dem wrote: > > trunk/src/org/apache/pig/impl/util/Utils.java, lines 357-359 > > > > > > now it should be: > > } else if > > (TEMPFILE_STORAGE.TFILE.lowerName().equals(tmpF

Re: Review Request 14552: PIG-3480 TFile-based tmpfile compression crashes in some cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14552/#review26963 --- Just one last comment. Otherwise it looks good to me. Thanks Aniket!

Re: Review Request 14552: PIG-3480 TFile-based tmpfile compression crashes in some cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14552/ --- (Updated Oct. 12, 2013, 12:44 a.m.) Review request for pig, Cheolsoo Park, Dmit

Re: Review Request 14552: PIG-3480 TFile-based tmpfile compression crashes in some cases

> On Oct. 11, 2013, 11:40 p.m., Dmitriy Ryaboy wrote: > > trunk/conf/pig.properties, line 66 > > > > > > drop -- this is redefined below #EagleEye > On Oct. 11, 2013, 11:40 p.m., Dmitriy Ryaboy wrote: > > trunk/src/o

Re: Review Request 14552: PIG-3480 TFile-based tmpfile compression crashes in some cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14552/#review26948 --- trunk/conf/pig.properties

Re: Review Request 14552: PIG-3480 TFile-based tmpfile compression crashes in some cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14552/ --- (Updated Oct. 11, 2013, 8:43 p.m.) Review request for pig, Cheolsoo Park, Dmitr

Re: Review Request 14552: PIG-3480 TFile-based tmpfile compression crashes in some cases

> On Oct. 10, 2013, 8:50 p.m., Julien Le Dem wrote: > > trunk/src/org/apache/pig/impl/util/Utils.java, line 259 > > > > > > We should throw an exception if the trimmed lowercased string is > > something we don't expe

Re: Review Request 14552: PIG-3480 TFile-based tmpfile compression crashes in some cases

> On Oct. 10, 2013, 8:50 p.m., Julien Le Dem wrote: > > trunk/src/org/apache/pig/impl/util/Utils.java, line 329 > > > > > > else throw exception? > > we have a default if it's not set but we don't do anything if it

Re: Review Request 14552: PIG-3480 TFile-based tmpfile compression crashes in some cases

> On Oct. 10, 2013, 8:50 p.m., Julien Le Dem wrote: > > trunk/src/org/apache/pig/impl/util/Utils.java, line 259 > > > > > > We should throw an exception if the trimmed lowercased string is > > something we don't expe

Re: Review Request 14552: PIG-3480 TFile-based tmpfile compression crashes in some cases

> On Oct. 10, 2013, 8:50 p.m., Julien Le Dem wrote: > > trunk/src/org/apache/pig/impl/util/Utils.java, line 259 > > > > > > We should throw an exception if the trimmed lowercased string is > > something we don't expe

Re: Review Request 14552: PIG-3480 TFile-based tmpfile compression crashes in some cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14552/#review26894 --- Overall this looks good to me. Some comments regarding error handlin

Re: Review Request 14552: PIG-3480 TFile-based tmpfile compression crashes in some cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14552/ --- (Updated Oct. 9, 2013, 6 p.m.) Review request for pig, Cheolsoo Park, Dmitriy R

Re: Review Request 14552: PIG-3480 TFile-based tmpfile compression crashes in some cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14552/ --- (Updated Oct. 9, 2013, 1:32 a.m.) Review request for pig, Cheolsoo Park, Dmitri

Re: Review Request 14552: PIG-3480 TFile-based tmpfile compression crashes in some cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14552/#review26808 --- trunk/src/org/apache/pig/impl/util/Utils.java

Re: Review Request 14552: PIG-3480 TFile-based tmpfile compression crashes in some cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14552/ --- (Updated Oct. 9, 2013, 1:02 a.m.) Review request for pig, Cheolsoo Park, Dmitri

Review Request 14552: PIG-3480 TFile-based tmpfile compression crashes in some cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14552/ --- Review request for pig, Cheolsoo Park, Dmitriy Ryaboy, and Rohini Palaniswamy.