Yes that's correct. That's one of the reasons why I have become less of a
fan around observer/listener semantics of any type lately and more towards
message-based communication for tree events/property changes, etc.
Anyway, that's fine. The annotation base class that I'll offer up as the
starting
[
https://issues.apache.org/jira/browse/PIVOT-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Brown resolved PIVOT-532.
--
Resolution: Fixed
Thanks. Noticed this a few days ago myself.
Bad link in Data Binding tutorial
[
https://issues.apache.org/jira/browse/PIVOT-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12880635#action_12880635
]
Greg Brown commented on PIVOT-534:
--
The transitions have always looked pretty good to me.
[
https://issues.apache.org/jira/browse/PIVOT-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12880636#action_12880636
]
Greg Brown commented on PIVOT-535:
--
Agreed re: weak listeners - not a good idea.
Appddevv,
My comments below - Noel, please feel free to provide additional detail.
a) How can I extract out the current line and column number?
TextArea#getRowIndex() will give you the line number. There is currently no way
to determine the column index. However, assuming that we define column index
as
With regard to (d) for my specific need it pivotpad, I just want to bind
some convenient keys to logical cursor movements but I think in general,
you'll want to have a layer of indirection on keystroke to doing something
in the editor like cursor movement so that more than just a keystroke can
Not sure if you are suggesting adding something like this to the platform or
not, but based on what I have seen so far I think it may be a bit too
application-specific. A couple of the features seem to rely heavily on
Component user data, which is entirely the domain of the application (the
Need to see usage examples. It is difficult to understand what these classes
are meant to do without seeing how they are supposed to be applied. The design
doc will probably help here.
Either way, I don't think we'd want to include support for weak references, and
I'm not sure we need to do
I want to add that I appreciate the effort you have put into this code. You are
clearly investing a significant amount of time in PivotPad, and I'm looking
forward to seeing the result (if you are willing to share it).
The thing I am struggling with is what, to me, seems like a relatively high
I agree with you on your points. In general, annotations always have higher
degrees of code complexity but can play a useful role for simplifying user
code.
The code has one intent--making message listening registration easier.
Annotate a method with @MessageListener and it is automatically
Bindable only works on the root object of the serializer and does not have
the proper link to the component to initialize off of it
Generally, the Bindable object will be the component, so it doesn't need a
reference to it (beyond this).
pivot also uses the Bindable interface to tag an
I don't disagree with your comments. My comments were merely to highlight
how Bindable works and how other initialization approaches may need to exist
*and* should be seen as similar in concept--I was not picking on Bindable.
I don't think you need every possible approach directly in pivot.
[
https://issues.apache.org/jira/browse/PIVOT-534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bartlett updated PIVOT-534:
-
Attachment: PIVOT-534_ExposeTransitionsAsStyles.patch
Attached a patch for the 6 classes.
Note
[
https://issues.apache.org/jira/browse/PIVOT-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12880657#action_12880657
]
Chris Bartlett commented on PIVOT-534:
--
I'll try to find a tool to do video captures of
Hi
Greg, are you particularly attached to having font styling in the
Element class? The way the code is working out, it's going to be a lot
simpler if I push font styling attributes down into the TextNode
class.
In particular, line breaking in the skin becomes a lot simpler (at the
moment it
[
https://issues.apache.org/jira/browse/PIVOT-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12880671#action_12880671
]
Sandro Martini commented on PIVOT-535:
--
Hi to all,
I like the proposal, and generally
[
https://issues.apache.org/jira/browse/PIVOT-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12880674#action_12880674
]
Sandro Martini commented on PIVOT-534:
--
Hi to all,
On a related note, the current hard
Hi to all,
However, some small changes allow other major approaches! I've only advocated
for making those small changes so that another approach is not too hard to
make happen.
Probably my mind focus is not-so-much as library writer, but generally
speaking I'm near the suggested approach.
[
https://issues.apache.org/jira/browse/PIVOT-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12880678#action_12880678
]
Sandro Martini commented on PIVOT-533:
--
Hi,
before making the patch, are there any
Sandro,
Thanks. BTW, I think that anytime you touch annotations, it always seems to
involve larger, more complex code and I understand the concern. Just on
those grounds is sufficient reason to not include it.
With regard to weak listeners, I believe that we are talking about two
different areas
I don't disagree with your comments. ...
I don't think you need every possible approach directly in pivot.
OK, thanks for clarifying. I agree that not every approach should or needs to
be directly supported by the platform. However, the platform shouldn't preclude
other approaches, and should
I'd prefer to keep it in Element, for a couple of reasons:
1) It allows sub-nodes to inherit the styles.
2) A TextNode is simply meant to represent a run of text independent of
styling. It should determine any and all styles from its parent (generally
either a Paragraph or a Span).
G
On Jun
[
https://issues.apache.org/jira/browse/PIVOT-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12880693#action_12880693
]
Greg Brown commented on PIVOT-534:
--
I'd like to get more detailed information on the system
23 matches
Mail list logo
