Bug in JSON.java prevents the use of Element as a destination for data binding
--
Key: PIVOT-547
URL: https://issues.apache.org/jira/browse/PIVOT-547
Project: Pivot
[
https://issues.apache.org/jira/browse/PIVOT-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Allman updated PIVOT-547:
-
Attachment: xml_binding_fix.patch
Proposed fix
> Bug in JSON.java prevents the use of Element as
Thoughts with >>>. My mail program did not auto > the previous email :-)
Thanks for responding to this. I'll close this out.
-Original Message-
From: Greg Brown [mailto:gkbr...@mac.com]
Sent: Wednesday, June 23, 2010 2:41 PM
To: dev@pivot.apache.org
Subject: Re: [jira] Resolved: (PIVOT-5
I'm not sure of the current implementation, but if by doing a selection
indirectly, you fire an event for each selection, as it is selected in the
set being set, then that could be inefficient or at least push the burden of
inefficiency into the client. If it fires after all of them have been
selec
This sounds good. But why would you pass null? Should it not be be the
previous selection info (the current selection prior to changing it
indirectly? This would be consistent with doing it "directly."
-Original Message-
From: Greg Brown [mailto:gkbr...@mac.com]
Sent: Thursday, June 24, 2
I've just seen commits ... very good, and as always thank you very much.
Bye,
Sandro
> TextAreaSkin.java:1397 instanceof will always return true, since all
> org.apache.pivot.wtk.text.Element are instances of
> org.apache.pivot.wtk.text.Element
> TextAreaSkin.java:1377 instanceof will always return true, since all
> org.apache.pivot.wtk.text.Element are instances of
> org.apache.pi
[
https://issues.apache.org/jira/browse/PIVOT-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Brown resolved PIVOT-468.
--
Resolution: Fixed
> Update tutorials to use Bindable where applicable
>
Hi Greg,
>> Wtk-Terra:
>> TerraActivityIndicatorSkin.java:88 Dead store to increment
>> TerraPanoramaSkin.java:378 Dead store to scrollTop
>> TerraPanoramaSkin.java:385 Dead store to scrollLeft
>
> These are probably worth looking into.
These are less important on all I send in the previous mail .
> Core:
> BeanSerializer.java:81 Method
> org.apache.pivot.beans.BeanSerializer$NamedObjectBindings.putAll(Map)
> makes inefficient use of keySet iterator instead of entrySet iterator
Ignore this.
> Tools:
> EventLoggerSkin.java:44
> org.apache.pivot.tools.wtk.EventLoggerSkin$TreeNodeComparator
>
Hi to all,
some little things seen by FindBugs on Pivot trunk:
Core:
BeanSerializer.java:81 Method
org.apache.pivot.beans.BeanSerializer$NamedObjectBindings.putAll(Map)
makes inefficient use of keySet iterator instead of entrySet iterator
Tools:
EventLoggerSkin.java:44
org.apache.pivot.tools.wtk.
To me some parts are not-so-clear, so maybe showing some minimal
classes (for example a minimal and simple usage) could help to clarify
and comments ...
Bye,
Sandro
> The performance impact should be negligible.
I was sure of it :-) ...
The performance impact should be negligible.
On Jun 24, 2010, at 5:52 PM, Sandro Martini wrote:
> Hi Greg,
> for me the change is right, and maybe with this application selection
> listeners could see what to do (and when it's the case ignoring the
> "indirect change" event, like today) ... and o
Hi Greg,
for me the change is right, and maybe with this application selection
listeners could see what to do (and when it's the case ignoring the
"indirect change" event, like today) ... and on all selectable
components, right ?
Have you an idea on the performance impact of this change on
tables/t
Hi all,
I am thinking about making a change to how selection change events are fired
and I would like to hear your feedback. Currently, selection change events are
fired only when an explicit call has been made that affects the selection.
For example, in ListView, calling either setSelectedRan
[
https://issues.apache.org/jira/browse/PIVOT-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882289#action_12882289
]
Greg Brown commented on PIVOT-544:
--
I think the existing full-screen mode might be better s
[
https://issues.apache.org/jira/browse/PIVOT-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882229#action_12882229
]
Roger Whitcomb commented on PIVOT-544:
--
Just wanted to add to the use case for this cha
[
https://issues.apache.org/jira/browse/PIVOT-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Brown updated PIVOT-239:
-
Priority: Major (was: Minor)
With an increased emphasis on Bindable (see PIVOT-546), this feature will
b
[
https://issues.apache.org/jira/browse/PIVOT-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882159#action_12882159
]
Greg Brown commented on PIVOT-468:
--
With the introduction of the context argument documente
Add a context argument to Bindable#initialize()
---
Key: PIVOT-546
URL: https://issues.apache.org/jira/browse/PIVOT-546
Project: Pivot
Issue Type: Improvement
Components: core-beans
[
https://issues.apache.org/jira/browse/PIVOT-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Brown resolved PIVOT-546.
--
Resolution: Fixed
> Add a context argument to Bindable#initialize()
> --
I believe it was originally intended to propagate the application icon to an
alert or prompt - I believe some OS X applications do this. However, it is
probably safe to remove.
On Jun 24, 2010, at 4:12 AM, Noel Grandin wrote:
> Hi
>
> I can't find a use for the constant MessageType.APPLICATION
[
https://issues.apache.org/jira/browse/PIVOT-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Brown resolved PIVOT-538.
--
Resolution: Not A Problem
OK, great. Since you have it working now, I'm going to resolve this as not a
Hi
I can't find a use for the constant MessageType.APPLICATION in the pivot
code.
Is it intended for something, or can I remove it?
-- Noel Grandin
25 matches
Mail list logo
