[
https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036079#comment-13036079
]
Raffaele Borrelli commented on PIVOT-737:
-
Thanks Sandro and Greg, I was having the
[
https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035689#comment-13035689
]
Greg Brown commented on PIVOT-737:
--
It is preferable to leave things stable in SVN wheneve
[
https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035680#comment-13035680
]
Sandro Martini commented on PIVOT-737:
--
I'm planning to redo the fix (for both things)
Hi all,
just comnmitted the fixed, and to ensure that all is good, add a
contextual menu on Right Click in both Tests User applications,
reusing the new version of ContextMenus (under Tests), with more
combinations of elements.
If something is not Ok, be free to reopen the ticket and/or tell me.
Ok, my idea was to reuse this class from both test applications, but they are
inside the test subproject so I agree with you. I'll do the revert in next
days ...
Only a thing:
don't you think it would be useful to show the enabled/action simple usage
(as in the code I've committed) inside that Tut
Test code doesn't belong in the tutorial. I'd suggest copying your work to the
tests project and revert the tutorial back to its original state.
G
On May 5, 2011, at 7:11 PM, Sandro Martini wrote:
> Just committed a simple addition to ContextMenus:
> add some items to the contextual menu, to see
Just committed a simple addition to ContextMenus:
add some items to the contextual menu, to see better what happens with
items in different status (enabled, disabled, with action, and with
action null). I'll reuse this class in tests for PIVOT-737 to verify
if/how contextual menus will be handled w
Hi,
> Since that update fixed Raffaele's problem, is there an immediate need to
> change the selection behavior?
For me there is no problem to fix this in the 2.0.2 (if we will do it) or
better in the 2.1 (and move this part in a dedicated jira ticket), but I'm
not sure that with my little fix th
Oh, I see. You just changed the way editors are triggered:
http://mail-archives.apache.org/mod_mbox/pivot-commits/201105.mbox/%3c20110502221720.671202388...@eris.apache.org%3e
Since that update fixed Raffaele's problem, is there an immediate need to
change the selection behavior?
On May 4, 2011
No, because I wasn't sure it was by design ... but as soon as possible (this
week) I'll fix it.
Bye
--
View this message in context:
http://apache-pivot-developers.417237.n3.nabble.com/jira-Created-PIVOT-737-TerraTableViewSkin-opens-a-TableViewRowEditor-listening-to-both-mouse-buttons-tp2871532
>> I'm actually inclined to say that right-click should never change selection
>> - only left-click (in other words, don't even make it an option).
> Ok, so I'll proceed to implement this (removing the selection with right
> click) ...
I thought you already checked that change in?
>> Yes, I agree with you, but so there is only a corner case where that
>> exception is not thrown if I call the setEnabled(false) just before the
>> setAction() ... so if possible I'd like a runtime exception even in this
>> case.
>
>I don't think this is an exceptional condition. Calling setActio
> So my proposal to add a style to enable/disable selections even on right
> click (maybe with default enabled, like the current behavior, but for anyone
> not wanting it like in Raffaele case could be used to disable it), could be
> simpler and targeted to 2.0.1, while a more complex solution coul
> Yes, I agree with you, but so there is only a corner case where that
> exception is not thrown if I call the setEnabled(false) just before the
> setAction() ... so if possible I'd like a runtime exception even in this
> case.
I don't think this is an exceptional condition. Calling setAction() sh
Hi Greg,
>> Only a last thing, sorry, just to close the point:
>> even if I set the enables status of the Menu.Item to false, is it right
>> that
>> in the perform(Component source) , source is the Menu.Item, but as
>> inspected
>> by the debugger it has enabled = true ?
>
>Yes, because the code
> Only a last thing, sorry, just to close the point:
> even if I set the enables status of the Menu.Item to false, is it right that
> in the perform(Component source) , source is the Menu.Item, but as inspected
> by the debugger it has enabled = true ?
Yes, because the code does not allow you to
Ok, now I understand better :-) .
Only a last thing, sorry, just to close the point:
even if I set the enables status of the Menu.Item to false, is it right that
in the perform(Component source) , source is the Menu.Item, but as inspected
by the debugger it has enabled = true ?
If yes, I still h
The code is doing the right thing. If you assign an action to a button, you
should use the action to manage the button's enabled state, not setEnabled().
On May 4, 2011, at 10:16 AM, Sandro Martini wrote:
> Hi Greg,
> if i add this
>
>whatIsThisMenuItem.setEnabled(false);
>
> after
Hi Greg,
if i add this
whatIsThisMenuItem.setEnabled(false);
after the line
whatIsThisMenuItem.setAction(new Action() {
...
});
at runtime I get this exception:
java.lang.IllegalArgumentException: Button and ac
I believe that issue was already resolved. The menu item was using an action,
so the action itself has to be disabled. In other words, I believe it is
working properly.
G
On May 3, 2011, at 6:41 PM, Sandro Martini (JIRA) wrote:
>
>[
> https://issues.apache.org/jira/browse/PIVOT-737?page=c
[
https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028484#comment-13028484
]
Sandro Martini commented on PIVOT-737:
--
Hi Greg, I'll try to clarify the part related
[
https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028165#comment-13028165
]
Greg Brown commented on PIVOT-737:
--
Thanks for making this fix Sandro. I have not tested i
[
https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028110#comment-13028110
]
Sandro Martini commented on PIVOT-737:
--
Ciao Raffaele, Yes, even to me the proposed ch
[
https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028019#comment-13028019
]
Raffaele Borrelli commented on PIVOT-737:
-
That is exactly what I wanted. I have a
[
https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027889#comment-13027889
]
Sandro Martini commented on PIVOT-737:
--
Maybe now I understand the fix of Raffaele: pr
[
https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027882#comment-13027882
]
Sandro Martini commented on PIVOT-737:
--
Just committed the fix for mouseClicked on Ter
[
https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027869#comment-13027869
]
Sandro Martini commented on PIVOT-737:
--
Hi all,
on the contextual menu issue (in the o
27 matches
Mail list logo
