[jira] Commented: (PIVOT-713) Consider making some inner classes non-final

2011-03-18 Thread Greg Brown (JIRA)
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13008436#comment-13008436 ] Greg Brown commented on PIVOT-713: -- No, the first patch is wrong too. The only classes

[jira] Commented: (PIVOT-713) Consider making some inner classes non-final

2011-03-18 Thread Sandro Martini (JIRA)
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13008443#comment-13008443 ] Sandro Martini commented on PIVOT-713: -- Ok, I'll change only those definitions. But

[jira] Commented: (PIVOT-713) Consider making some inner classes non-final

2011-03-18 Thread Sandro Martini (JIRA)
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13008451#comment-13008451 ] Sandro Martini commented on PIVOT-713: -- Ok, now all is clear (I hope :-) ). Thank you

[jira] Commented: (PIVOT-713) Consider making some inner classes non-final

2011-03-17 Thread Greg Brown (JIRA)
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13007895#comment-13007895 ] Greg Brown commented on PIVOT-713: -- Actually, now that I see the list, I think the only

[jira] Commented: (PIVOT-713) Consider making some inner classes non-final

2011-03-15 Thread Greg Brown (JIRA)
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13006889#comment-13006889 ] Greg Brown commented on PIVOT-713: -- There may be a few others as well. Did you search for

[jira] Commented: (PIVOT-713) Consider making some inner classes non-final

2011-03-15 Thread Sandro Martini (JIRA)
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13006908#comment-13006908 ] Sandro Martini commented on PIVOT-713: -- No, at the moment I've only fixed the required

[jira] Commented: (PIVOT-713) Consider making some inner classes non-final

2011-03-15 Thread Greg Brown (JIRA)
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13006911#comment-13006911 ] Greg Brown commented on PIVOT-713: -- If there are other issues I'm not against removing

[jira] Commented: (PIVOT-713) Consider making some inner classes non-final

2011-03-15 Thread Sandro Martini (JIRA)
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13007001#comment-13007001 ] Sandro Martini commented on PIVOT-713: -- just put in attach a txt containing the output

[jira] Commented: (PIVOT-713) Consider making some inner classes non-final

2011-03-15 Thread Greg Brown (JIRA)
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13007004#comment-13007004 ] Greg Brown commented on PIVOT-713: -- You should search for public static final classes only

[jira] Commented: (PIVOT-713) Consider making some inner classes non-final

2011-03-14 Thread Sandro Martini (JIRA)
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13006709#comment-13006709 ] Sandro Martini commented on PIVOT-713: -- Hi all, with the patch here in attach I think