So much for not spamming the mailing list ;-)
Chris
Am 30.08.18, 11:32 schrieb "GitBox" :
chrisdutz opened a new pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14
---
sruehl commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213981954
##
File path:
plc4j/api/src/test/java/org/apache/plc4x/java/api/connection/PlcReaderTest.java
##
@@ -38,24 +36,24 @@ Licensed
chrisdutz commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213981663
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcFieldResponse.java
##
@@ -0,0 +1,42 @@
+/*
+Li
chrisdutz commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213981675
##
File path:
plc4j/api/src/test/java/org/apache/plc4x/java/api/connection/PlcReaderTest.java
##
@@ -38,24 +36,24 @@ Licen
chrisdutz commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213981646
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcFieldRequest.java
##
@@ -0,0 +1,31 @@
+/*
+Lic
chrisdutz commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213980628
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/connection/PlcProprietarySender.java
##
@@ -1,41 +0,0 @@
-
chrisdutz commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213980452
##
File path:
integrations/apache-camel/src/main/java/org/apache/plc4x/camel/Plc4XConsumer.java
##
@@ -112,25 +114,25 @@ p
sruehl commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213965327
##
File path:
integrations/apache-camel/src/main/java/org/apache/plc4x/camel/Plc4XConsumer.java
##
@@ -112,25 +114,25 @@ priv
sruehl commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213968452
##
File path:
plc4j/api/src/test/java/org/apache/plc4x/java/api/connection/PlcReaderTest.java
##
@@ -38,24 +36,24 @@ Licensed
sruehl commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213965185
##
File path:
integrations/apache-camel/src/main/java/org/apache/plc4x/camel/Plc4XConsumer.java
##
@@ -84,22 +79,29 @@ public
sruehl commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213966073
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/connection/PlcProprietarySender.java
##
@@ -1,41 +0,0 @@
-/*
sruehl commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213967016
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcFieldResponse.java
##
@@ -0,0 +1,42 @@
+/*
+Licen
sruehl commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213966847
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcFieldRequest.java
##
@@ -0,0 +1,31 @@
+/*
+Licens
sruehl commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213964940
##
File path:
integrations/apache-camel/src/main/java/org/apache/plc4x/camel/Plc4XConsumer.java
##
@@ -84,22 +79,29 @@ public
Ok, looking through the slack #general history it seems like the @asfarchivebot
doesn’t do anything.
So we will stick to what Chris said: keep things on the list :D
Sebastian
> Am 30.08.2018 um 11:18 schrieb Christofer Dutz :
>
> Hi Sebatian,
>
> ok that was new to me ... now all we have to d
chrisdutz opened a new pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub an
Hi Sebatian,
ok that was new to me ... now all we have to do, is to find out where it gets
archived to ;-)
But still we should keep decisions here on the list.
Chris
Am 30.08.18, 10:47 schrieb "Sebastian Rühl"
:
Hi Chris,
Actually I have invited the @asfarchivebot to the channe
Hi Sebastian,
Yeah ... I thought that we last removed JUnit5 again as it was completely
buggy, but having now read some "Yeah till the latest releases it really
sucked, but now it works fine" I thought, why not allow it and we'll see how it
works. I wouldn't propose to migrate everything howeve
Hi Chris,
[1] no need to supply a text to „ PlcInvalidFieldException“ as it only requires
you to supply the field name.
[2] using junit5 for parameterd tests seems to be a big relief :)
You should add a Pull-Request with WIP: (work in progress fix) so we can add
remarks like above inline as the
Hi Chris,
Actually I have invited the @asfarchivebot to the channel couple days ago as
described (and required) in #general so I would guess everything gets archived
now.
Sebastian
> Am 30.08.2018 um 10:03 schrieb Christofer Dutz :
>
> Hi all,
>
> But we should keep in mind, that slack is no
Hi all,
especially @Julian ... could you please have a look at that I did with the
S7Field [1]?
Also there is a unit-test that should allow adding more statements and testing
everything is working ok [2].
Does this match your idea on [3]? Looking at your addresses, I think that I
might have no
Hi all,
But we should keep in mind, that slack is not persisted.
So we should use it as quick communication channel, but remember to bring
important stuff back to this list ...
Even if this means writing summary emails that aggregate what's been discussed.
No need to bring chit-chat or "how do
22 matches
Mail list logo
