Re: [DISCUSS] Send Code Review mails to commits@

+1 Von meinem iPhone gesendet > Am 29.03.2019 um 13:44 schrieb Julian Feinauer : > > Hi all, > > as we all got a lot of spam from Sebastians Code Review and my changes we had > a short discussion in the Slack channel. > I suggest to send these mails to the commits@ mailing list or probably >

Re: Podling Report Reminder - April 2019

Weil submit as soon as I'm back from my short holiday trip tomorrow. Chris Outlook für Android herunterladen From: jmcl...@apache.org Sent: Saturday, March 30, 2019 12:06:41 AM To: d...@plc4x.incubator.apache.org Subject: Podling Report Re

Podling Report Reminder - April 2019

Dear podling, This email was sent by an automated system on behalf of the Apache Incubator PMC. It is an initial reminder to give you plenty of time to prepare your quarterly board report. The board meeting is scheduled for Wed, 17 April 2019, 10:30 am PDT. The report for your podling will form a

Re: [DISCUSS] Send Code Review mails to commits@

Hi, +1 to that. Thanks, Justin

Re: [DISCUSS] Send Code Review mails to commits@

I agree ... However I still think a lot of discussion just gets parked where no one will ever read it. But this is a problem all Apache projects have. I will definitely try to figure a way that we might be able to extract aggregations ... Chris Outlook für Android herunt

Re: [DISCUSS] Send Code Review mails to commits@

+1 Am 29.03.19, 13:42 schrieb "Julian Feinauer" : Hi all, as we all got a lot of spam from Sebastians Code Review and my changes we had a short discussion in the Slack channel. I suggest to send these mails to the commits@ mailing list or probably another one (which I don’t us

Re: [DISCUSS] Send Code Review mails to commits@

Yep lets do that... > Am 29.03.2019 um 13:42 schrieb Julian Feinauer : > > Hi all, > > as we all got a lot of spam from Sebastians Code Review and my changes we had > a short discussion in the Slack channel. > I suggest to send these mails to the commits@ mailing list or probably > another one

[DISCUSS] Send Code Review mails to commits@

Hi all, as we all got a lot of spam from Sebastians Code Review and my changes we had a short discussion in the Slack channel. I suggest to send these mails to the commits@ mailing list or probably another one (which I don’t usually read that well), What do you think? Julian

[GitHub] [incubator-plc4x] sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method

sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270390474 ## File path: plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/connection/AbstractPlcConnection.jav

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #57: Feature/plc4 x 108 ping method

JulianFeinauer commented on a change in pull request #57: Feature/plc4 x 108 ping method URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270381273 ## File path: plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/connection/AbstractPlcConne

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #57: Feature/plc4 x 108 ping method

JulianFeinauer commented on a change in pull request #57: Feature/plc4 x 108 ping method URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270379357 ## File path: plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/connection/AbstractPlcConne

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #57: Feature/plc4 x 108 ping method

JulianFeinauer commented on a change in pull request #57: Feature/plc4 x 108 ping method URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270379294 ## File path: plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/connection/AbstractPlcConne

[GitHub] [incubator-plc4x] sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method

sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270367844 ## File path: plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/connection/AbstractPlcConnection.jav

[GitHub] [incubator-plc4x] sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method

sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270368233 ## File path: plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/connection/AbstractPlcConnection.jav

[GitHub] [incubator-plc4x] sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method

sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270366988 ## File path: plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/connection/AbstractPlcConnection.jav

[GitHub] [incubator-plc4x] sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method

sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270367740 ## File path: plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/connection/AbstractPlcConnection.jav

[GitHub] [incubator-plc4x] sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method

sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270368552 ## File path: plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/connection/AbstractPlcConnection.jav

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #57: Feature/plc4 x 108 ping method

JulianFeinauer commented on a change in pull request #57: Feature/plc4 x 108 ping method URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270356482 ## File path: plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/connection/AbstractPlcConne

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #57: Feature/plc4 x 108 ping method

JulianFeinauer commented on a change in pull request #57: Feature/plc4 x 108 ping method URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270356174 ## File path: plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/connection/AbstractPlcConne

[GitHub] [incubator-plc4x] sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method

sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270348761 ## File path: plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/connection/AbstractPlcConnection.jav

[GitHub] [incubator-plc4x] sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method

sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270349354 ## File path: plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/connection/AbstractPlcConnection.jav

Re: Reconnect of driver 2

Hey Gunter, one more notice. I just submitted the PR with your ping method, which seems to work pretty well for S7 and Modbus-tcp as we checked. If you want to use the pool, which basically works like a JDBC Connection pool, you can use something like this snippet: ``` private static PooledPlc

[GitHub] [incubator-plc4x] JulianFeinauer opened a new pull request #57: Feature/plc4 x 108 ping method

JulianFeinauer opened a new pull request #57: Feature/plc4 x 108 ping method URL: https://github.com/apache/incubator-plc4x/pull/57 I implemented a ping() method based on Gunters code (in fact it is Gunters code) and "redirected" the isConnected method there. I extended the NettyPlcConn

Re: Reconnect of driver 2

Thanks for the fast reply. So I suggest to keep the Ping also fort he S7 by default, until we find something which is really always there (like querying the SZL). Do you agree? Am 29.03.19, 09:59 schrieb "Gunther Gruber" : Hi Julian, i am not sure about this. according to documenta

Re: Reconnect of driver 2

Hi Julian, i am not sure about this. according to documentation this has to be enabled explicitly. https://support.industry.siemens.com/cs/document/87149213/how-do-you-define-the-true-constant-in-the-lad-fdb-editor-in-step-7-(tia-portal)-?dti=0&lc=en-AT. Gunther On 29.03.19 09:17, Julian Fein

Re: Reconnect of driver 2

Oh and to your original question, yes, this Port thing should be given by the Driver itself as "default implementation" of this ping method which can be overridden, as in the S7 case. Am 29.03.19, 09:35 schrieb "Christofer Dutz" : Hi guys, Just a question, as I'm currently traveli

Re: Reconnect of driver 2

Hi, first, I created a issue for this (https://issues.apache.org/jira/browse/PLC4X-108) and second, yes, I agree. I want to prepare a Branch where I implement the snippets from Gunter with the things bespoken. But, thinking again about it, I dislike the contract of the method as "either comple

[jira] [Created] (PLC4X-108) Add ping() method to PlcConnection

Julian Feinauer created PLC4X-108: - Summary: Add ping() method to PlcConnection Key: PLC4X-108 URL: https://issues.apache.org/jira/browse/PLC4X-108 Project: Apache PLC4X Issue Type: New Featu

Re: Reconnect of driver 2

Hi guys, Just a question, as I'm currently traveling and haven't had my computer open for the past few days. On the API side we were thinking of a no-args void method in the PlcConnection that fires exceptions ... Correct? The up, port and stuff like that should be provided by the connection i

Re: Reconnect of driver 2

Hi Gunter, I am currently looking through your code and wanted to prepare a commit, so just a question about the s7 implementation. Is the M1.2 a generally available bit or is this something more specific to your use cases? I know that the M are the Markers and generally all Boolean, but can the