Re: [MODBUS][DISCUSS] Improving handling of datatypes ...

2020-09-08 Thread Ben Hutcheson
Hi Chris, I'm not sure I follow your last email, I have pushed a commit to *hutcheb:Feature/ModbusDataType , *which includes some of the changes I've proposed. 1) Within build-utils/language-java/src/main/resources/templates/java/data

Re: [MODBUS][DISCUSS] Improving handling of datatypes ...

2020-09-08 Thread Christofer Dutz
Hi Ben, well the PlcValue types are based on the types used in the language they are used in. In PLC4C, which supports signed and unsigned types, I implemented them differently. Initially I thought that if the PlcValues would simply have a byte-array and a type, then it would be universal ...

Re: [MODBUS][DISCUSS] Improving handling of datatypes ...

2020-09-08 Thread Ben Hutcheson
Hi Chris, The case where PLC data types are mapped to 16 bit registers isn't a special case, as the Modbus protocol only supports 16 bit registers but it doesn't specify what format the data should be in,any PLC data type can be mapped to these and then passed over Modbus. It would definitely be h

Re: [MODBUS][DISCUSS] Improving handling of datatypes ...

2020-09-08 Thread Christofer Dutz
Hi Ben ... Sorry for my email... I should really finish reading before replying :-( About your suggestion to add it to the type to the ModbusField ... I agree. But I would simply extend the Address string the same way the TIA addresses were extended. Cause the problem I'm seeing is that for th

Re: [MODBUS][DISCUSS] Improving handling of datatypes ...

2020-09-08 Thread Christofer Dutz
Hi Ben, if you have followed the latest discussions here ... currently the modbus protocol supports 16bit integer values for registers and Boolean values for coils. The protocol doesn't directly support anything else. However I have seen that vendors use arrays of registers to support higher le

Re: [MODBUS][DISCUSS] Improving handling of datatypes ...

2020-09-08 Thread Ben Hutcheson
Hi, Looking at the example I had with the hello-world-write example trying to write a String to the Modbus protocol. ava -jar plc4j-hello-world-plc4x-write-0.8.0-SNAPSHOT-uber-jar.jar --connection-string modbus://127.0.0.1:5467 --field-addresses 40010 -field-values 32000 The value 32000 then get

[VOTE] Apache PLC4X Build-Tools Code-Generation 1.3.0 RC1

2020-09-08 Thread Christofer Dutz
Apache PLC4X Build-Tools Code-Generation 1.3.0 has been staged under [2] and it’s time to vote on accepting it for release. All Maven artifacts are available under [1]. Voting will be open for 72hr. A minimum of 3 binding +1 votes and more binding +1 than binding -1 are required to