[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper

2019-03-06 Thread GitBox
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262821317 ## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/ResultHandler.java #

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper

2019-03-06 Thread GitBox
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262823035 ## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/TriggeredScr

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper

2019-03-06 Thread GitBox
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262821146 ## File path: plc4j/utils/scraper/pom.xml ## @@ -65,6 +65,11 @@ plc4j-connection-pool

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper

2019-03-06 Thread GitBox
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262827655 ## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/triggerhandl

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper

2019-03-06 Thread GitBox
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262821901 ## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/ScraperImpl.java ##

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper

2019-03-06 Thread GitBox
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262827260 ## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/triggerhandl

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper

2019-03-06 Thread GitBox
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262823550 ## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/TriggeredScr

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper

2019-03-06 Thread GitBox
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262822210 ## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/config/JobConfigurationImpl.j

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper

2019-03-06 Thread GitBox
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262822363 ## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/config/ScraperConfigurationBu

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper

2019-03-06 Thread GitBox
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262822036 ## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/ScraperTaskImpl.java ###

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper

2019-03-06 Thread GitBox
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262821681 ## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/Scraper.java ## @@

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper

2019-03-06 Thread GitBox
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262826904 ## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/triggerhandl

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper

2019-03-06 Thread GitBox
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262821540 ## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/ScrapeJob.java ## @

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper

2019-03-06 Thread GitBox
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262827199 ## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/triggerhandl

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper

2019-03-06 Thread GitBox
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262827288 ## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/triggerhandl

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper

2019-03-06 Thread GitBox
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262822320 ## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/config/ScraperConfiguration.j

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper

2019-03-06 Thread GitBox
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262827814 ## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/triggerhandl

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper

2019-03-06 Thread GitBox
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262822739 ## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/config/triggeredscraper/Trigg

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper

2019-03-06 Thread GitBox
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262821820 ## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/Scraper.java ## @@

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper

2019-03-06 Thread GitBox
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262822268 ## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/config/JobConfigurationImplBu

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper

2019-03-06 Thread GitBox
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262826702 ## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/TriggeredScr

[GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper

2019-03-06 Thread GitBox
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r263054168 ## File path: plc4j/utils/scraper/pom.xml ## @@ -65,6 +65,11 @@ plc4j-connection-pool