JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-410192303
Okay, perfect, than I'm fine.
This is an automated message from the Apach
JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-410188201
Of course I can drop the PR (I think the discussion was more viable than
these 3 lines of code).
And the Plans than that you add the fu
JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-410172284
@chrisdutz I guess due to my partial scala background I totally ignore Javas
Completable futures as superior and thus didnt think about us
JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-409963436
@sruehl my understanding is that netty avoids a scenario where one uses the
event loop executors threads for blocking and thus, risks a de
JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-409958048
@chrisdutz your fixes in the master made it work for me also.
As I found a solution to avoid the blocking exception in the meanwhile I
JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-409882977
I incorporated fixes for all comments and tried to fix the failing IT (how
can i run them locally?).
As the close in the IT throws a NP
