[RESULT][VOTE] Apache PLC4X Build-Tools Code-Generation 1.1.0 RC2

2020-01-08 Thread Julian Feinauer
Hi all, the vote closes and the result is: 3 binding +1 and 1 non-binding +1 with no further votes. So, the RC1 is accepted. Thanks all for participating in the Vote. I will continue to finish the publication process. Thanks! Julian

Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.1.0 RC2

2020-01-06 Thread Julian Feinauer
Hi, my vote is +1 (binding). I did: - Checkout all sources - Verify Hash and Signatures - Checked all files (README, RELEASE_NOTES, ...); Minor issue: year in NOTICE not updated to 2020 - Performed mvn clean install without issues - No unexpected binaries - No maven wrapper jar! - No files found

Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.1.0 RC2

2020-01-06 Thread Justin Mclean
HI, +1 (binding) but the NOTICE year still needs updating. I checked: - signatures and hashes are fine - LICENSE is OK - NOTICE still need year updating - No unexpected binary files in the release - All source files have ASF headers - Can compile from source Thanks, Justin

Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.1.0 RC2

2020-01-05 Thread Christofer Dutz
+1 (binding) However found two minor issues (year in the NOTICE file and the missing "apache-" prefix on the source files) Chris I checked: - Signatures: OK - Hashes: OK - Name: The files should have the "apache-" prefix, I think: Not OK (but minor as this can be changed without modifying the

Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.1.0 RC2

2020-01-05 Thread Julian Feinauer
Thank you very much Niklas! Julian From: Niklas Merz Sent: Sunday, January 5, 2020 12:00:53 PM To: dev@plc4x.apache.org Subject: Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.1.0 RC2 I vote +1 (non-binding) I did: * check signature and hash * check

Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.1.0 RC2

2020-01-05 Thread Niklas Merz
I vote +1 (non-binding) I did: * check signature and hash * check files for license notice headers (Minor issue NOTICE file copyright not updated) manually * check all files by running apache-rat-0.12 for headers with successfulloutput * found no binaries :-) * build successfully from instructions

[VOTE] Apache PLC4X Build-Tools Code-Generation 1.1.0 RC2

2020-01-05 Thread Julian Feinauer
Hi folks, as I uploaded the wrong jars (with the wrapper jar in it) I hereby reopen the Vote with RC2. Note that nothing changed with the git tags and hashes (same commit still) and staging repo only the staged files are different. Apache PLC4X Build-Tools Code-Generation 1.1.0 has been staged