[Bug 66532] [PATCH] Improve performance of SheetDataWriter

2023-03-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66532 PJ Fanning changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Bug 66532] [PATCH] Improve performance of SheetDataWriter

2023-03-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66532 --- Comment #4 from Matthias Raschhofer --- Thank you for your comments. I'm happy to use git, however I thought it was readonly and I should provide patches here. I opened a pull request in git (https://github.com/apache/poi/pull/443). I

[Bug 66532] [PATCH] Improve performance of SheetDataWriter

2023-03-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66532 --- Comment #3 from Matthias Raschhofer --- Created attachment 38525 --> https://bz.apache.org/bugzilla/attachment.cgi?id=38525=edit Benchmark The attached file contains a benchmark comparing the performance of the proposed patch against

[Bug 66532] [PATCH] Improve performance of SheetDataWriter

2023-03-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66532 --- Comment #2 from PJ Fanning --- https://github.com/apache/poi/pull/405 is an unreleased perf change that may improve perf time of existing code. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 66532] [PATCH] Improve performance of SheetDataWriter

2023-03-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66532 --- Comment #1 from PJ Fanning --- It's hard to read this patch on my phone but a quick look makes me think there is a bug with use of string length - the number of chars as opposed the number of codepoints. I'm very reluctant to take this