Re: [PR] fix for bug63189 [poi]

2024-04-18 Thread via GitHub
ohkwon79 commented on code in PR #617: URL: https://github.com/apache/poi/pull/617#discussion_r1571561441 ## poi-ooxml/src/test/java/org/apache/poi/openxml4j/opc/TestRelationships.java: ## @@ -323,10 +323,10 @@ private void assert_50154(OPCPackage pkg) throws Exception {

Build failed in Jenkins: POI ยป POI-DSL-1.8 #1063

2024-04-18 Thread Apache Jenkins Server
See Changes: -- [...truncated 24.60 KB...] at hudson.FilePath$FileCallableWrapper.call(FilePath.java:3616) at

Re: [PR] fix for bug63189 [poi]

2024-04-18 Thread via GitHub
ohkwon79 commented on code in PR #617: URL: https://github.com/apache/poi/pull/617#discussion_r1571551590 ## poi-ooxml/src/test/java/org/apache/poi/openxml4j/opc/TestRelationships.java: ## @@ -323,10 +323,10 @@ private void assert_50154(OPCPackage pkg) throws Exception {

Re: [PR] fix for bug63189 [poi]

2024-04-18 Thread via GitHub
ohkwon79 commented on code in PR #617: URL: https://github.com/apache/poi/pull/617#discussion_r1571521239 ## poi-ooxml/src/main/java/org/apache/poi/ooxml/POIXMLDocumentPart.java: ## @@ -18,12 +18,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more import

Re: [PR] fix for bug63189 [poi]

2024-04-18 Thread via GitHub
ohkwon79 commented on code in PR #617: URL: https://github.com/apache/poi/pull/617#discussion_r1571521145 ## poi-ooxml/src/main/java/org/apache/poi/ooxml/HyperlinkRelationship.java: ## @@ -0,0 +1,29 @@ +package org.apache.poi.ooxml; Review Comment: Done -- This is an

Re: [PR] fix for bug63189 [poi]

2024-04-18 Thread via GitHub
pjfanning commented on code in PR #617: URL: https://github.com/apache/poi/pull/617#discussion_r1571420481 ## poi-ooxml/src/main/java/org/apache/poi/ooxml/POIXMLDocumentPart.java: ## @@ -18,12 +18,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] Bump bouncyCastleVersion from 1.78 to 1.78.1 [poi]

2024-04-18 Thread via GitHub
dependabot[bot] commented on PR #624: URL: https://github.com/apache/poi/pull/624#issuecomment-2065126041 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by

Re: [PR] Bump bouncyCastleVersion from 1.78 to 1.78.1 [poi]

2024-04-18 Thread via GitHub
asfgit closed pull request #624: Bump bouncyCastleVersion from 1.78 to 1.78.1 URL: https://github.com/apache/poi/pull/624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Bump bouncyCastleVersion from 1.78 to 1.78.1 [poi]

2024-04-18 Thread via GitHub
dependabot[bot] opened a new pull request, #624: URL: https://github.com/apache/poi/pull/624 Bumps `bouncyCastleVersion` from 1.78 to 1.78.1. Updates `org.bouncycastle:bcpkix-jdk18on` from 1.78 to 1.78.1 Commits See full diff in

Re: [PR] fix for bug63189 [poi]

2024-04-18 Thread via GitHub
pjfanning commented on PR #617: URL: https://github.com/apache/poi/pull/617#issuecomment-2063623429 Thanks. I'm currently travelling but will have a look in a few days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] fix for bug63189 [poi]

2024-04-18 Thread via GitHub
ohkwon79 commented on PR #617: URL: https://github.com/apache/poi/pull/617#issuecomment-2063404030 I added HyperlinkRelationship and created a fix using it. Additionally, I added implementations of the following interfaces: