Re: [DISCUSS] PIP-186: Introduce two phase deletion protocol based on system topic

2022-08-14 Thread Yan Zhao
Good idea. > Good idea. I suggest the naming endings with `Seconds` like > sendDelayOfTwoPhaseDeletionInSeconds,` > reconsumeLaterOfTwoPhaseDeletionInSeconds`. > >private int sendDelaySecondsOfTwoPhaseDeletion = 60; > >private int reconsumeLaterSecondsOfTwoPhaseDeletion = 600;

Re: [DISCUSS] Switch to the Temurin JDK in the Docker image

2022-08-14 Thread Zixuan Liu
Thank Qiang for your explanation! Qiang Huang 于2022年8月14日周日 12:15写道: > LGTM. They are very similar. > The OpenJDK provides source-code, and the Temurin JDK provides builds of > the source code. > I would like to point out that they have different licenses. > - The OpenJDK implementation is

Re: [DISCUSS] Allow the producer to connect to the topic with producer_request_hold backlog policy

2022-08-14 Thread Qiang Zhao
Great idea, Michael > 1. A new producer connecting to a topic that has exceeded its quota. > This case is trivial because the broker tells the producer it is > connected but it cannot send any messages (i.e. producer_ready=false), > and the client holds the producer's future until the broker

Re: [DISCUSS] Message redeliveryCount semantics and DLQ

2022-08-14 Thread PengHui Li
I support this motivation. We should avoid any cases which might break the at-least-one delivery semantic from the user's perspective. Thanks, Penghui On Thu, Aug 11, 2022 at 1:36 PM Michael Marshall wrote: > Hi Pulsar Community, > > In Pulsar 2.5.0, the semantics for a message's

Re: [VOTE] Pulsar Release 2.8.4 Candidate 1

2022-08-14 Thread Qiang Huang
Got it. Thx. Yunze Xu 于2022年8月14日周日 23:22写道: > You can see > https://lists.apache.org/thread/rg1g083c06ozm5go6zo1jophg9y9zl2f > for more details about the LTS release. > > Thanks, > Yunze > > > > > > 2022年8月14日 11:00,Qiang Huang 写道: > > > > +1 (non-binding) > > Is 2.8.4 a long term support

[GitHub] [pulsar-site] SignorMercurio opened a new pull request, #161: Add execute permission on pulsar-config-doc-gen.sh

2022-08-14 Thread GitBox
SignorMercurio opened a new pull request, #161: URL: https://github.com/apache/pulsar-site/pull/161 Add execute permission on pulsar-config-doc-gen.sh. @urfreespace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar-site] urfreespace merged pull request #160: Automate config docs generation

2022-08-14 Thread GitBox
urfreespace merged PR #160: URL: https://github.com/apache/pulsar-site/pull/160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-site] urfreespace commented on pull request #160: Automate config docs generation

2022-08-14 Thread GitBox
urfreespace commented on PR #160: URL: https://github.com/apache/pulsar-site/pull/160#issuecomment-1214503274 thanks @SignorMercurio, good job, LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [Discuss] PIP 198: Standardize PR Naming Convention using GitHub Actions

2022-08-14 Thread tison
To clarify, I don't have a strong feeling about either convention. According to the reason above, I'd prefer the Angular convention, while +0 for the customized convention. Best, tison. tison 于2022年8月14日周日 23:40写道: > Technically, the regexp of both conventions are: > > * Angular convention -

Re: [Discuss] PIP 198: Standardize PR Naming Convention using GitHub Actions

2022-08-14 Thread tison
Technically, the regexp of both conventions are: * Angular convention - /^(\w*)(?:\((.*)\))?!?: (.*)$/ * Customized conventions - /^\[(\w*)\](?:\[(.*)\])?: (.*)$/ So, there're technically equal from the customized convention perspective, or the Angular convention contains all expressiveness of

Re: [VOTE] Pulsar Release 2.8.4 Candidate 1

2022-08-14 Thread Yunze Xu
You can see https://lists.apache.org/thread/rg1g083c06ozm5go6zo1jophg9y9zl2f for more details about the LTS release. Thanks, Yunze > 2022年8月14日 11:00,Qiang Huang 写道: > > +1 (non-binding) > Is 2.8.4 a long term support release? > > Yunze Xu 于2022年8月12日周五 16:20写道: > >> This is the first

[GitHub] [pulsar-site] SignorMercurio commented on pull request #160: Automate config docs generation

2022-08-14 Thread GitBox
SignorMercurio commented on PR #160: URL: https://github.com/apache/pulsar-site/pull/160#issuecomment-1214340328 In addition, a minor fix of an old problem (#134, #142) is committed here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar-test-infra] tisonkun commented on a diff in pull request #56: avoid duplicate docbot comment

2022-08-14 Thread GitBox
tisonkun commented on code in PR #56: URL: https://github.com/apache/pulsar-test-infra/pull/56#discussion_r945234643 ## docbot/main.go: ## @@ -311,6 +311,11 @@ func (a *Action) onPullRequestOpenedOrEdited() error { // Add missing label if