Re: [DISCUSS] Support `brokerMaxConnectionsPerIp` on Pulsar proxy

2022-08-15 Thread Michael Marshall
Good idea, it makes sense to me to add this to the proxy. > BTW, are there any side effects from the implementation? Reading through the code from https://github.com/apache/pulsar/pull/10754, it looks like the cost is minimal. The broker maintains counters for each IP address, and they are

[VOTE] PIP-191: Support batched message using entry filter

2022-08-15 Thread Anon Hxy
Dear Community, I'd like to start a VOTE on "PIP-191: Support batched message using entry filter." The proposal can be read at [0] and the discussion thread is available at [1] Voting will stay open for at least 48h. [0] https://github.com/apache/pulsar/issues/16680 [1]

Re: [DISCUSS] Support `brokerMaxConnectionsPerIp` on Pulsar proxy

2022-08-15 Thread Haiting Jiang
Sounds good. It's good for server stability. BTW, are there any side effects from the implementation? On Tue, Aug 16, 2022 at 10:33 AM mattison chao wrote: > Hi, All > > Pulsar has the `brokerMaxConnectionsPerIp` configuration at the > broker, we can use it to limit the maximum connections per

Re: Questions about the release process

2022-08-15 Thread Haiting Jiang
Hi Dave, > Just remove that command. Having two servers should be enough. Agree, I have removed it. > Release candidates should not be made by a bot. Releases must be verified by building them from source. See https://www.apache.org/legal/release-policy.html#owned-controlled-hardware Thanks

Re: [DISCUSSION] PiP196 TransactionBuffer Multiple-snapshots

2022-08-15 Thread Yubiao Feng
Hi Xiangying >> Can the sequence id generation strategy be added to the proposal? > think it's an implementation detail that shouldn't be exposed to the user at all. OK. Thanks Yubiao Feng On Mon, Aug 15, 2022 at 8:11 PM Xiangying Meng wrote: > Hi, yubiao, > I think it's an implementation

[GitHub] [pulsar-site] urfreespace merged pull request #166: fix rest api error

2022-08-15 Thread GitBox
urfreespace merged PR #166: URL: https://github.com/apache/pulsar-site/pull/166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [DISCUSS] Pulsar 3.0 brainstorming: Going beyond PIP-45 Pluggable metadata interface

2022-08-15 Thread Lari Hotari
Bumping up this thread. -Lari pe 20. toukok. 2022 klo 1.57 Lari Hotari kirjoitti: > Hi all, > > I started writing this email as feedback to "PIP-157: Bucketing topic > metadata to allow more topics per namespace" [3]. > This email expanded to cover some analysis of "PIP-45: Pluggable metadata

[DISCUSS] Support `brokerMaxConnectionsPerIp` on Pulsar proxy

2022-08-15 Thread mattison chao
Hi, All Pulsar has the `brokerMaxConnectionsPerIp` configuration at the broker, we can use it to limit the maximum connections per IP. The original motivation and PR here: https://github.com/apache/pulsar/pull/10754 IMO, we can also apply it to pulsar-proxy, because when a large number of

[GitHub] [pulsar-site] urfreespace merged pull request #165: fix rest api page render error

2022-08-15 Thread GitBox
urfreespace merged PR #165: URL: https://github.com/apache/pulsar-site/pull/165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-manager] rdhabalia merged pull request #482: Removing conflicting dependencies

2022-08-15 Thread GitBox
rdhabalia merged PR #482: URL: https://github.com/apache/pulsar-manager/pull/482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-test-infra] tisonkun commented on pull request #56: avoid duplicate docbot comment

2022-08-15 Thread GitBox
tisonkun commented on PR #56: URL: https://github.com/apache/pulsar-test-infra/pull/56#issuecomment-1215319343 ping @maxsxu @michaeljmarshall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: Questions about the release process

2022-08-15 Thread Dave Fisher
> On Aug 15, 2022, at 3:30 AM, Haiting Jiang wrote: > >> Maybe we'd better move the release process doc and validation doc >> to the codebase, not the wiki pages. > > IMO, we can move all contributor documentation and committers documentation > to codebase. > One example is that

Re: Questions about the release process

2022-08-15 Thread Dave Fisher
> On Aug 15, 2022, at 4:09 AM, Yunze Xu wrote: > >> One example is that `pool.sks-keyservers.net` in [1] seems not available > anymore, but I am not that confident enough to edit it directly. > > Yeah. It’s not available in my env as well. I made some changes recently, > but I’m also not

Re: [DISCUSSION] PiP196 TransactionBuffer Multiple-snapshots

2022-08-15 Thread Xiangying Meng
Hi, yubiao, I think it's an implementation detail that shouldn't be exposed to the user at all. Yours sincerely, Xiangying Meng On Mon, Aug 15, 2022 at 8:02 PM Yubiao Feng wrote: > Hi Xiangying > > Thank you for your reply. Sorry, I have one more question: > > > If these operations are failed

Re: [DISCUSSION] PiP196 TransactionBuffer Multiple-snapshots

2022-08-15 Thread Yubiao Feng
Hi Xiangying Thank you for your reply. Sorry, I have one more question: > If these operations are failed at operation 2, the old snapshots will be covered by the new large snapshot when compact due to they have the same sequence ID. Can the sequence id generation strategy be added to the doc?

Re: Questions about the release process

2022-08-15 Thread Yunze Xu
> One example is that `pool.sks-keyservers.net` in [1] seems not available anymore, but I am not that confident enough to edit it directly. Yeah. It’s not available in my env as well. I made some changes recently, but I’m also not sure about this point. > I think we can consider using a BOT

Re: [DISCUSSION] PiP196 TransactionBuffer Multiple-snapshots

2022-08-15 Thread Xiangying Meng
Hi, yubiao, First of all, thanks for the attention and questions. Then for your three questions: 1. > Does the merge take place in memory or in BK? The snapshot will merge in BK. For specific details, you can see detailed instructions in the* ### Merge snapshot section.* 2. >How do we ensure the

Re: [Discuss] PIP 198: Standardize PR Naming Convention using GitHub Actions

2022-08-15 Thread Yu
Hi team, Feel free to choose your desired convention **before EOD 8/16 (UTC +8)**. We'll close this discussion and move to the next topic after that time. Thank you! Yu and mangoGoForward On Mon, Aug 15, 2022 at 6:27 PM Yu wrote: > Hi tison, > > Thanks for your suggestions! > > > But

Re: Questions about the release process

2022-08-15 Thread Haiting Jiang
> Maybe we'd better move the release process doc and validation doc > to the codebase, not the wiki pages. IMO, we can move all contributor documentation and committers documentation to codebase. One example is that `pool.sks-keyservers.net` in [1] seems not available anymore, but I am not that

[GitHub] [pulsar-site] SignorMercurio opened a new pull request, #164: Remove exec command in pulsar-config-doc-gen.sh

2022-08-15 Thread GitBox
SignorMercurio opened a new pull request, #164: URL: https://github.com/apache/pulsar-site/pull/164 Remove exec command in pulsar-config-doc-gen.sh so that the docs can be successfully generated. @urfreespace -- This is an automated message from the Apache Git Service. To respond to the

Re: [Discuss] PIP 198: Standardize PR Naming Convention using GitHub Actions

2022-08-15 Thread Yu
Hi tison, Thanks for your suggestions! > But following the Conventional Commits will ensure we can use the toolchain built around it, such as semantic release[1]. Our customized convention can use the semantic release tool as well. > Also, Conventional Commits have a standard to name a

[GitHub] [pulsar-site] urfreespace merged pull request #163: Fix non-existing directory in pulsar-config-doc-gen.sh

2022-08-15 Thread GitBox
urfreespace merged PR #163: URL: https://github.com/apache/pulsar-site/pull/163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-site] SignorMercurio opened a new pull request, #163: Fix non-existing directory in pulsar-config-doc-gen.sh

2022-08-15 Thread GitBox
SignorMercurio opened a new pull request, #163: URL: https://github.com/apache/pulsar-site/pull/163 Fix non-existing directory in pulsar-config-doc-gen.sh. @urfreespace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar-site] momo-jun commented on issue #146: Provide structural client overview page

2022-08-15 Thread GitBox
momo-jun commented on issue #146: URL: https://github.com/apache/pulsar-site/issues/146#issuecomment-1214767571 > For the feature matrix, it's mainly tracking feature points and whether it has a document entry. Once we add document to all those features, we may simply remove that matrix.

[GitHub] [pulsar-site] urfreespace merged pull request #162: Fix wrong path in pulsar-config-doc-gen.sh

2022-08-15 Thread GitBox
urfreespace merged PR #162: URL: https://github.com/apache/pulsar-site/pull/162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-site] SignorMercurio opened a new pull request, #162: Fix wrong path in pulsar-config-doc-gen.sh

2022-08-15 Thread GitBox
SignorMercurio opened a new pull request, #162: URL: https://github.com/apache/pulsar-site/pull/162 Fix wrong path in pulsar-config-doc-gen.sh. @urfreespace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [DISCUSSION] PiP196 TransactionBuffer Multiple-snapshots

2022-08-15 Thread Yubiao Feng
Hi Xiangying I think Multiple-snapshots for TB is a good idea. And I have these questions: > The number of the transactions in a snapshot can be configured, and we hope it is small, then we can merge the small snapshots into a large snapshot when it reaches a configured number. Does the merge

[GitHub] [pulsar-site] urfreespace merged pull request #161: Add execute permission on pulsar-config-doc-gen.sh

2022-08-15 Thread GitBox
urfreespace merged PR #161: URL: https://github.com/apache/pulsar-site/pull/161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: