[GitHub] [pulsar-test-infra] nodece commented on a diff in pull request #71: Improve comment messages

2022-09-15 Thread GitBox
nodece commented on code in PR #71: URL: https://github.com/apache/pulsar-test-infra/pull/71#discussion_r972578283 ## docbot/action.go: ## @@ -13,10 +13,7 @@ import ( ) const ( - MessageLabelMissing = `Please provide a correct documentation label for your PR.

[GitHub] [pulsar] Raunak-Agrawal edited a comment on the discussion: Need max redelivery count at message level.

2022-09-15 Thread GitBox
GitHub user Raunak-Agrawal edited a comment on the discussion: Need max redelivery count at message level. Can someone please help me with this? @michaeljmarshall GitHub link: https://github.com/apache/pulsar/discussions/17626#discussioncomment-3658798 This is an automatically sent

[GitHub] [pulsar] Raunak-Agrawal added a comment to the discussion: Need max redelivery count at message level.

2022-09-15 Thread GitBox
GitHub user Raunak-Agrawal added a comment to the discussion: Need max redelivery count at message level. Can someone please help me with this? GitHub link: https://github.com/apache/pulsar/discussions/17626#discussioncomment-3658798 This is an automatically sent email for

[GitHub] [pulsar] moweonlee added a comment to the discussion: Is there any kinds of processing interval or throttling in pulsar function ?

2022-09-15 Thread GitBox
GitHub user moweonlee added a comment to the discussion: Is there any kinds of processing interval or throttling in pulsar function ? Now I realize that IN-Rate of source topic is the main reason. The graph looks fine after I increase number of POD sto pull message from Kafka . GitHub link:

[GitHub] [pulsar-helm-chart] ThelonKarrde commented on pull request #284: Add nodeSelector to cluster initialize pod

2022-09-15 Thread GitBox
ThelonKarrde commented on PR #284: URL: https://github.com/apache/pulsar-helm-chart/pull/284#issuecomment-1248561460 @MarvinCai @michaeljmarshall ping here again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar-manager] rdhabalia merged pull request #488: Removing transitive dependencies for log4j

2022-09-15 Thread GitBox
rdhabalia merged PR #488: URL: https://github.com/apache/pulsar-manager/pull/488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [CI] Change to be made in Pulsar CI to mitigate CI resource consumption issues

2022-09-15 Thread Zixuan Liu
Hi Lari, This is a good idea, I agree with that. Once the committer added a "ready-to-test" label to a PR, then the contributor can run the Pulsar CI. Thanks, Zixuan Lari Hotari 于2022年9月15日周四 23:30写道: > On 2022/09/15 15:09:59 Yubiao Feng wrote: > > Hi Lari: > > > > That is really a good way.

Re: [CI] Change to be made in Pulsar CI to mitigate CI resource consumption issues

2022-09-15 Thread Lari Hotari
On 2022/09/15 15:09:59 Yubiao Feng wrote: > Hi Lari: > > That is really a good way. > I think it is possible to add another button to cancel the running task. > because after the user submits the PR, he finds other problems that need to > be fixed. In this case, he can cancel the task by himself.

Re: [CI] Change to be made in Pulsar CI to mitigate CI resource consumption issues

2022-09-15 Thread Yubiao Feng
Hi Lari: That is really a good way. I think it is possible to add another button to cancel the running task. because after the user submits the PR, he finds other problems that need to be fixed. In this case, he can cancel the task by himself. Hi tison: > we can start with all "authorized"

[GitHub] [pulsar-test-infra] nodece commented on pull request #71: Improve comment messages

2022-09-15 Thread GitBox
nodece commented on PR #71: URL: https://github.com/apache/pulsar-test-infra/pull/71#issuecomment-1248209711 > @nodece if adding , will not be shown in PR description and it's only visible to PR author, right? > > If yes, this is a good idea! You are right, this PR description

Re: [CI] Change to be made in Pulsar CI to mitigate CI resource consumption issues

2022-09-15 Thread Yunze Xu
Good explanation! I agree. Thanks, Yunze > On Sep 15, 2022, at 19:42, Lari Hotari wrote: > >> I’m a little confused about what will CI do in this case? I think the >> “ready-to-test” label should >> be removed in this case because the new code might not pass the tests. I >> thought the

Re: [CI] Change to be made in Pulsar CI to mitigate CI resource consumption issues

2022-09-15 Thread Lari Hotari
> I’m a little confused about what will CI do in this case? I think the > “ready-to-test” label should > be removed in this case because the new code might not pass the tests. I > thought the author > should request committers to add this label again after the tests passed in > his own repo.

Re: [CI] Change to be made in Pulsar CI to mitigate CI resource consumption issues

2022-09-15 Thread Yunze Xu
> If there are later changes in the PR after the "ready-to-test" label has been > added, we could simply let the Pulsar CI handle the builds. I’m a little confused about what will CI do in this case? I think the “ready-to-test” label should be removed in this case because the new code might not

Re: [CI] Change to be made in Pulsar CI to mitigate CI resource consumption issues

2022-09-15 Thread Lari Hotari
> In short, IIUC, each contributor should: > 1. Follow https://pulsar.apache.org/contributing/#ci-testing-in-your-fork to > 2. Paste the link of the same PR in contributor’s fork to the PR in Apache > repo > > Then a committer should run `/pulsarbot ready-to-test` after the PR in >

[GitHub] [pulsar] visortelle edited a comment on the discussion: Missing namespaces metrics

2022-09-15 Thread GitBox
GitHub user visortelle edited a comment on the discussion: Missing namespaces metrics For illustration, I have the following namespaces/topics hierarchy: https://user-images.githubusercontent.com/9302460/190370509-c8b77f4e-9720-4bd2-9249-3df0b582c19e.png;> For all topics listed on the

Re: [CI] Change to be made in Pulsar CI to mitigate CI resource consumption issues

2022-09-15 Thread Yunze Xu
Hi Lari, This proposal LGTM. But I have some questions about the details. In short, IIUC, each contributor should: 1. Follow https://pulsar.apache.org/contributing/#ci-testing-in-your-fork to 2. Paste the link of the same PR in contributor’s fork to the PR in Apache repo Then a committer

[GitHub] [pulsar-test-infra] Anonymitaet commented on pull request #71: Improve comment messages

2022-09-15 Thread GitBox
Anonymitaet commented on PR #71: URL: https://github.com/apache/pulsar-test-infra/pull/71#issuecomment-1247880547 @nodece if adding , will not be shown in PR description and it's only visible to PR author, right? If yes, this is a good idea! -- This is an automated message from

Re: [CI] Change to be made in Pulsar CI to mitigate CI resource consumption issues

2022-09-15 Thread Lari Hotari
> One more comment: you should take `/pulsarbot run-failure-checks` into > consideration. It's now triggered by any actors and signals a rerun on > behalf of @codelipenghui. Following your proposal I suggest this manner > should be restricted also. And it actually means that our committers should

[GitHub] [pulsar-test-infra] Anonymitaet commented on a diff in pull request #71: Improve comment messages

2022-09-15 Thread GitBox
Anonymitaet commented on code in PR #71: URL: https://github.com/apache/pulsar-test-infra/pull/71#discussion_r971791419 ## docbot/action.go: ## @@ -13,10 +13,7 @@ import ( ) const ( - MessageLabelMissing = `Please provide a correct documentation label for your PR.

[GitHub] [pulsar] visortelle edited a discussion: Missing namespaces metrics

2022-09-15 Thread GitBox
GitHub user visortelle edited a discussion: Missing namespaces metrics Hello. I have the following question: Let’s say I have two topics: - persistent://tenant-1/ns-1/to-1 - persistent://tenant-1/ns-2/to-2 For each of the topics, there is `pulsar-perf produce -mk random ` that runs more

Re: [CI] Change to be made in Pulsar CI to mitigate CI resource consumption issues

2022-09-15 Thread Lari Hotari
Thanks for the comment. The question isn't about trusting PRs. The CI resource consumption problem is also caused by current committer PRs. That's why it is necessary to handle all PRs in the same way. The benefit of the proposed solution is that we could decide to run some light checks

[GitHub] [pulsar] visortelle added a comment to the discussion: Missing namespaces metrics

2022-09-15 Thread GitBox
GitHub user visortelle added a comment to the discussion: Missing namespaces metrics There is defintely some activity in `tenant-1/ns-1` namespace, but I don't see it's metrics in `metrcsJson`.

[GitHub] [pulsar] visortelle edited a comment on the discussion: Missing namespaces metrics

2022-09-15 Thread GitBox
GitHub user visortelle edited a comment on the discussion: Missing namespaces metrics For illustration, I have the following namespaces/topics hierarchy: https://user-images.githubusercontent.com/9302460/190370509-c8b77f4e-9720-4bd2-9249-3df0b582c19e.png;> For all topics listed on the

[GitHub] [pulsar-test-infra] tisonkun commented on a diff in pull request #71: Improve comment messages

2022-09-15 Thread GitBox
tisonkun commented on code in PR #71: URL: https://github.com/apache/pulsar-test-infra/pull/71#discussion_r971766495 ## docbot/action.go: ## @@ -13,10 +13,7 @@ import ( ) const ( - MessageLabelMissing = `Please provide a correct documentation label for your PR.

[GitHub] [pulsar] visortelle added a comment to the discussion: Missing namespaces metrics

2022-09-15 Thread GitBox
GitHub user visortelle added a comment to the discussion: Missing namespaces metrics For illustration: https://user-images.githubusercontent.com/9302460/190370509-c8b77f4e-9720-4bd2-9249-3df0b582c19e.png;> For all topics listed on the screenshot, there is a running `pulsar-perf` with the

[GitHub] [pulsar] visortelle edited a discussion: Missing namespaces metrics

2022-09-15 Thread GitBox
GitHub user visortelle edited a discussion: Missing namespaces metrics Hello. I have the following question: Let’s say I have two topics: - persistent://tenant-1/ns-1/to-1 - persistent://tenant-1/ns-2/to-2 For each of the topics, there is pulsar-perf produce -mk random that runs more for

[GitHub] [pulsar] visortelle edited a discussion: Missing namespaces metrics

2022-09-15 Thread GitBox
GitHub user visortelle edited a discussion: Missing namespaces metrics Hello. I have the following question: Let’s say I have two topics: - persistent://tenant-1/ns-1/to-1 - persistent://tenant-1/ns-2/to-2 For each of the topics, there is pulsar-perf produce -mk random that runs more for

[GitHub] [pulsar] visortelle added a comment to the discussion: Missing namespaces metrics

2022-09-15 Thread GitBox
GitHub user visortelle added a comment to the discussion: Missing namespaces metrics Namespace level metrics are exactly what I want in this case. The problem is that in my case it shows metrics for not all namespaces. GitHub link:

Re: [CI] Change to be made in Pulsar CI to mitigate CI resource consumption issues

2022-09-15 Thread tison
One more comment: you should take `/pulsarbot run-failure-checks` into consideration. It's now triggered by any actors and signals a rerun on behalf of @codelipenghui. Following your proposal I suggest this manner should be restricted also. And it actually means that our committers should be more

Re: [CI] Change to be made in Pulsar CI to mitigate CI resource consumption issues

2022-09-15 Thread tison
Hi Lari, Thanks for starting this discussion. The overall proposal looks good and it's really great that you can spend some time on such a significant infrastructure. One comment here is that we can start with all "authorized" users to trigger the CI in the committer group instead of introducing

[GitHub] [pulsar] moweonlee edited a discussion: Is there any kinds of processing interval or throttling in pulsar function ?

2022-09-15 Thread GitBox
GitHub user moweonlee edited a discussion: Is there any kinds of processing interval or throttling in pulsar function ? My running pulsar function is consuming data from a pulsar topic which is actually connected to kafka then store it into another one after processing. By the way, I have

[GitHub] [pulsar] moweonlee created a discussion: Is there any kinds of processing interval or throttling in pulsar function.

2022-09-15 Thread GitBox
GitHub user moweonlee created a discussion: Is there any kinds of processing interval or throttling in pulsar function. My running pulsar function is consuming data from a pulsar topic which is actually connected to kafka then store it into another one after processing. By the way, I have

[GitHub] [pulsar-helm-chart] arnarg opened a new issue, #288: superUserRoles order is unpredictable

2022-09-15 Thread GitBox
arnarg opened a new issue, #288: URL: https://github.com/apache/pulsar-helm-chart/issues/288 **Describe the bug** When specifying multiple roles in `.Values.auth.superUsers` the values are converted to a comma-separated list by piping the dict through `values` and `join` in helm

[GitHub] [pulsar] gaozhangmin added a comment to the discussion: Missing namespaces metrics

2022-09-15 Thread GitBox
GitHub user gaozhangmin added a comment to the discussion: Missing namespaces metrics Use `brokerStats().getTopics();` instead. `brokerStats().getMetrics()` only shows namespace level metrics. GitHub link: https://github.com/apache/pulsar/discussions/17656#discussioncomment-3651927

[VOTE][PIP-206] Refresh different authentication data

2022-09-15 Thread Zixuan Liu
Hi all, Voting for https://github.com/apache/pulsar/issues/17517. Discussion thread: https://lists.apache.org/thread/0wz12m255t9xvzf4rtc69c8dlov12764 Thanks, Zixuan

[CI] Change to be made in Pulsar CI to mitigate CI resource consumption issues

2022-09-15 Thread Lari Hotari
Hi all, The GitHub Actions based Pulsar CI has been experiencing issues for multiple weeks. The condition is currently better, but the resource shortage issue remains. CI builds will take a long time to complete even after many optimizations have been made. There's a long email thread with some

[GitHub] [pulsar-test-infra] nodece commented on pull request #71: Improve comment messages

2022-09-15 Thread GitBox
nodece commented on PR #71: URL: https://github.com/apache/pulsar-test-infra/pull/71#issuecomment-1247671267 @Anonymitaet Good catch, we also use `` instead of `(Your PR changes impact docs and you will update later)`, what do you think? -- This is an automated message from the Apache

[GitHub] [pulsar-test-infra] nodece commented on a diff in pull request #71: Improve comment messages

2022-09-15 Thread GitBox
nodece commented on code in PR #71: URL: https://github.com/apache/pulsar-test-infra/pull/71#discussion_r971604182 ## docbot/action.go: ## @@ -13,10 +13,7 @@ import ( ) const ( - MessageLabelMissing = `Please provide a correct documentation label for your PR.