Re: [DISCUSS] PIP-279: Reformat property in generateResponseWithEntry

2023-06-25 Thread guo jiwei
+1 (binding) This is a bug and we need this fix. Regards Jiwei Guo (Tboy) On Wed, Jun 21, 2023 at 11:23 AM steven lu wrote: > # Motivation > > reformat property,for a http header name cannot contain the following > prohibited characters: =,;: \t\r\n\v\f > > for example: >

Re: [VOTE] PIP-278: Support pluggable topic compaction service

2023-06-25 Thread Yunze Xu
I have left some comments in the proposal so please hold this vote until the comments are addressed. Thanks, Yunze On Mon, Jun 26, 2023 at 10:47 AM wrote: > > +1 (binding) > > Best, > Mattison > On 26 Jun 2023 at 10:01 +0800, Cong Zhao , wrote: > > Hello, community: > > > > This thread is to

Re: [VOTE] PIP-278: Support pluggable topic compaction service

2023-06-25 Thread mattisonchao
+1 (binding) Best, Mattison On 26 Jun 2023 at 10:01 +0800, Cong Zhao , wrote: > Hello, community: > > This thread is to start a vote for PIP-278: Support pluggable topic > compaction service. > > Discussion thread: > https://lists.apache.org/thread/ox2bot3p9j9fydqkw3v5gt5twc8jslvd > > PIP PR:

[VOTE] PIP-278: Support pluggable topic compaction service

2023-06-25 Thread Cong Zhao
Hello, community: This thread is to start a vote for PIP-278: Support pluggable topic compaction service. Discussion thread: https://lists.apache.org/thread/ox2bot3p9j9fydqkw3v5gt5twc8jslvd PIP PR: https://github.com/apache/pulsar/pull/20624 Sincerely Cong Zhao

Re: [DISCUSS] Provide consistent concept around partitioned topic and topic partition/internal topic

2023-06-25 Thread Yunze Xu
I'd like to say "a partitioned topic is a topic that consists of multiple non-partitioned topics". It's better not to use the "internal topic" concept. Thanks, Yunze On Sun, Jun 25, 2023 at 4:31 PM Joo Hyuk Kim wrote: > > Hi community: > > Currently, it seems like there is no good definition of

Re: [DISCUSS] PIP-277: Clusters list API return clusters with local flag

2023-06-25 Thread PengHui Li
Hi Jiwei, Do you need to change the REST API? or will it just apply to the Admin CLI? If it requires REST API changes, you should also reflect them in the proposal. And yes, using the local and remote will be confusing because users can have multiple clusters without geo-replication. Maybe we

[DISCUSS] Provide consistent concept around partitioned topic and topic partition/internal topic

2023-06-25 Thread Joo Hyuk Kim
Hi community: Currently, it seems like there is no good definition of what "partitioned topic" and "non-partitioned topic" mean and some places topic partition and internal topic interchangeably. I would like to propose to vote (or discuss) to come up with solid definition of what composes

Re: [DISCUSS] PIP-277: Clusters list API return clusters with local flag

2023-06-25 Thread Zixuan Liu
+1, this is a good improvement. In the proposal, I don't suggest you append the `local` to the cluster name: 1. It will be confusing when the original cluster name includes the `local` name 2. In some cases, it is not easy to distinguish between local and remote clusters so I suggest we should