Re: [VOTE] PIP-373: Add a topic's system prop that indicates whether users have published TXN messages in before

2024-08-23 Thread Tao Jiuming
+1 nonbinding Yubiao Feng 于2024年8月23日 周五16:17写道: > Hi all > > I want to start a vote on PIP -373: add a topic's system prop that > indicates whether users have published TXN messages in before. > > Proposal link: https://github.com/apache/pulsar/pull/23210 > Discussion link: > https://lists.apach

Re: [DISCUSS] PIP-373: Add a topic's system prop that indicates whether users have published TXN messages in before

2024-08-23 Thread xiangying meng
Let me explain this solution further. We can determine whether this namespace has used transactions through the data of the system topic. If it has not been used, setting a global property is enough. If the newly created topics in this namespace use transactions, add a property with a value of true

Re: [DISCUSS] Replace default NONE_KEY in Key_Shared implementation with producer name and producer sequence number

2024-08-23 Thread Lari Hotari
Thanks for volunteering, Philipp! I think that this is a good candidate. This might not be the easiest to handle since it might require a PIP [1]. I'm currently doubting whether this needs a PIP or not. The benefit of making a PIP is that this decision gets properly documented. The key handlin

[DISCUSS] Replace default NONE_KEY in Key_Shared implementation with producer name and producer sequence number

2024-08-23 Thread Philipp D
Hi all, I am interested in contributing to Pulsar. I encountered the GitHub issue [feat] Replace the default NONE_KEY in Key_Shared implementation with producer name and producer sequence number and thought it might be a good candidate for me to star

Re: [DISCUSS] PIP-373: Add a topic's system prop that indicates whether users have published TXN messages in before

2024-08-23 Thread xiangying meng
Hi Yubiao If it's just for compatibility, wouldn't it be better to add a global property? There is no need to add it for every topic. Thanks On Fri, Aug 23, 2024 at 5:23 PM Yubiao Feng wrote: > > Hi Xiangying > > > Must we set the system property to > > false for topics that do not use > > trans

Re: [DISCUSS] PIP-373: Add a topic's system prop that indicates whether users have published TXN messages in before

2024-08-23 Thread Yubiao Feng
Hi Xiangying > Must we set the system property to > false for topics that do not use > transactions? It is needed because the `false` can be used to determine whether the topic was created before upgrading to the version that contains the current PIP or not, which is useful for compatibility supp

Re: [DISCUSS] PIP-373: Add a topic's system prop that indicates whether users have published TXN messages in before

2024-08-23 Thread xiangying meng
Hi yubiao Then return to your plan, must we set the system property to false for topics that do not use transactions? I understand that it is enough to only set the system properties of the topics that used the transaction. Thanks, Xiangying Meng On Fri, Aug 23, 2024 at 4:16 PM Yubiao Feng wrote

[VOTE] PIP-373: Add a topic's system prop that indicates whether users have published TXN messages in before

2024-08-23 Thread Yubiao Feng
Hi all I want to start a vote on PIP -373: add a topic's system prop that indicates whether users have published TXN messages in before. Proposal link: https://github.com/apache/pulsar/pull/23210 Discussion link: https://lists.apache.org/thread/7mblhyvsrw5zybo0gs5512xg8f9sm67v The vote will stay

Re: [DISCUSS] PIP-373: Add a topic's system prop that indicates whether users have published TXN messages in before

2024-08-23 Thread Yubiao Feng
Hi Xiangying > Since we can add data to the topic attribute, > why not directly put the > snapshot or snapshot segment position into > the topic position? Reason 1: - The rate of loading the topic is once many days - The rate of taking Transaction Buffer snapshot is per 5 seconds The changes you