Nice suggestion. I have change those parameters in the pip. It looks better now.
On 2023/05/15 13:21:06 PengHui Li wrote:
> It looks good to me.
>
> Just a minor suggestion about the name of the configuration.
>
> managedLedgerInfoCompressionSizeThreshold ->
>
It looks good to me.
Just a minor suggestion about the name of the configuration.
managedLedgerInfoCompressionSizeThreshold ->
managedLedgerInfoCompressionThresholdInBytes
managedCursorInfoCompressionSizeThreshold
-> managedCursorInfoCompressionThresholdInBytes
And is it better to introduce a
30 minutes is not enough time to read a pip :)
On Thu, 11 May 2023 at 19:04 lifepuzzlefun wrote:
> Hello Pulsar community,
>
> This thread is to start a PIP-270 Add config to set metadata size
> threshold for compression
>
>
> Discussion thread:
>
Hello lifepuzzlefun,
thanks for your proposal
I believe that it is too early to start a VOTE as the discussion has
not happened yet.
Side note: this change is small and it doesn't introduce breaking API
changes, I am not sure that we need a PIP for it.
Enrico
Il giorno gio 11 mag 2023 alle ore
Hello Pulsar community,
This thread is to start a PIP-270 Add config to set metadata size threshold for
compression
Discussion thread:
https://lists.apache.org/thread/6930c74m31rflrql9y3dpjmm0sbccqkb Issue:
https://github.com/apache/pulsar/issues/20307
Voting will be open for at least 48
