Re: Re: Re: Introducer Pulsar admin api to pulsar-client-go

2023-03-27 Thread Max Xu
Hi, Enrico, Thanks for your concerns. I suppose we'll initiate the PIP discussion thread soon. Welcome to keep following the current repo https://github.com/streamnative/pulsar-admin-go. Best, Max Xu On Mon, Mar 27, 2023 at 3:09 PM Enrico Olivelli wrote: > Eric, > > Il Lun 27 Mar 2023,

Re: Re: Re: Introducer Pulsar admin api to pulsar-client-go

2023-03-27 Thread Enrico Olivelli
Eric, Il Lun 27 Mar 2023, 07:44 Shen Eric ha scritto: > Hi Community, > > We want to announce and introduce the [Pulsar Admin Go Library]( > https://github.com/streamnative/pulsar-admin-go) which has been open > sourced and cut the first release. > > The original Pulsar Admin Go Library is from

RE: Re: Re: Introducer Pulsar admin api to pulsar-client-go

2023-03-26 Thread Shen Eric
Hi Community, We want to announce and introduce the [Pulsar Admin Go Library](https://github.com/streamnative/pulsar-admin-go) which has been open sourced and cut the first release. The original Pulsar Admin Go Library is from [pulsarctl](https://github.com/streamnative/pulsarctl)'s internal

Re: Re: Introducer Pulsar admin api to pulsar-client-go

2023-03-17 Thread Max Xu
Thanks Yu and Eric for your follow-up. Yes, we're working on that. I believe we will soon see pulsar-admin-go :) Best, Max Xu On Wed, Mar 15, 2023 at 2:36 PM Yu wrote: > Hi Eric, > > Thanks for sharing the updates! > > I discussed this project with Max previously. We would like to

Re: Re: Introducer Pulsar admin api to pulsar-client-go

2023-03-15 Thread Yu
Hi Eric, Thanks for sharing the updates! I discussed this project with Max previously. We would like to contribute docs for it, and I've already added "Go admin API (coming soon)" to the new Pulsar API docs already [1], which brings many benefits, such as: - Build excitement before launch. -

RE: Re: Introducer Pulsar admin api to pulsar-client-go

2023-03-14 Thread Shen Eric
Hi Zhangjian, We can share some progress on our side: we have completed: * Extracted the pulsar-admin-go library from the pulsarctl and moved it to a separate repo under StreamNative (now it is private) * Updated the project layout and rename some pkg names like the cli pkg what we

Re: Introducer Pulsar admin api to pulsar-client-go

2023-03-02 Thread ZhangJian He
Hi, Eric. Thank you very much for the work you have done. I have no objections to the process, and it would be even better if there could be a rough timeline. Thanks ZhangJian He On Fri, 3 Mar 2023 at 09:06, Shen Eric wrote: > Hi Zhangjian, > > I am a PM from StreamNative and we also had some

RE: Introducer Pulsar admin api to pulsar-client-go

2023-03-02 Thread Shen Eric
Hi Zhangjian, I am a PM from StreamNative and we also had some internal discussions related to this topic. Let me share our ongoing planning: * We will extract the pulsar admin pkg from the pulsarctl to a separate open repo which will be called pulsar-admin-go under StreamNative. *

RE: Re: Introducer Pulsar admin api to pulsar-client-go

2023-03-02 Thread Shen Eric
Hi Zhangjian, I am a PM from StreamNative and we also had some internal discussions related to this topic. Let me share our ongoing planning: * We will extract the pulsar admin pkg from the pulsarctl to a separate open repo which will be called pulsar-admin-go under StreamNative. *

RE: Re: Introducer Pulsar admin api to pulsar-client-go

2023-03-01 Thread Shen Eric
Hi Zhangjian, I am a PM from StreamNative and we also had some internal discussions related to this topic. Let me share our ongoing planning: * As Penghui mentioned, we will extract the pulsar admin pkg from the pulsarctl to a separate open repo which will be called pulsar-admin-go under

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-28 Thread ZhangJian He
ping @PengHuiLi. Please let me know your thoughts on this matter. Thanks ZhangJian He On Tue, 28 Feb 2023 at 20:24, Enrico Olivelli wrote: > Il giorno mar 28 feb 2023 alle ore 10:40 ZhangJian He > ha scritto: > > > > ping @PengHuiLi @Enrico Olivelli > > > > Thanks > > ZhangJian He > > > > >

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-28 Thread Enrico Olivelli
Il giorno mar 28 feb 2023 alle ore 10:40 ZhangJian He ha scritto: > > ping @PengHuiLi @Enrico Olivelli > > Thanks > ZhangJian He > > > On Mon, 27 Feb 2023 at 14:02, ZhangJian He wrote: >> >> > Another idea is whether it is possible to generate clients for various >> languages based on the

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-28 Thread ZhangJian He
ping @PengHuiLi @Enrico Olivelli Thanks ZhangJian He On Mon, 27 Feb 2023 at 14:02, ZhangJian He wrote: > > Another idea is whether it is possible to generate clients for various > languages based on the current pulsar rest swagger files > Yes. But I don't think this is a suitable choice for

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-26 Thread ZhangJian He
> Another idea is whether it is possible to generate clients for various languages based on the current pulsar rest swagger files Yes. But I don't think this is a suitable choice for the go client. Due to the existing swagger file not fully complying with the specification, it cannot be used

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-26 Thread Guangning E
Another idea is whether it is possible to generate clients for various languages based on the current pulsar rest swagger files? Thanks, Guangning On Sat, Feb 25, 2023 at 1:44 PM Zixuan Liu wrote: > > I would like to suggest creating a new repository called > "pulsar-admin-go" > > +1, I agreed

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-24 Thread Zixuan Liu
> I would like to suggest creating a new repository called "pulsar-admin-go" +1, I agreed with you. Thanks, Zixuan ZhangJian He 于2023年2月25日周六 11:05写道: > Following our previous discussions via email, I would like to suggest > creating a new repository called "pulsar-admin-go". This repository

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-24 Thread ZhangJian He
Following our previous discussions via email, I would like to suggest creating a new repository called "pulsar-admin-go". This repository will serve as a platform for all of us to contribute our code. Pulsarctl[0] go first. Please let me know your thoughts on this matter. [0] -

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-17 Thread ZhangJian He
Thank for StreamNative for willing to donate this project. This means we don't have to develop and maintain a set of HTTP code from scratch. My idea aligns with Yunze's, and separating it into a standalone pulsar-admin-go project would be better. The **pulsarctl** repo contains bookkeeper http

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-17 Thread PengHui Li
Hi Yunze, Yes, we can split it. Both one repo with two modules or two repos works for me. The pulsarctl already have the admin API and CLI. So I think we don’t need to develop another one. Best, Penghui > On Feb 17, 2023, at 17:44, Yunze Xu wrote: > > Hi PengHui, > > Now I changed my mind a

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-17 Thread Yunze Xu
Hi PengHui, Now I changed my mind a bit. Even if the pulsarctl was contributed to the Apache Foundation, I think we should also avoid adding it as the dependency. What we need is an API layer but not the CLI, while pulsarctl couples the API and CLI. At the moment, my expectation is: 1. Use a

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-17 Thread PengHui Li
I checked with Sijie today. StreamNative can contribute the pulsarctl project to Apache Foundation. Regards, Penghui On Fri, Feb 17, 2023 at 4:02 PM Enrico Olivelli wrote: > I agree to add an admin API to the go client, this would be very helpful. > > Il giorno ven 17 feb 2023 alle ore 08:44

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-17 Thread Enrico Olivelli
I agree to add an admin API to the go client, this would be very helpful. Il giorno ven 17 feb 2023 alle ore 08:44 Zixuan Liu ha scritto: > > Hi Zhangjian, > > This is a good idea to write the admin client by golang, but I don't > suggest add the admin features to pulsar-go-client, it's better

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread Zixuan Liu
Hi Zhangjian, This is a good idea to write the admin client by golang, but I don't suggest add the admin features to pulsar-go-client, it's better to use a new repository to do that to separate dependencies. BTW, StreamNative has a pulsarctl [0] tool, which includes the admin api. > > It's

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread ZhangJian He
Separating dependencies is better. For example, I think Pulsar-admin-go can only have golang standard tls and http dependencies. But it seems impossible to have two go modules when publishing packages using github. > Has anyone tried generating an admin client from our generated open api spec? I

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread Yunze Xu
> I notice that the Java Client and the Java Admin Client are separate dependencies. Is this boundary important to maintain for other language admin clients? IMO, separating them is better to maintain. I had an idea to implement a pure C implementation of the Pulsar admin API. Only libcurl and

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread Yunze Xu
> I have a point of concern, but for a small HTTP interaction, it's probably > too many layers of encapsulation. It makes sense to me. Then I agree to go head for an independent API implementation. Thanks, Yunze On Fri, Feb 17, 2023 at 11:32 AM ZhangJian He wrote: > > > It's better to reuse

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread Michael Marshall
I think it would be valuable to have admin clients in many languages. Has anyone tried generating an admin client from our generated open api spec? I notice that the Java Client and the Java Admin Client are separate dependencies. Is this boundary important to maintain for other language admin

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread Yunze Xu
It's better to reuse existing code rather than reinventing the wheel. I didn't mean using pulsarctl directly. We only need to wrap the provided API from pulsarctl and provide our own public API in pulsar-client-go. Thanks, Yunze On Fri, Feb 17, 2023 at 10:48 AM ZhangJian He wrote: > > > It does

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread ZhangJian He
> It does not make sense to me. Why cannot add it as a dependency? I am not saying it can't. Of course, adding pulsarctl as a dependency is possible. I also recommended this repository in https://github.com/apache/pulsar-client-go/issues/842. I think incorporating the functionality of the HTTP

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread Yunze Xu
Just saw the mail after the PR. > Pulsarctl is not an apache official repository net It does not make sense to me. Why cannot add it as a dependency? Thanks, Yunze On Fri, Feb 17, 2023 at 10:16 AM ZhangJian He wrote: > > Pulsarctl is not an apache official repository net, and given the >

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread ZhangJian He
Pulsarctl is not an apache official repository net, and given the popularity of operators and Go-based dev-ops-tools, would it be possible to consider merging some of the functionalities of pulsarctl into pulsar-client-go Thanks ZhangJian He On Fri, 17 Feb 2023 at 10:00, PengHui Li wrote: >

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-16 Thread PengHui Li
The pulsarctl is an admin CLI tool for Pulsar, written in go. Does it match your requirement? Penghui > On Feb 17, 2023, at 09:47, ZhangJian He wrote: > > I would like to express that the current Pulsar client for Go > (pulsar-client-go) is missing the pulsar Admin API. As such, I would like >