Review Request: Avoid using ntohl()/ntohs()/htonl()/htons()

2012-12-06 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8385/ --- Review request for qpid, Cliff Jansen and Rafael Schloming. Description ---

[jira] [Comment Edited] (QPID-4387) HA test_failover_send_receive sporadically stalls

2012-12-06 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13525818#comment-13525818 ] Alan Conway edited comment on QPID-4387 at 12/6/12 10:29 PM: - T

[jira] [Commented] (QPID-4387) HA test_failover_send_receive sporadically stalls

2012-12-06 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13525818#comment-13525818 ] Alan Conway commented on QPID-4387: --- To reproduce, cd to tests build directory and: sou

Re: r1415137: QPID-3723: Applied patch from Fraser Adams for explicit linking

2012-12-06 Thread Fraser Adams
Hi both, Thanks for this - and sorry for the problems it caused you Alan. I did this a while back for Qpid 0.12 'cause I'm running Ubuntu 11.10 (well Mint 12 really) and ended up tearing my hair out for a while. I'd sort of assumed that Qpid was mainly going to be targeted ad RHEL given the R

[jira] [Commented] (QPID-4485) QMF agent management object list corruption.

2012-12-06 Thread Ken Giusti (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13512091#comment-13512091 ] Ken Giusti commented on QPID-4485: -- thanks - merged to 0.20: http://svn.apache.org/viewvc

Re: r1415137: QPID-3723: Applied patch from Fraser Adams for explicit linking

2012-12-06 Thread Alan Conway
On Thu, 2012-12-06 at 18:36 +, Fraser Adams wrote: > Hi both, > Thanks for this - and sorry for the problems it caused you Alan. I did > this a while back for Qpid 0.12 'cause I'm running Ubuntu 11.10 (well > Mint 12 really) and ended up tearing my hair out for a while. > > I'd sort of assum

Re: More 0.20 requests for inclusion

2012-12-06 Thread Justin Ross
On Tue, 4 Dec 2012, Ken Giusti wrote: Hi Justin, Caught this the other day: https://issues.apache.org/jira/browse/QPID-4485 Not technically a regression, but a potential crasher with a simple fix. What say ye? -K Approved.

[jira] [Commented] (QPID-4485) QMF agent management object list corruption.

2012-12-06 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13512057#comment-13512057 ] Justin Ross commented on QPID-4485: --- Reviewed by Ted. Approved for 0.20.

[jira] [Updated] (QPID-4485) QMF agent management object list corruption.

2012-12-06 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated QPID-4485: -- Assignee: Ken Giusti (was: Ted Ross) > QMF agent management object list corruption. > -

Re: another 0.20 request (was Re: r1415137: QPID-3723: Applied patch from Fraser Adams for explicit linking)

2012-12-06 Thread Gordon Sim
On 12/06/2012 07:37 PM, Justin Ross wrote: On Thu, 6 Dec 2012, Gordon Sim wrote: Justin, can I request permission to make that change to 0.20 also? Simply because we backported the change that caused this error in Alan's case and he reports this fixes it. Approved. Thanks! Committed to bran

[jira] [Commented] (QPID-3723) qpid 0.12 make fails on Linux Mint 12 (I think derived from Ubuntu 11.10)

2012-12-06 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13512055#comment-13512055 ] Gordon Sim commented on QPID-3723: -- Further fix was backported to 0.20 as r1418048.

[jira] [Commented] (QPID-4485) QMF agent management object list corruption.

2012-12-06 Thread Ted Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13512053#comment-13512053 ] Ted Ross commented on QPID-4485: Looks good, ship it. > QMF agent manageme

Re: More 0.20 requests for inclusion

2012-12-06 Thread Justin Ross
On Wed, 5 Dec 2012, Hiram Chirino wrote: Not sure if it's too late to add more bits into 0.20, but I would love it if rev 1417368 to fix QPID-4454 could get merged in. This change would allow us to fully pass the Joram JMS compliance test suite against ActiveMQ's proton based AMQP 1.0 impl. N

Re: another 0.20 request (was Re: r1415137: QPID-3723: Applied patch from Fraser Adams for explicit linking)

2012-12-06 Thread Justin Ross
On Thu, 6 Dec 2012, Gordon Sim wrote: Justin, can I request permission to make that change to 0.20 also? Simply because we backported the change that caused this error in Alan's case and he reports this fixes it. Approved.

[jira] [Commented] (QPID-3723) qpid 0.12 make fails on Linux Mint 12 (I think derived from Ubuntu 11.10)

2012-12-06 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511597#comment-13511597 ] Justin Ross commented on QPID-3723: --- Gordon made a further fix in r1418000. Alan reviewe

[jira] [Commented] (QPID-4493) Memory leak in perl bindings?

2012-12-06 Thread Darryl L. Pierce (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511591#comment-13511591 ] Darryl L. Pierce commented on QPID-4493: I found the problem exists even without th

[jira] [Commented] (QPID-4454) [AMQP 1.0 JMS Client] getJMSReplyTo() != the value set with setJMSReplyTo()

2012-12-06 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511515#comment-13511515 ] Justin Ross commented on QPID-4454: --- Reviewed by Rob. Approved for 0.20.

[jira] [Updated] (QPID-4454) [AMQP 1.0 JMS Client] getJMSReplyTo() != the value set with setJMSReplyTo()

2012-12-06 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated QPID-4454: -- Fix Version/s: 0.20 > [AMQP 1.0 JMS Client] getJMSReplyTo() != the value set with setJMSReplyTo() >

another 0.20 request (was Re: r1415137: QPID-3723: Applied patch from Fraser Adams for explicit linking)

2012-12-06 Thread Gordon Sim
On 12/06/2012 03:18 PM, Alan Conway wrote: On Thu, 2012-12-06 at 11:54 +, Gordon Sim wrote: On 12/05/2012 08:44 PM, Alan Conway wrote: There is a serious problem with this patch. My build (on RHEL5 at trunk r1417511) fails with lots of these: g++: /usr/lib64/libqpidcommon.so: No such file

[jira] [Commented] (QPID-4454) [AMQP 1.0 JMS Client] getJMSReplyTo() != the value set with setJMSReplyTo()

2012-12-06 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511491#comment-13511491 ] Rob Godfrey commented on QPID-4454: --- Yes - I'm happy for this to go into 0.20 (the scope

[jira] [Commented] (QPID-4490) Durable messages with TTL do not expire after broker recovery (c++ store)

2012-12-06 Thread Chuck Rolke (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511480#comment-13511480 ] Chuck Rolke commented on QPID-4490: --- Fixed even more in r1417963 > Durab

[jira] [Commented] (QPID-4454) [AMQP 1.0 JMS Client] getJMSReplyTo() != the value set with setJMSReplyTo()

2012-12-06 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511473#comment-13511473 ] Justin Ross commented on QPID-4454: --- Rob, should we port this one to 0.20?

[jira] [Updated] (QPID-4454) [AMQP 1.0 JMS Client] getJMSReplyTo() != the value set with setJMSReplyTo()

2012-12-06 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated QPID-4454: -- Assignee: Rob Godfrey > [AMQP 1.0 JMS Client] getJMSReplyTo() != the value set with setJMSReplyTo()

[jira] [Updated] (QPID-4485) QMF agent management object list corruption.

2012-12-06 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated QPID-4485: -- Assignee: Ted Ross (was: Ken Giusti) > QMF agent management object list corruption. > -

[jira] [Commented] (QPID-4485) QMF agent management object list corruption.

2012-12-06 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511469#comment-13511469 ] Justin Ross commented on QPID-4485: --- Ted, please review. > QMF agent man

[jira] [Resolved] (QPID-4472) NPE when connecting over AMQP 1.0 with no SASL layer

2012-12-06 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross resolved QPID-4472. --- Resolution: Fixed Assignee: Rob Godfrey > NPE when connecting over AMQP 1.0 with no SASL lay

Re: r1415137: QPID-3723: Applied patch from Fraser Adams for explicit linking

2012-12-06 Thread Alan Conway
On Thu, 2012-12-06 at 11:54 +, Gordon Sim wrote: > On 12/05/2012 08:44 PM, Alan Conway wrote: > > There is a serious problem with this patch. My build (on RHEL5 at trunk > > r1417511) fails with lots of these: > > > > g++: /usr/lib64/libqpidcommon.so: No such file or directory > > g++: /usr/lib

Re: Memory leak in perl bindings?

2012-12-06 Thread Darryl L. Pierce
On Thu, Dec 06, 2012 at 09:25:13AM +0100, Jimmy Jones wrote: > Would someone mind having a look at QPID-4493 - I seem to have a very > reproducible example (with drain.pl) of the perl bindings leaking memory > when calling getProperties or decodeMap, which is causing me a few > headaches for my lon

[jira] [Assigned] (QPID-4493) Memory leak in perl bindings?

2012-12-06 Thread Darryl L. Pierce (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl L. Pierce reassigned QPID-4493: -- Assignee: Darryl L. Pierce > Memory leak in perl bindings? > ---

Re: r1415137: QPID-3723: Applied patch from Fraser Adams for explicit linking

2012-12-06 Thread Gordon Sim
On 12/05/2012 08:44 PM, Alan Conway wrote: There is a serious problem with this patch. My build (on RHEL5 at trunk r1417511) fails with lots of these: g++: /usr/lib64/libqpidcommon.so: No such file or directory g++: /usr/lib64/libqpidtypes.so: No such file or directory It looksl like using -lq

Memory leak in perl bindings?

2012-12-06 Thread Jimmy Jones
Hi, Would someone mind having a look at QPID-4493 - I seem to have a very reproducible example (with drain.pl) of the perl bindings leaking memory when calling getProperties or decodeMap, which is causing me a few headaches for my long running processes! Unless I'm missing something? Many than

[jira] [Updated] (QPID-4493) Memory leak in perl bindings?

2012-12-06 Thread Jimmy Jones (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jimmy Jones updated QPID-4493: -- Attachment: map_sender.pl drain.pl > Memory leak in perl bindings? > ---

[jira] [Created] (QPID-4493) Memory leak in perl bindings?

2012-12-06 Thread Jimmy Jones (JIRA)
Jimmy Jones created QPID-4493: - Summary: Memory leak in perl bindings? Key: QPID-4493 URL: https://issues.apache.org/jira/browse/QPID-4493 Project: Qpid Issue Type: Bug Affects Versions: 0.18