Re: Review Request: Messenger API and implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7934/#review14343 --- 1. It would be good to have Java doc for the API classes. 2. As you

Re: 0.20 release update - RC2 is out

The XML files in question seem to be for Glassfish rather than JBoss (though there is also a properties file in the list which is for JBoss) ? qpid-0.20-rc2/java/jca/example/conf/glassfish-ejb-jar.xml qpid-0.20-rc2/java/jca/example/conf/glassfish-resources.xml qpid-0.20-rc2/java/jca/example/

[jira] [Resolved] (QPID-4481) HA replication of propagated bindings can lead to incorrect configuration

[ https://issues.apache.org/jira/browse/QPID-4481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway resolved QPID-4481. --- Resolution: Fixed Fix committed to trunk at r1420438 > HA replication of propagated

[jira] [Commented] (QPID-4499) Relocate all Swig .i files to include directories.

[ https://issues.apache.org/jira/browse/QPID-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529355#comment-13529355 ] Andrew Stitcher commented on QPID-4499: --- I disagree with Gordon. Generating bindings

Re: Review Request: Avoid using ntohl()/ntohs()/htonl()/htons()

> On Dec. 7, 2012, 9:19 a.m., Cliff Jansen wrote: > > This looks good from a portability perspective. But it must present a > > performance penalty on big endian hardware, though I can't quantify the > > amount. Are these functions not available on some platform? > > Andrew Stitcher wrote: >

Re: 0.20 inclusion request

On Tue, Dec 11, 2012 at 01:23:24PM -0500, Darryl L. Pierce wrote: > QPID-4499: Relocate all Swig .i files to include directories. > http://svn.apache.org/viewvc?view=revision&revision=1420320 > > Test and verified to work. This additional needs QPID-4207, which had moved the swig .i files into cp

Re: Review Request: PROTON-161: check peer certificate for expected peer hostname

> On Dec. 11, 2012, 2 p.m., Rafael Schloming wrote: > > /proton/trunk/proton-c/include/proton/ssl.h, line 261 > > > > > > Maybe I'm missing something here, but isn't this backwards? Isn't the > > wildcard pattern actua

[jira] [Commented] (QPID-4499) Relocate all Swig .i files to include directories.

[ https://issues.apache.org/jira/browse/QPID-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529195#comment-13529195 ] Gordon Sim commented on QPID-4499: -- Personally I find this odd. They are not needed for 'c

0.20 inclusion request

QPID-4499: Relocate all Swig .i files to include directories. http://svn.apache.org/viewvc?view=revision&revision=1420320 Test and verified to work. -- Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. Delivering value year after year. Red Hat ranks #1 in value among software vendors. http

[jira] [Commented] (QPID-4499) Relocate all Swig .i files to include directories.

[ https://issues.apache.org/jira/browse/QPID-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529189#comment-13529189 ] Darryl L. Pierce commented on QPID-4499: This is committed in r1420320. http://svn

[jira] [Resolved] (QPID-4499) Relocate all Swig .i files to include directories.

[ https://issues.apache.org/jira/browse/QPID-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl L. Pierce resolved QPID-4499. Resolution: Fixed Fix Version/s: 0.20 > Relocate all Swig .i files to include dir

Re: 0.20 release update - RC2 is out

Ok, I do remember this now (getting old). In some of the files, including the license causes issues with the generation, most notably JBoss7. I will take a closer look but I do remember trying to get the license in there before and not having any success without resorting to an XSL transformatio

Re: 0.20 release update - RC2 is out

Ah, I didnt actually look at them :) I have updated all the files in the Java tree I think are required (except the JCA related XML configs, I'll defer to Westin on whether those can be licenced). The changes are committed to trunk as the following commit, to be merged upon approval: http://svn.ap

Re: 0.20 release update - RC2 is out

On 12/11/2012 03:51 PM, Robbie Gemmell wrote: I ran RAT over the RC2 'full source release' archive, and it seems to have turned up several files that need licences added in the CPP and Java trees. The output is available here: http://people.apache.org/~robbie/qpid/0.20/0.20rc2_rat_output.txt Ca

Re: Review Request: Proton-c: SSL client session resumption.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8331/#review14293 --- I've reviewed this work from a proton-j point of view, so have only r

[jira] [Created] (QPID-4499) Relocate all Swig .i files to include directories.

Darryl L. Pierce created QPID-4499: -- Summary: Relocate all Swig .i files to include directories. Key: QPID-4499 URL: https://issues.apache.org/jira/browse/QPID-4499 Project: Qpid Issue Type:

Re: 0.20 release update - RC2 is out

:) I was talking about the examples XML files yes (the ones listed in the report). If the comments will simply get stripped out, then I guess it should be ok to just add the licence comment then? On 11 December 2012 15:53, Weston M. Price wrote: > Whoops...should read > > 'Hello Robbie' > > Me

Re: 0.20 release update - RC2 is out

Whoops...should read 'Hello Robbie' Mea culpa On Dec 11, 2012, at 10:53 AM, Weston M. Price wrote: > Hi Justin...which XML files are you talking about? Just in the JCA project > proper or the examples as well? Most files in the examples generated are used > in our auto generation process an

Re: 0.20 release update - RC2 is out

Hi Justin...which XML files are you talking about? Just in the JCA project proper or the examples as well? Most files in the examples generated are used in our auto generation process and sometimes the comments get stripped out. At any rate, I will have a look. Regards, Weston On Dec 11, 201

Re: 0.20 release update - RC2 is out

I ran RAT over the RC2 'full source release' archive, and it seems to have turned up several files that need licences added in the CPP and Java trees. The output is available here: http://people.apache.org/~robbie/qpid/0.20/0.20rc2_rat_output.txt Can someone take a look at the files in the CPP tr

Re: Review Request: Proton-c: SSL client session resumption.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8331/#review14292 --- /proton/trunk/proton-c/include/proton/ssl.h

Re: 0.20 release update - RC2 is out

On Fri, Dec 07, 2012 at 05:34:52PM -0500, Justin Ross wrote: > Hi, folks. I've cut RC2 from revision 1418220 of our release branch. > You can get it here: > > http://people.apache.org/~jross/qpid-0.20-rc2/ > > Chuck was fast and found a windows build failure in RC2 before I could > post this. Pl

Re: 0.20 release update - RC2 is out

On 12/07/2012 10:34 PM, Justin Ross wrote: Hi, folks. I've cut RC2 from revision 1418220 of our release branch. You can get it here: http://people.apache.org/~jross/qpid-0.20-rc2/ Chuck was fast and found a windows build failure in RC2 before I could post this. Please give it a test in your ow

Re: Review Request: PROTON-161: check peer certificate for expected peer hostname

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8449/#review14290 --- /proton/trunk/proton-c/bindings/python/proton.py

Re: 0.20 release update - RC2 is out

I too gave the Java broker and client a spin, using the Hello example to check messages were sent/received. I also connected the old 0.18 JMX Management Console to it to verify that still operates agaisnt the broker if desired (since we are no longer releasing new versions of it). Robbie On 8 Dec