[GitHub] qpid-proton issue #154: Replace user-defined macro WIN32 by compiler-defined...

Github user matlo607 commented on the issue: https://github.com/apache/qpid-proton/pull/154 Actually everything looks correct in the C code. Here below is the result of `git grep WIN32`. ``` CMakeLists.txt:382: if(WIN32) c/CMakeLists.txt:22:if(WIN32 AND NOT CYGWIN)

[jira] [Commented] (DISPATCH-1106) Interrouter link name collisions when routers started in same second

[ https://issues.apache.org/jira/browse/DISPATCH-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590776#comment-16590776 ] ASF subversion and git services commented on DISPATCH-1106: --- Commit

[jira] [Commented] (PROTON-1917) [proton-c] the c++ proton consumer with retry should continue to retry if virtual host not active

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590741#comment-16590741 ] Rob Godfrey commented on PROTON-1917: - Hmmm... that's a different error - it's reporting you are

[jira] [Updated] (QPID-8233) [Broker-J][AMQP 1.0] Failure on connecting to a virtual host which is not yet active should use connection-forced error

[ https://issues.apache.org/jira/browse/QPID-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated QPID-8233: -- Attachment: apache-qpid-broker-j-7.0.3-bin.zip > [Broker-J][AMQP 1.0] Failure on connecting to a

[jira] [Updated] (QPID-8233) [Broker-J][AMQP 1.0] Failure on connecting to a virtual host which is not yet active should use connection-forced error

[ https://issues.apache.org/jira/browse/QPID-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated QPID-8233: -- Attachment: (was: apache-qpid-broker-j-7.0.3-bin.zip) > [Broker-J][AMQP 1.0] Failure on connecting

[GitHub] qpid-proton issue #154: Replace user-defined macro WIN32 by compiler-defined...

Github user astitcher commented on the issue: https://github.com/apache/qpid-proton/pull/154 This looks fine, but you have ignored the c code in the tree - is there a reason for that? --- - To unsubscribe, e-mail:

[GitHub] qpid-dispatch pull request #363: Dispatch 1103

Github user ted-ross commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/363#discussion_r212398966 --- Diff: tests/system_tests_autolinks.py --- @@ -35,6 +36,124 @@ CONNECTION_PROPERTIES = {u'connection': u'properties', u'int_property': 6451}

[GitHub] qpid-dispatch pull request #363: Dispatch 1103

Github user ted-ross commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/363#discussion_r212397739 --- Diff: src/router_core/connections.c --- @@ -34,6 +34,9 @@ static void qdr_link_delete_CT(qdr_core_t *core, qdr_action_t *action, bool disc

[jira] [Commented] (PROTON-1917) [proton-c] the c++ proton consumer with retry should continue to retry if virtual host not active

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590468#comment-16590468 ] Jeremy commented on PROTON-1917: Hello [~rgodfrey] and [~gemmellr] I tested with the patched broker-j

[jira] [Created] (DISPATCH-1106) Interrouter link name collisions when routers started in same second

Chuck Rolke created DISPATCH-1106: - Summary: Interrouter link name collisions when routers started in same second Key: DISPATCH-1106 URL: https://issues.apache.org/jira/browse/DISPATCH-1106 Project:

[jira] [Updated] (QPID-8233) [Broker-J][AMQP 1.0] Failure on connecting to a virtual host which is not yet active should use connection-forced error

[ https://issues.apache.org/jira/browse/QPID-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8233: - Affects Version/s: qpid-java-broker-7.0.3 qpid-java-broker-7.0.2

[jira] [Closed] (QPID-8234) [Broker-J] Return amqp error "amqp:connection:forced" on opening connections to non-existing or not-active virtual hosts

[ https://issues.apache.org/jira/browse/QPID-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy closed QPID-8234. Resolution: Duplicate Closed as duplicate of QPID-8233  > [Broker-J] Return amqp error

[jira] [Updated] (QPID-8233) [Broker-J][AMQP 1.0] Failure on connecting to a virtual host which is not yet active should use connection-forced error

[ https://issues.apache.org/jira/browse/QPID-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8233: - Fix Version/s: qpid-java-broker-7.0.7 > [Broker-J][AMQP 1.0] Failure on connecting to a virtual host

[jira] [Updated] (QPID-8234) [Broker-J] Return amqp error "amqp:connection:forced" on opening connections to non-existing or not-active virtual hosts

[ https://issues.apache.org/jira/browse/QPID-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8234: - Affects Version/s: qpid-java-broker-7.0.3 qpid-java-broker-7.0.2

[jira] [Commented] (QPID-8234) [Broker-J] Return amqp error "amqp:connection:forced" on opening connections to non-existing or not-active virtual hosts

[ https://issues.apache.org/jira/browse/QPID-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590059#comment-16590059 ] Rob Godfrey commented on QPID-8234: --- I think this duplicates QPID-8233 :) > [Broker-J] Return amqp

[jira] [Created] (QPID-8235) [Broker-J] Broker should delay opening/closing connections to virtual hosts which are still activating

Rob Godfrey created QPID-8235: - Summary: [Broker-J] Broker should delay opening/closing connections to virtual hosts which are still activating Key: QPID-8235 URL: https://issues.apache.org/jira/browse/QPID-8235

[jira] [Created] (QPID-8234) [Broker-J] Return amqp error "amqp:connection:forced" on opening connections to non-existing or not-active virtual hosts

Alex Rudyy created QPID-8234: Summary: [Broker-J] Return amqp error "amqp:connection:forced" on opening connections to non-existing or not-active virtual hosts Key: QPID-8234 URL:

[jira] [Commented] (QPID-8233) [Broker-J][AMQP 1.0] Failure on connecting to a virtual host which is not yet active should use connection-forced error

[ https://issues.apache.org/jira/browse/QPID-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590049#comment-16590049 ] Rob Godfrey commented on QPID-8233: --- Attached are a patch and a full build of Broker-J 7.0.3 with this

[jira] [Updated] (QPID-8233) [Broker-J][AMQP 1.0] Failure on connecting to a virtual host which is not yet active should use connection-forced error

[ https://issues.apache.org/jira/browse/QPID-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated QPID-8233: -- Attachment: apache-qpid-broker-j-7.0.3-bin.zip > [Broker-J][AMQP 1.0] Failure on connecting to a

[jira] [Updated] (QPID-8233) [Broker-J][AMQP 1.0] Failure on connecting to a virtual host which is not yet active should use connection-forced error

[ https://issues.apache.org/jira/browse/QPID-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated QPID-8233: -- Attachment: QPID-8233.diff > [Broker-J][AMQP 1.0] Failure on connecting to a virtual host which is not

[jira] [Commented] (PROTON-1917) [proton-c] the c++ proton consumer with retry should continue to retry if virtual host not active

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590045#comment-16590045 ] Rob Godfrey commented on PROTON-1917: - I have created QPID-8233 for the Broker-J change, and I will

[jira] [Created] (QPID-8233) [Broker-J][AMQP 1.0] Failure on connecting to a virtual host which is not yet active should use connection-forced error

Rob Godfrey created QPID-8233: - Summary: [Broker-J][AMQP 1.0] Failure on connecting to a virtual host which is not yet active should use connection-forced error Key: QPID-8233 URL:

[jira] [Commented] (PROTON-1917) [proton-c] the c++ proton consumer with retry should continue to retry if virtual host not active

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590031#comment-16590031 ] Jeremy commented on PROTON-1917: I am using broker-j version 7.0.3. > [proton-c] the c++ proton

[jira] [Commented] (PROTON-1917) [proton-c] the c++ proton consumer with retry should continue to retry if virtual host not active

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590026#comment-16590026 ] Rob Godfrey commented on PROTON-1917: - [~jeremy.aouad] Which version of Broker-J are you using? I

[jira] [Commented] (PROTON-1917) [proton-c] the c++ proton consumer with retry should continue to retry if virtual host not active

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590022#comment-16590022 ] Robbie Gemmell commented on PROTON-1917: Assuming use of a failover URI, it will consider it a

[jira] [Commented] (PROTON-1917) [proton-c] the c++ proton consumer with retry should continue to retry if virtual host not active

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589996#comment-16589996 ] Rob Godfrey commented on PROTON-1917: - [~gemmellr] Do you know how the JMS client will behave in

[jira] [Commented] (PROTON-1917) [proton-c] the c++ proton consumer with retry should continue to retry if virtual host not active

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589995#comment-16589995 ] Jeremy commented on PROTON-1917: Ok, so how do you propose we proceed? it is also worth seeing if qpid

[jira] [Comment Edited] (PROTON-1917) [proton-c] the c++ proton consumer with retry should continue to retry if virtual host not active

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589977#comment-16589977 ] Rob Godfrey edited comment on PROTON-1917 at 8/23/18 9:48 AM: -- I'm still

[jira] [Commented] (PROTON-1917) [proton-c] the c++ proton consumer with retry should continue to retry if virtual host not active

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589977#comment-16589977 ] Rob Godfrey commented on PROTON-1917: - I'm still not totally convinced that this is really Proton's

[jira] [Comment Edited] (PROTON-1917) [proton-c] the c++ proton consumer with retry should continue to retry if virtual host not active

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589943#comment-16589943 ] Jeremy edited comment on PROTON-1917 at 8/23/18 9:29 AM: - Indeed, it is a

[jira] [Comment Edited] (PROTON-1917) [proton-c] the c++ proton consumer with retry should continue to retry if virtual host not active

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589943#comment-16589943 ] Jeremy edited comment on PROTON-1917 at 8/23/18 9:25 AM: - Indeed, it is a

[jira] [Comment Edited] (PROTON-1917) [proton-c] the c++ proton consumer with retry should continue to retry if virtual host not active

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589943#comment-16589943 ] Jeremy edited comment on PROTON-1917 at 8/23/18 9:24 AM: - Indeed, it is a

[jira] [Updated] (PROTON-1917) [proton-c] the c++ proton consumer with retry should continue to retry if virtual host not active

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy updated PROTON-1917: --- Description: I have a running broker, and a configured queue containing messages. I also have a consumer,

[jira] [Comment Edited] (PROTON-1917) [proton-c] the c++ proton consumer with retry should continue to retry if virtual host not active

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589943#comment-16589943 ] Jeremy edited comment on PROTON-1917 at 8/23/18 9:14 AM: - Indeed, it is a

[jira] [Commented] (PROTON-1917) [proton-c] the c++ proton consumer with retry should continue to retry if virtual host not active

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589943#comment-16589943 ] Jeremy commented on PROTON-1917: Indeed, it is a broker-j. I agree that the problem is that the broker

[jira] [Updated] (PROTON-1917) [proton-c] the c++ proton consumer with retry should continue to retry if virtual host not active

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated PROTON-1917: Summary: [proton-c] the c++ proton consumer with retry should continue to retry if virtual host

[jira] [Comment Edited] (PROTON-1917) [proton-c] When qpid broker is killed and started, the c++ proton consumer (with retry) is randomly exiting with an error

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589937#comment-16589937 ] Rob Godfrey edited comment on PROTON-1917 at 8/23/18 9:09 AM: -- >From the

[GitHub] qpid-proton pull request #154: Replace user-defined macro WIN32 by compiler-...

GitHub user matlo607 opened a pull request: https://github.com/apache/qpid-proton/pull/154 Replace user-defined macro WIN32 by compiler-defined _WIN32 On Windows, if qpid-proton is used by another build system (still compiling with VC) than a Visual Studio project, `/D WIN32` is

[jira] [Resolved] (PROTON-1917) [proton-c] When qpid broker is killed and started, the c++ proton consumer (with retry) is randomly exiting with an error

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved PROTON-1917. - Resolution: Not A Problem > [proton-c] When qpid broker is killed and started, the c++ proton

[jira] [Reopened] (PROTON-1917) [proton-c] When qpid broker is killed and started, the c++ proton consumer (with retry) is randomly exiting with an error

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey reopened PROTON-1917: - > [proton-c] When qpid broker is killed and started, the c++ proton consumer > (with retry) is

[jira] [Commented] (PROTON-1917) [proton-c] When qpid broker is killed and started, the c++ proton consumer (with retry) is randomly exiting with an error

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589937#comment-16589937 ] Rob Godfrey commented on PROTON-1917: - This is not really a proton issue. From the error message

[jira] [Updated] (PROTON-1917) [proton-c] When qpid broker is killed and started, the c++ proton consumer (with retry) is randomly exiting with an error

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy updated PROTON-1917: --- Description: I have a running broker, and a configured queue containing messages. I also have a consumer,

[jira] [Updated] (PROTON-1917) [proton-c] When qpid broker is killed and started, the c++ proton consumer (with retry) is randomly exiting with an error

[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy updated PROTON-1917: --- Description: I have a running broker, and a configured queue containing messages. I also have a consumer,