[jira] [Commented] (PROTON-2056) [proton-python] on_settled callback not called when disposition arrives in 2 frames

[ https://issues.apache.org/jira/browse/PROTON-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852599#comment-16852599 ] Andrew Stitcher commented on PROTON-2056: - All of this then begs the question "What is the point

[jira] [Commented] (PROTON-2056) [proton-python] on_settled callback not called when disposition arrives in 2 frames

[ https://issues.apache.org/jira/browse/PROTON-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852591#comment-16852591 ] Andrew Stitcher commented on PROTON-2056: - I can now answer my own questions - having read the

[jira] [Created] (DISPATCH-1350) Update logging/monitoring documentation

Ben Hardesty created DISPATCH-1350: -- Summary: Update logging/monitoring documentation Key: DISPATCH-1350 URL: https://issues.apache.org/jira/browse/DISPATCH-1350 Project: Qpid Dispatch

[jira] [Commented] (PROTON-2056) [proton-python] on_settled callback not called when disposition arrives in 2 frames

[ https://issues.apache.org/jira/browse/PROTON-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852374#comment-16852374 ] Ganesh Murthy commented on PROTON-2056: --- Please forgive me [~astitcher]. I applied your patch to

[jira] [Commented] (DISPATCH-1347) Update documentation for Dispatch Router console

[ https://issues.apache.org/jira/browse/DISPATCH-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852317#comment-16852317 ] ASF GitHub Bot commented on DISPATCH-1347: -- fgiorgetti commented on pull request #516:

[GitHub] [qpid-dispatch] fgiorgetti commented on a change in pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console

fgiorgetti commented on a change in pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console URL: https://github.com/apache/qpid-dispatch/pull/516#discussion_r289155500 ## File path: docs/books/user-guide/using-console.adoc ## @@ -17,110

[GitHub] [qpid-dispatch] fgiorgetti commented on a change in pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console

fgiorgetti commented on a change in pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console URL: https://github.com/apache/qpid-dispatch/pull/516#discussion_r289153444 ## File path: docs/books/user-guide/using-console.adoc ## @@ -17,110

[jira] [Commented] (PROTON-2056) [proton-python] on_settled callback not called when disposition arrives in 2 frames

[ https://issues.apache.org/jira/browse/PROTON-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852256#comment-16852256 ] Ganesh Murthy commented on PROTON-2056: --- Here are the disposition frames for all 50 {noformat}

[jira] [Commented] (PROTON-2056) [proton-python] on_settled callback not called when disposition arrives in 2 frames

[ https://issues.apache.org/jira/browse/PROTON-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852251#comment-16852251 ] Andrew Stitcher commented on PROTON-2056: - I'm not sure if that is what I was expecting, could

[jira] [Commented] (PROTON-2056) [proton-python] on_settled callback not called when disposition arrives in 2 frames

[ https://issues.apache.org/jira/browse/PROTON-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852243#comment-16852243 ] Ganesh Murthy commented on PROTON-2056: --- Before installing the attached patch, the python test

[jira] [Updated] (PROTON-2056) [proton-python] on_settled callback not called when disposition arrives in 2 frames

[ https://issues.apache.org/jira/browse/PROTON-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher updated PROTON-2056: Attachment: proton-2056.patch > [proton-python] on_settled callback not called when

[jira] [Commented] (PROTON-2056) [proton-python] on_settled callback not called when disposition arrives in 2 frames

[ https://issues.apache.org/jira/browse/PROTON-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852157#comment-16852157 ] Andrew Stitcher commented on PROTON-2056: - I've tested out the suggested change and it causes

[jira] [Commented] (DISPATCH-1348) Save qdr_error_t allocation if not necessary

[ https://issues.apache.org/jira/browse/DISPATCH-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852117#comment-16852117 ] ASF GitHub Bot commented on DISPATCH-1348: -- asfgit commented on pull request #515:

[jira] [Commented] (DISPATCH-1348) Save qdr_error_t allocation if not necessary

[ https://issues.apache.org/jira/browse/DISPATCH-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852116#comment-16852116 ] ASF subversion and git services commented on DISPATCH-1348: --- Commit

[GitHub] [qpid-dispatch] asfgit closed pull request #515: DISPATCH-1348 - Allocate qdr_error_t objects only when necessary. Pre…

asfgit closed pull request #515: DISPATCH-1348 - Allocate qdr_error_t objects only when necessary. Pre… URL: https://github.com/apache/qpid-dispatch/pull/515 This is an automated message from the Apache Git Service. To

[jira] [Resolved] (PROTON-2059) char array can be encoded but not decoded

[ https://issues.apache.org/jira/browse/PROTON-2059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved PROTON-2059. Resolution: Fixed > char array can be encoded but not decoded >

[jira] [Commented] (PROTON-2059) char array can be encoded but not decoded

[ https://issues.apache.org/jira/browse/PROTON-2059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852094#comment-16852094 ] ASF subversion and git services commented on PROTON-2059: - Commit

[jira] [Commented] (PROTON-2057) small/array8 primitive arrays >=128 bytes fail to encode

[ https://issues.apache.org/jira/browse/PROTON-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852093#comment-16852093 ] ASF subversion and git services commented on PROTON-2057: - Commit

[jira] [Created] (PROTON-2059) char array can be encoded but not decoded

Robbie Gemmell created PROTON-2059: -- Summary: char array can be encoded but not decoded Key: PROTON-2059 URL: https://issues.apache.org/jira/browse/PROTON-2059 Project: Qpid Proton Issue

[jira] [Commented] (PROTON-2056) [proton-python] on_settled callback not called when disposition arrives in 2 frames

[ https://issues.apache.org/jira/browse/PROTON-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852059#comment-16852059 ] Andrew Stitcher commented on PROTON-2056: - I agree with [~gemmellr] that the {{auto_settle}}

[jira] [Commented] (DISPATCH-1349) qd_buffer_list_clone is wasting dst buffers available capacity

[ https://issues.apache.org/jira/browse/DISPATCH-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851994#comment-16851994 ] ASF GitHub Bot commented on DISPATCH-1349: -- franz1981 commented on issue #514: DISPATCH-1349

[GitHub] [qpid-dispatch] franz1981 commented on issue #514: DISPATCH-1349 qd_buffer_list_clone is wasting dst buffers available capacity

franz1981 commented on issue #514: DISPATCH-1349 qd_buffer_list_clone is wasting dst buffers available capacity URL: https://github.com/apache/qpid-dispatch/pull/514#issuecomment-497373396 Given that it would make the code more complex I can close this: considering the context of

[jira] [Commented] (DISPATCH-1348) Save qdr_error_t allocation if not necessary

[ https://issues.apache.org/jira/browse/DISPATCH-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851992#comment-16851992 ] ASF GitHub Bot commented on DISPATCH-1348: -- ted-ross commented on pull request #515:

[GitHub] [qpid-dispatch] ted-ross commented on a change in pull request #515: DISPATCH-1348 - Allocate qdr_error_t objects only when necessary. Pre…

ted-ross commented on a change in pull request #515: DISPATCH-1348 - Allocate qdr_error_t objects only when necessary. Pre… URL: https://github.com/apache/qpid-dispatch/pull/515#discussion_r289042044 ## File path: src/router_core/error.c ## @@ -34,19 +34,42 @@ qdr_error_t

[jira] [Commented] (DISPATCH-1348) Save qdr_error_t allocation if not necessary

[ https://issues.apache.org/jira/browse/DISPATCH-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851990#comment-16851990 ] ASF GitHub Bot commented on DISPATCH-1348: -- ted-ross commented on pull request #515:

[GitHub] [qpid-dispatch] ted-ross commented on a change in pull request #515: DISPATCH-1348 - Allocate qdr_error_t objects only when necessary. Pre…

ted-ross commented on a change in pull request #515: DISPATCH-1348 - Allocate qdr_error_t objects only when necessary. Pre… URL: https://github.com/apache/qpid-dispatch/pull/515#discussion_r289042044 ## File path: src/router_core/error.c ## @@ -34,19 +34,42 @@ qdr_error_t

[jira] [Commented] (DISPATCH-1347) Update documentation for Dispatch Router console

[ https://issues.apache.org/jira/browse/DISPATCH-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851959#comment-16851959 ] ASF GitHub Bot commented on DISPATCH-1347: -- bhardesty commented on pull request #516:

[GitHub] [qpid-dispatch] bhardesty opened a new pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console

bhardesty opened a new pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console URL: https://github.com/apache/qpid-dispatch/pull/516 The web console doc in the Dispatch Router user guide is out of date. I fixed it to describe how to set up access to, and then

[jira] [Commented] (DISPATCH-1349) qd_buffer_list_clone is wasting dst buffers available capacity

[ https://issues.apache.org/jira/browse/DISPATCH-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851925#comment-16851925 ] ASF GitHub Bot commented on DISPATCH-1349: -- franz1981 commented on issue #514: DISPATCH-1349

[GitHub] [qpid-dispatch] franz1981 commented on issue #514: DISPATCH-1349 qd_buffer_list_clone is wasting dst buffers available capacity

franz1981 commented on issue #514: DISPATCH-1349 qd_buffer_list_clone is wasting dst buffers available capacity URL: https://github.com/apache/qpid-dispatch/pull/514#issuecomment-497347414 @ChugR Totally agree. I was (wrongly) expecting this method to often have >= 1 buffer to be copied,

[jira] [Updated] (DISPATCH-1348) Save qdr_error_t allocation if not necessary

[ https://issues.apache.org/jira/browse/DISPATCH-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Nigro updated DISPATCH-1348: -- Description: qdr_error_from_pn on error.c is allocating qdr_error_t on the hot path

[jira] [Commented] (DISPATCH-1349) qd_buffer_list_clone is wasting dst buffers available capacity

[ https://issues.apache.org/jira/browse/DISPATCH-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851897#comment-16851897 ] ASF GitHub Bot commented on DISPATCH-1349: -- ChugR commented on issue #514: DISPATCH-1349

[GitHub] [qpid-dispatch] ChugR commented on issue #514: DISPATCH-1349 qd_buffer_list_clone is wasting dst buffers available capacity

ChugR commented on issue #514: DISPATCH-1349 qd_buffer_list_clone is wasting dst buffers available capacity URL: https://github.com/apache/qpid-dispatch/pull/514#issuecomment-497338659 This is not a general purpose function called for complete messages. This function is called when

[jira] [Commented] (DISPATCH-1348) Save qdr_error_t allocation if not necessary

[ https://issues.apache.org/jira/browse/DISPATCH-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851861#comment-16851861 ] ASF GitHub Bot commented on DISPATCH-1348: -- ganeshmurthy commented on pull request #515:

[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #515: DISPATCH-1348 - Allocate qdr_error_t objects only when necessary. Pre…

ganeshmurthy opened a new pull request #515: DISPATCH-1348 - Allocate qdr_error_t objects only when necessary. Pre… URL: https://github.com/apache/qpid-dispatch/pull/515 …viously, these objects were always getting created even in the absence of an error

[jira] [Assigned] (DISPATCH-1348) Save qdr_error_t allocation if not necessary

[ https://issues.apache.org/jira/browse/DISPATCH-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy reassigned DISPATCH-1348: --- Assignee: Ganesh Murthy > Save qdr_error_t allocation if not necessary >

[jira] [Commented] (DISPATCH-1349) qd_buffer_list_clone is wasting dst buffers available capacity

[ https://issues.apache.org/jira/browse/DISPATCH-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851809#comment-16851809 ] ASF GitHub Bot commented on DISPATCH-1349: -- franz1981 commented on pull request #514:

[GitHub] [qpid-dispatch] franz1981 opened a new pull request #514: DISPATCH-1349 qd_buffer_list_clone is wasting dst buffers available capacity

franz1981 opened a new pull request #514: DISPATCH-1349 qd_buffer_list_clone is wasting dst buffers available capacity URL: https://github.com/apache/qpid-dispatch/pull/514 This is an automated message from the Apache Git

[jira] [Created] (DISPATCH-1349) qd_buffer_list_clone is wasting dst buffers available capacity

Francesco Nigro created DISPATCH-1349: - Summary: qd_buffer_list_clone is wasting dst buffers available capacity Key: DISPATCH-1349 URL: https://issues.apache.org/jira/browse/DISPATCH-1349

[jira] [Updated] (DISPATCH-1348) Save qdr_error_t allocation if not necessary

[ https://issues.apache.org/jira/browse/DISPATCH-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Nigro updated DISPATCH-1348: -- Description: qdr_error_from_pn on error.c is allocating qdr_error_t on the hot path

[jira] [Created] (DISPATCH-1348) Save qdr_error_t allocation if not necessary

Francesco Nigro created DISPATCH-1348: - Summary: Save qdr_error_t allocation if not necessary Key: DISPATCH-1348 URL: https://issues.apache.org/jira/browse/DISPATCH-1348 Project: Qpid Dispatch