[GitHub] [qpid-proton] ihsinme commented on pull request #295: fix invalid unsigned arithmetic.

2021-02-11 Thread GitBox
ihsinme commented on pull request #295: URL: https://github.com/apache/qpid-proton/pull/295#issuecomment-777997272 thanks for your words. This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [qpid-proton] ChugR commented on pull request #295: fix invalid unsigned arithmetic.

2021-02-11 Thread GitBox
ChugR commented on pull request #295: URL: https://github.com/apache/qpid-proton/pull/295#issuecomment-777896880 Dear ihsinme, I'm very discouraged to hear your description of the statement you want forgiven in such terms and your apology for it. Please let me encourage you by sayin

[jira] [Commented] (PROTON-2217) Python detection logic prefers python2 over python3 when both are installed

2021-02-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283381#comment-17283381 ] ASF GitHub Bot commented on PROTON-2217: astitcher commented on a change in pull

[GitHub] [qpid-proton] astitcher commented on a change in pull request #294: PROTON-2217 Prefer first working Python on PATH, prefer Py3 over Py2

2021-02-11 Thread GitBox
astitcher commented on a change in pull request #294: URL: https://github.com/apache/qpid-proton/pull/294#discussion_r574826338 ## File path: tools/cmake/Modules/FindPython.cmake ## @@ -0,0 +1,66 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more con

[jira] [Commented] (PROTON-2217) Python detection logic prefers python2 over python3 when both are installed

2021-02-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283319#comment-17283319 ] ASF GitHub Bot commented on PROTON-2217: jiridanek commented on pull request #29

[GitHub] [qpid-proton] jiridanek commented on pull request #294: PROTON-2217 Prefer first working Python on PATH, prefer Py3 over Py2

2021-02-11 Thread GitBox
jiridanek commented on pull request #294: URL: https://github.com/apache/qpid-proton/pull/294#issuecomment-39384 `GitHub Actions has encountered an internal error when running your job. ` That's a first for me. This is a

[jira] [Created] (DISPATCH-1957) Leaked objects in system_tests_delivery_abort

2021-02-11 Thread Ganesh Murthy (Jira)
Ganesh Murthy created DISPATCH-1957: --- Summary: Leaked objects in system_tests_delivery_abort Key: DISPATCH-1957 URL: https://issues.apache.org/jira/browse/DISPATCH-1957 Project: Qpid Dispatch

[jira] [Commented] (PROTON-2217) Python detection logic prefers python2 over python3 when both are installed

2021-02-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283262#comment-17283262 ] ASF GitHub Bot commented on PROTON-2217: jiridanek commented on a change in pull

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #294: PROTON-2217 Prefer first working Python on PATH, prefer Py3 over Py2

2021-02-11 Thread GitBox
jiridanek commented on a change in pull request #294: URL: https://github.com/apache/qpid-proton/pull/294#discussion_r574714200 ## File path: tools/cmake/Modules/FindPython.cmake ## @@ -0,0 +1,66 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more con

[jira] [Updated] (PROTON-2333) Identify to Azure Identity using Certificates. Service Principal

2021-02-11 Thread Angelo Mendonca (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angelo Mendonca updated PROTON-2333: Issue Type: New Feature (was: Wish) > Identify to Azure Identity using Certificates. Serv

[jira] [Commented] (PROTON-2217) Python detection logic prefers python2 over python3 when both are installed

2021-02-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283131#comment-17283131 ] ASF GitHub Bot commented on PROTON-2217: astitcher edited a comment on pull requ

[GitHub] [qpid-proton] astitcher edited a comment on pull request #294: PROTON-2217 Prefer first working Python on PATH, prefer Py3 over Py2

2021-02-11 Thread GitBox
astitcher edited a comment on pull request #294: URL: https://github.com/apache/qpid-proton/pull/294#issuecomment-777599005 > Windows GHA build is broken by this. I'll have to figure out what's wrong there. For some reason the cmake configure is finding python 3.9.1 even though the

[jira] [Commented] (PROTON-2325) Crash when closing application using Qpid Proton Cpp 0.25.0

2021-02-11 Thread Jira
[ https://issues.apache.org/jira/browse/PROTON-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283123#comment-17283123 ] Jiri Daněk commented on PROTON-2325: [~koen617] Upgrading to a newer qpid-proton ver

[jira] [Commented] (PROTON-2333) Identify to Azure Identity using Certificates. Service Principal

2021-02-11 Thread Angelo Mendonca (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283121#comment-17283121 ] Angelo Mendonca commented on PROTON-2333: - [~danecek] Please can you let me know

[jira] [Created] (PROTON-2333) Identify to Azure Identity using Certificates. Service Principal

2021-02-11 Thread Angelo Mendonca (Jira)
Angelo Mendonca created PROTON-2333: --- Summary: Identify to Azure Identity using Certificates. Service Principal Key: PROTON-2333 URL: https://issues.apache.org/jira/browse/PROTON-2333 Project: Qpid

[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1027: WIP: generic Q2 unblocking API

2021-02-11 Thread GitBox
ganeshmurthy commented on a change in pull request #1027: URL: https://github.com/apache/qpid-dispatch/pull/1027#discussion_r574622069 ## File path: src/message.c ## @@ -2891,3 +2911,21 @@ int qd_message_stream_data_append(qd_message_t *message, qd_buffer_list_t *data) qd

[jira] [Commented] (PROTON-2217) Python detection logic prefers python2 over python3 when both are installed

2021-02-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283114#comment-17283114 ] ASF GitHub Bot commented on PROTON-2217: astitcher commented on pull request #29

[GitHub] [qpid-proton] astitcher commented on pull request #294: PROTON-2217 Prefer first working Python on PATH, prefer Py3 over Py2

2021-02-11 Thread GitBox
astitcher commented on pull request #294: URL: https://github.com/apache/qpid-proton/pull/294#issuecomment-777599005 > Windows GHA build is broken by this. I'll have to figure out what's wrong there. For some reason the cmake configure is finding python 3.9.1 even though the build scrip

[jira] [Created] (DISPATCH-1956) Potential deadlock: logging lock vs entity cache lock

2021-02-11 Thread Ken Giusti (Jira)
Ken Giusti created DISPATCH-1956: Summary: Potential deadlock: logging lock vs entity cache lock Key: DISPATCH-1956 URL: https://issues.apache.org/jira/browse/DISPATCH-1956 Project: Qpid Dispatch

[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1027: WIP: generic Q2 unblocking API

2021-02-11 Thread GitBox
ganeshmurthy commented on a change in pull request #1027: URL: https://github.com/apache/qpid-dispatch/pull/1027#discussion_r574601957 ## File path: include/qpid/dispatch/message.h ## @@ -556,12 +555,21 @@ bool qd_message_Q2_holdoff_should_unblock(qd_message_t *msg); */ boo

[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1027: WIP: generic Q2 unblocking API

2021-02-11 Thread GitBox
ganeshmurthy commented on a change in pull request #1027: URL: https://github.com/apache/qpid-dispatch/pull/1027#discussion_r574599932 ## File path: include/qpid/dispatch/container.h ## @@ -228,7 +228,7 @@ void qd_link_close(qd_link_t *link); void qd_link_detach(qd_link_t *lin

[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1027: WIP: generic Q2 unblocking API

2021-02-11 Thread GitBox
ganeshmurthy commented on a change in pull request #1027: URL: https://github.com/apache/qpid-dispatch/pull/1027#discussion_r574598410 ## File path: include/qpid/dispatch/alloc_pool.h ## @@ -80,7 +80,26 @@ void *qd_alloc(qd_alloc_type_desc_t *desc, qd_alloc_pool_t **tpool); /

[jira] [Commented] (PROTON-2330) Allow access to session and link properties in cpp binding

2021-02-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282992#comment-17282992 ] ASF GitHub Bot commented on PROTON-2330: pjfawcett commented on pull request #29

[GitHub] [qpid-proton] pjfawcett commented on pull request #293: PROTON-2330-cpp-link-properties

2021-02-11 Thread GitBox
pjfawcett commented on pull request #293: URL: https://github.com/apache/qpid-proton/pull/293#issuecomment-777393767 Raised separate, sub-task, JIRA PROTON-2332 to cover just the work on link properties. Squashed commits and re-worded commit message to standard format

[jira] [Updated] (PROTON-2332) Allow access to link properties in cpp binding

2021-02-11 Thread Pete Fawcett (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pete Fawcett updated PROTON-2332: - Description: In C++ API, allow setting of link properties via sender and receiver options. Allow

[jira] [Created] (PROTON-2332) Allow access to link properties in cpp binding

2021-02-11 Thread Pete Fawcett (Jira)
Pete Fawcett created PROTON-2332: Summary: Allow access to link properties in cpp binding Key: PROTON-2332 URL: https://issues.apache.org/jira/browse/PROTON-2332 Project: Qpid Proton Issue T

[jira] [Commented] (PROTON-2217) Python detection logic prefers python2 over python3 when both are installed

2021-02-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282948#comment-17282948 ] ASF GitHub Bot commented on PROTON-2217: jiridanek commented on pull request #29

[GitHub] [qpid-proton] jiridanek commented on pull request #294: PROTON-2217 Prefer first working Python on PATH, prefer Py3 over Py2

2021-02-11 Thread GitBox
jiridanek commented on pull request #294: URL: https://github.com/apache/qpid-proton/pull/294#issuecomment-777309859 Windows GHA build is broken by this. I'll have to figure out what's wrong there. This is an automated messa