[jira] [Commented] (PROTON-2714) logger.c:204:41: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘size_t’ {aka ‘long unsigned int’} [-Werror=format=]

2023-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714327#comment-17714327 ] ASF GitHub Bot commented on PROTON-2714: jiridanek commented on PR #397: URL:

[GitHub] [qpid-proton] jiridanek commented on pull request #397: PROTON-2714: add annotations for printf-like format strings and fix compiler warnings

2023-04-19 Thread via GitHub
jiridanek commented on PR #397: URL: https://github.com/apache/qpid-proton/pull/397#issuecomment-1515457599 But it seems to be good enough to produce reports ![image](https://user-images.githubusercontent.com/442720/233212649-797c4ca6-dcdc-4299-8cc1-b96ac3dd0fd9.png) -- This

[jira] [Commented] (PROTON-2714) logger.c:204:41: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘size_t’ {aka ‘long unsigned int’} [-Werror=format=]

2023-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714325#comment-17714325 ] ASF GitHub Bot commented on PROTON-2714: jiridanek commented on PR #397: URL:

[GitHub] [qpid-proton] jiridanek commented on pull request #397: PROTON-2714: add annotations for printf-like format strings and fix compiler warnings

2023-04-19 Thread via GitHub
jiridanek commented on PR #397: URL: https://github.com/apache/qpid-proton/pull/397#issuecomment-1515453241 It looks that msvc wants its annotation on both declaration and definition, ``` C:\Users\jdanek\Source\Repos\jiridanek\qpid-proton\c\src\core\object\string.c(197) : warning

[jira] [Commented] (PROTON-2714) logger.c:204:41: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘size_t’ {aka ‘long unsigned int’} [-Werror=format=]

2023-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714317#comment-17714317 ] ASF GitHub Bot commented on PROTON-2714: jiridanek commented on code in PR #397: URL:

[jira] [Commented] (PROTON-2714) logger.c:204:41: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘size_t’ {aka ‘long unsigned int’} [-Werror=format=]

2023-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714318#comment-17714318 ] ASF GitHub Bot commented on PROTON-2714: jiridanek commented on code in PR #397: URL:

[GitHub] [qpid-proton] jiridanek commented on a diff in pull request #397: PROTON-2714: add annotations for printf-like format strings and fix compiler warnings

2023-04-19 Thread via GitHub
jiridanek commented on code in PR #397: URL: https://github.com/apache/qpid-proton/pull/397#discussion_r1171880450 ## c/src/core/logger.c: ## @@ -201,7 +201,7 @@ void pni_logger_log_raw(pn_logger_t *logger, pn_log_subsystem_t subsystem, pn_lo const char *start =

[GitHub] [qpid-proton] jiridanek commented on a diff in pull request #397: PROTON-2714: add annotations for printf-like format strings and fix compiler warnings

2023-04-19 Thread via GitHub
jiridanek commented on code in PR #397: URL: https://github.com/apache/qpid-proton/pull/397#discussion_r1171880301 ## c/src/ssl/openssl.c: ## @@ -1034,7 +1037,7 @@ static ssize_t process_input_ssl( pn_transport_t *transport, unsigned int layer, transport->present_layers

[jira] [Commented] (PROTON-2714) logger.c:204:41: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘size_t’ {aka ‘long unsigned int’} [-Werror=format=]

2023-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714315#comment-17714315 ] ASF GitHub Bot commented on PROTON-2714: jiridanek commented on code in PR #397: URL:

[GitHub] [qpid-proton] jiridanek commented on a diff in pull request #397: PROTON-2714: add annotations for printf-like format strings and fix compiler warnings

2023-04-19 Thread via GitHub
jiridanek commented on code in PR #397: URL: https://github.com/apache/qpid-proton/pull/397#discussion_r1171879826 ## c/src/core/connection_driver.c: ## @@ -43,7 +43,7 @@ static pn_event_t *batch_next(pn_connection_driver_t *d) { /* Log the next event that will be processed

[jira] [Created] (PROTON-2714) logger.c:204:41: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘size_t’ {aka ‘long unsigned int’} [-Werror=format=]

2023-04-19 Thread Jira
Jiri Daněk created PROTON-2714: -- Summary: logger.c:204:41: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘size_t’ {aka ‘long unsigned int’} [-Werror=format=] Key: PROTON-2714

[jira] [Commented] (PROTON-2706) [Python] Allow setting the container id for containers/connections

2023-04-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714303#comment-17714303 ] ASF subversion and git services commented on PROTON-2706: - Commit

[jira] [Commented] (PROTON-2713) [protonj2] Fix some tests that fail intermittently in CI

2023-04-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714160#comment-17714160 ] ASF subversion and git services commented on PROTON-2713: - Commit

[jira] [Created] (PROTON-2713) [protonj2] Fix some tests that fail intermittently in CI

2023-04-19 Thread Timothy A. Bish (Jira)
Timothy A. Bish created PROTON-2713: --- Summary: [protonj2] Fix some tests that fail intermittently in CI Key: PROTON-2713 URL: https://issues.apache.org/jira/browse/PROTON-2713 Project: Qpid Proton

[GitHub] [qpid-proton] jiridanek opened a new pull request, #396: PROTON-xxxx: suppress deprecation warnings when using Jaeger in traci…

2023-04-19 Thread via GitHub
jiridanek opened a new pull request, #396: URL: https://github.com/apache/qpid-proton/pull/396 …ng example ``` /home/jenkins/workspace/rh-qpid-proton-dist-el9-main/build/BUILD/qpid-proton-0.39.0/cpp/examples/tracing_client.cpp:157:50: error: ‘JaegerExporter’ is deprecated

[GitHub] [qpid-proton] jiridanek opened a new pull request, #395: PROTON-xxxx: remove unused for cycle counter variable

2023-04-19 Thread via GitHub
jiridanek opened a new pull request, #395: URL: https://github.com/apache/qpid-proton/pull/395 Some for loops just silently scream to be let out as while ``` [ 83%] Building CXX object cpp/examples/CMakeFiles/tracing_server.dir/tracing_server.cpp.o

[GitHub] [qpid-proton] jiridanek opened a new pull request, #394: PROTON-xxxx: kill include_directories with fire!

2023-04-19 Thread via GitHub
jiridanek opened a new pull request, #394: URL: https://github.com/apache/qpid-proton/pull/394 MSVC apparently tried something to exclude 3rd party libs from strict compilation warning settings, https://devblogs.microsoft.com/cppblog/broken-warnings-theory/, and gcc/cmake should have this

[jira] [Updated] (PROTON-2706) [Python] Allow setting the container id for containers/connections

2023-04-19 Thread Robbie Gemmell (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated PROTON-2706: --- Description: This is an improvement suggested by [~jmennius] (Originally suggested on