Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton/pull/82
I will send this again on the new repo (in a week or so)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user clebertsuconic closed the pull request at:
https://github.com/apache/qpid-proton/pull/82
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/qpid-proton-j/pull/5
Small improvements I will need for Artemis
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/qpid-proton-j
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton-j/pull/5
@tabish121 actually this is about moving the TLS logic from MessageIMpl to
its own class. I only added an @Override into toString being non related to
this.. I will remove that to avoid
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton-j/pull/5
@tabish121 There are two commits on this PR, one for each JIRA.
Each commit is referring the JIRA on it, which is what we need as a link.
The PR is just a tool to contribute
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton-j/pull/5
We actually send / accept PRs for multiple issues on Artemis all the
time... but I will separate them.
---
If your project is set up for it, you can reply to this email and have your
Github user clebertsuconic closed the pull request at:
https://github.com/apache/qpid-proton-j/pull/5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/qpid-proton-j/pull/6
PROTON-1410 Moving ThreadLocal logic for Decoders on Message to its own
class
I need to reuse the same Decoder used by the MessageImpl when creating my
own special Message Type
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/qpid-proton-j/pull/7
PROTON-1409 Exposing delivery length
This is to expose the delivery length to allow creating the buffer with the
required bytes only
https://issues.apache.org/jira/browse
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton-j/pull/5
@tabish121 you could also refer the comments by clicking on the commit.
github will offer a global view, or per commit. It's about the interface..
anyway this is now super
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton-j/pull/6
This supersedes #5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton-j/pull/7
This supersedes #5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton-j/pull/6
Both qpid-jms and artemis are holding this type of TLS somewhere else.
I am creating my own version of an object that is only holding the byte[]
of the message, and I only need
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton-j/pull/6
```a third bit of code stikes me as ugly,```
- as I said the best I envision is not not need multiple instances.
Meanwhile what do you suggest? duplicating the code and the
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton-j/pull/6
@gemmellr I am doing the same thing... avoiding using MessageImpl from
Proton.
I just feel weird having to do a copy & paste inheritance every time
someone needs
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton-j/pull/6
I can live without this one.
The other with the delivery size would be needed for me. I will rework
that one and close this one.
---
If your project is set up for it
Github user clebertsuconic closed the pull request at:
https://github.com/apache/qpid-proton-j/pull/6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton-j/pull/7
@gemmellr since the current method is not part of the api, I renamed it to
getReadableBytes, changed a test to allocate the exact number of bytes
available before the recv was called
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton-j/pull/7
getReadableBytes is in line with other buffers.. I thought it would be more
intuitive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton-j/pull/7
@gemmellr if you could help me by fixing this any way you like and get it
by next release? I'm currently having to allocate a bigger Netty buffer than
required when receiving Deliv
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/qpid-proton/pull/82
optimizations on Decoder/Encoder
- Avoiding multiple instances. The encoder and decoder can be used as
singletons.
- There's still an option to instantiate your own encoder / de
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton/pull/82
This is the first thing I wanted to do on the encoders / decoders.
There's a next step where I can integrate my own Buffer on Transports (or
maybe a refactored version
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton/pull/82
@tabish121 done.. thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton/pull/82
@gemmellr there's a failure in one of these CIs.. what test is that? it
doesn't seem related.
Can you check please?
---
If your project is set up for it, you can rep
24 matches
Mail list logo
