Re: [PR] PROTON-2785: Fix pn_data_clear not clearing error [qpid-proton]

2024-07-30 Thread via GitHub
astitcher merged PR #431: URL: https://github.com/apache/qpid-proton/pull/431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PROTON-2785: Fix pn_data_clear not clearing error [qpid-proton]

2024-07-30 Thread via GitHub
astitcher commented on code in PR #431: URL: https://github.com/apache/qpid-proton/pull/431#discussion_r1697201250 ## c/src/core/codec.c: ## @@ -431,6 +431,7 @@ void pn_data_clear(pn_data_t *data) data->current = 0; data->base_parent = 0; data->base_current = 0;

Re: [PR] PROTON-2785: Fix pn_data_clear not clearing error [qpid-proton]

2024-07-29 Thread via GitHub
PatrickTaibel commented on code in PR #431: URL: https://github.com/apache/qpid-proton/pull/431#discussion_r1696345652 ## c/src/core/codec.c: ## @@ -431,6 +431,7 @@ void pn_data_clear(pn_data_t *data) data->current = 0; data->base_parent = 0; data->base_current =

Re: [PR] PROTON-2785: Fix pn_data_clear not clearing error [qpid-proton]

2024-07-29 Thread via GitHub
astitcher commented on code in PR #431: URL: https://github.com/apache/qpid-proton/pull/431#discussion_r1695772565 ## c/src/core/codec.c: ## @@ -431,6 +431,7 @@ void pn_data_clear(pn_data_t *data) data->current = 0; data->base_parent = 0; data->base_current = 0;

[PR] PROTON-2785: Fix pn_data_clear not clearing error [qpid-proton]

2024-07-29 Thread via GitHub
PatrickTaibel opened a new pull request, #431: URL: https://github.com/apache/qpid-proton/pull/431 We've also hit the bug of the Go library that is described in PROTON-2785. This bug happens when one large message is sent and another message with arbitrary size gets marshaled.

Re: [PR] Fix buffer allocation size for UTF8 string decoding [qpid-protonj2]

2024-07-12 Thread via GitHub
tabish121 commented on PR #11: URL: https://github.com/apache/qpid-protonj2/pull/11#issuecomment-2225959178 Added several tests and a fix for this in 93e05f8f46b79a4e6f83dd099e95451014ed98c6 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Fix buffer allocation size for UTF8 string decoding [qpid-protonj2]

2024-07-12 Thread via GitHub
tabish121 closed pull request #11: Fix buffer allocation size for UTF8 string decoding URL: https://github.com/apache/qpid-protonj2/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] PROTON-2594: Add OpenSSL PKCS#11 PROVIDER support to enable HSM use [qpid-proton]

2024-07-12 Thread via GitHub
a3f commented on PR #430: URL: https://github.com/apache/qpid-proton/pull/430#issuecomment-2225923971 > is there any way of testing this functionality in the CI job? (Rather than just testing that nothing regressed!) How about we apply [this

Re: [PR] NO-JIRA: c/cpp: fix examples installation [qpid-proton]

2024-07-12 Thread via GitHub
astitcher closed pull request #429: NO-JIRA: c/cpp: fix examples installation URL: https://github.com/apache/qpid-proton/pull/429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] NO-JIRA: c/cpp: fix examples installation [qpid-proton]

2024-07-12 Thread via GitHub
astitcher commented on PR #429: URL: https://github.com/apache/qpid-proton/pull/429#issuecomment-2225830074 This change misses the entire point that the examples are _source_ examples to show how the API user how to sue the API. There may well be an issue that the examples should not be

Re: [PR] PROTON-2594: Add OpenSSL PKCS#11 PROVIDER support to enable HSM use [qpid-proton]

2024-07-12 Thread via GitHub
astitcher commented on PR #430: URL: https://github.com/apache/qpid-proton/pull/430#issuecomment-2225813526 This looks good to me - is there any way of testing this functionality in the CI job? (Rather than just testing that nothing regressed!) -- This is an automated message from the

[PR] Fix buffer allocation size for UTF8 string decoding [qpid-protonj2]

2024-07-12 Thread via GitHub
acogoluegnes opened a new pull request, #11: URL: https://github.com/apache/qpid-protonj2/pull/11 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] NO-JIRA: c/cpp: fix examples installation [qpid-proton]

2024-07-10 Thread via GitHub
a3f opened a new pull request, #429: URL: https://github.com/apache/qpid-proton/pull/429 The c/cpp examples so far installed the source files into ${PROTON_SHARE}. This is not what most users would expect, especially if we are cross-compiling and the target lacks a toolchain. Fix

Re: [PR] Proton 2810 [qpid-proton]

2024-07-02 Thread via GitHub
asfgit merged PR #428: URL: https://github.com/apache/qpid-proton/pull/428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PROTON-2818: Move epoll proctor connection logic to a task thread. [qpid-proton]

2024-05-30 Thread via GitHub
astitcher closed pull request #427: PROTON-2818: Move epoll proctor connection logic to a task thread. URL: https://github.com/apache/qpid-proton/pull/427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] PROTON-2818: Move epoll proctor connection logic to a task thread. [qpid-proton]

2024-05-30 Thread via GitHub
astitcher commented on PR #427: URL: https://github.com/apache/qpid-proton/pull/427#issuecomment-2139855057 Merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Close transport tail when freeing connection to avoid the client application hanging when TCP FIN+ACK arrives along with TCP RST. [qpid-proton-j]

2024-05-14 Thread via GitHub
anuchandy commented on PR #44: URL: https://github.com/apache/qpid-proton-j/pull/44#issuecomment-2110882948 Linking to JIRA https://issues.apache.org/jira/browse/PROTON-2823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] Close transport tail when freeing connection to avoid the client application hanging when TCP FIN+ACK arrives along with TCP RST. [qpid-proton-j]

2024-05-14 Thread via GitHub
anuchandy opened a new pull request, #44: URL: https://github.com/apache/qpid-proton-j/pull/44 We’ve noticed that after establishing the connection to the broker, if the broker network initiates the "TCP connection close FIN+ACK, along with RST" then the Proton-J does not signal a terminal

Re: [PR] Bump io.netty:netty-codec-http from 4.1.107.Final to 4.1.108.Final [qpid-jms]

2024-05-10 Thread via GitHub
gemmellr commented on PR #51: URL: https://github.com/apache/qpid-jms/pull/51#issuecomment-2104695500 Sure, next time a release is being done the version of Netty used will be updated to something recent (e.g this PR is already stale and 4.1.109 is the current release, but itself likely

Re: [PR] Bump io.netty:netty-codec-http from 4.1.107.Final to 4.1.108.Final [qpid-jms]

2024-05-10 Thread via GitHub
amacedoo commented on PR #51: URL: https://github.com/apache/qpid-jms/pull/51#issuecomment-2104656683 Hey, @gemmellr are there any plans to update this dependency? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] PROTON-2818: Move epoll proctor connection logic to a task thread. [qpid-proton]

2024-05-06 Thread via GitHub
astitcher commented on PR #427: URL: https://github.com/apache/qpid-proton/pull/427#issuecomment-2096662896 @cliffjansen Thanks for these changes - this is definitely clearer than the original change. I'd still love a clearer lifecycle state machine but this will do for now. -- This

Re: [PR] PROTON-2818: Move epoll proctor connection logic to a task thread. [qpid-proton]

2024-05-06 Thread via GitHub
cliffjansen commented on code in PR #427: URL: https://github.com/apache/qpid-proton/pull/427#discussion_r1591276038 ## c/src/proactor/epoll_raw_connection.c: ## @@ -413,6 +422,19 @@ pn_event_batch_t *pni_raw_connection_process(task_t *t, uint32_t io_events, bool }

Re: [PR] PROTON-2818: Move epoll proctor connection logic to a task thread. [qpid-proton]

2024-05-06 Thread via GitHub
cliffjansen commented on code in PR #427: URL: https://github.com/apache/qpid-proton/pull/427#discussion_r1591273502 ## c/src/proactor/epoll.c: ## @@ -1139,6 +1141,21 @@ static pn_event_batch_t *pconnection_process(pconnection_t *pc, uint32_t events, } if (sched_ready)

Re: [PR] PROTON-2818: Move epoll proctor connection logic to a task thread. [qpid-proton]

2024-04-22 Thread via GitHub
astitcher commented on code in PR #427: URL: https://github.com/apache/qpid-proton/pull/427#discussion_r1575402282 ## c/src/proactor/epoll_raw_connection.c: ## @@ -413,6 +422,19 @@ pn_event_batch_t *pni_raw_connection_process(task_t *t, uint32_t io_events, bool } if

Re: [PR] PROTON-2818: Move epoll proctor connection logic to a task thread. [qpid-proton]

2024-04-22 Thread via GitHub
astitcher commented on code in PR #427: URL: https://github.com/apache/qpid-proton/pull/427#discussion_r1575387644 ## c/src/proactor/epoll.c: ## @@ -1139,6 +1141,21 @@ static pn_event_batch_t *pconnection_process(pconnection_t *pc, uint32_t events, } if (sched_ready)

[PR] PROTON-2818: Move epoll proctor connection logic to a task thread. [qpid-proton]

2024-04-22 Thread via GitHub
cliffjansen opened a new pull request, #427: URL: https://github.com/apache/qpid-proton/pull/427 This patch moves connection logic that can possibly block from the calling thread to the first actual scheduling of the task itself. It otherwise makes no change to the existing logic.

Re: [PR] PROTON-2816/PROTON-2817: Support building python extension with unbun… [qpid-proton]

2024-04-19 Thread via GitHub
asfgit merged PR #426: URL: https://github.com/apache/qpid-proton/pull/426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] PROTON-2816/PROTON-2817: Support building python extension with unbun… [qpid-proton]

2024-04-19 Thread via GitHub
astitcher opened a new pull request, #426: URL: https://github.com/apache/qpid-proton/pull/426 …dled proton There are 3 cases: * Bundled proton library - this should be the default and is what you should use with pip etc. * System proton library - this is what you should use in

Re: [PR] PROTON-2644: Fix Github workflow build to remove deprecation warnings [qpid-proton]

2024-04-17 Thread via GitHub
astitcher commented on PR #425: URL: https://github.com/apache/qpid-proton/pull/425#issuecomment-2062539577 Merged and closed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] PROTON-2644: Fix Github workflow build to remove deprecation warnings [qpid-proton]

2024-04-17 Thread via GitHub
astitcher closed pull request #425: PROTON-2644: Fix Github workflow build to remove deprecation warnings URL: https://github.com/apache/qpid-proton/pull/425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Python/pkg build [qpid-proton]

2024-04-17 Thread via GitHub
astitcher closed pull request #424: Python/pkg build URL: https://github.com/apache/qpid-proton/pull/424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] PROTON-2644: Fix Github workflow build to remove deprecation warnings [qpid-proton]

2024-04-17 Thread via GitHub
jiridanek commented on code in PR #425: URL: https://github.com/apache/qpid-proton/pull/425#discussion_r1568881328 ## .github/workflows/build.yml: ## @@ -74,12 +73,12 @@ jobs: run: cmake --build "${BuildDir}" --config ${BuildType} -t install shell: bash -

Re: [PR] PROTON-2644: Fix Github workflow build to remove deprecation warnings [qpid-proton]

2024-04-17 Thread via GitHub
jiridanek commented on code in PR #425: URL: https://github.com/apache/qpid-proton/pull/425#discussion_r1568881328 ## .github/workflows/build.yml: ## @@ -74,12 +73,12 @@ jobs: run: cmake --build "${BuildDir}" --config ${BuildType} -t install shell: bash -

[PR] PROTON-2644: Fix Github workflow build to remove deprecation warnings [qpid-proton]

2024-04-17 Thread via GitHub
astitcher opened a new pull request, #425: URL: https://github.com/apache/qpid-proton/pull/425 It looks like the MacOS image/python actions are fixed now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] Python/pkg build [qpid-proton]

2024-04-16 Thread via GitHub
astitcher opened a new pull request, #424: URL: https://github.com/apache/qpid-proton/pull/424 This change moves the python package build away from the deprecated setup.py to the supported build.py builder with a setuptools backend. -- This is an automated message from the Apache Git

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-15 Thread via GitHub
asfgit merged PR #423: URL: https://github.com/apache/qpid-proton/pull/423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-13 Thread via GitHub
astitcher commented on PR #423: URL: https://github.com/apache/qpid-proton/pull/423#issuecomment-2053879215 > python 3.13 will be removing the `cgi` module from the standard library, so it needs to be removed from proton examples eventually > >

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-13 Thread via GitHub
astitcher commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1564414963 ## python/setup.cfg: ## @@ -28,26 +28,4 @@ install_requires = cffi>=1.0.0 opentracing = opentracing; jaeger_client [flake8] -# TODO(PROTON-2322) decrease the

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-13 Thread via GitHub
astitcher commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1564414072 ## python/setup.cfg: ## @@ -28,26 +28,4 @@ install_requires = cffi>=1.0.0 opentracing = opentracing; jaeger_client [flake8] -# TODO(PROTON-2322) decrease the

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-13 Thread via GitHub
jiridanek commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563938118 ## python/setup.cfg: ## @@ -28,26 +28,4 @@ install_requires = cffi>=1.0.0 opentracing = opentracing; jaeger_client [flake8] -# TODO(PROTON-2322) decrease the

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-13 Thread via GitHub
jiridanek commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563936489 ## python/setup.cfg: ## @@ -28,26 +28,4 @@ install_requires = cffi>=1.0.0 opentracing = opentracing; jaeger_client [flake8] -# TODO(PROTON-2322) decrease the

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-13 Thread via GitHub
jiridanek commented on PR #423: URL: https://github.com/apache/qpid-proton/pull/423#issuecomment-2053603777 Tried a Python compatibility check in IntelliJ, and got ![image](https://github.com/apache/qpid-proton/assets/442720/70d2f412-142e-46a4-95ba-9682a95c0d5c)

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-13 Thread via GitHub
jiridanek commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563849060 ## python/proton/_handlers.py: ## @@ -1305,15 +1305,15 @@ def update(transport: Transport, selectable: Selectable, now: float) -> None: try:

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-13 Thread via GitHub
jiridanek commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563849367 ## python/proton/_handlers.py: ## @@ -1305,15 +1305,15 @@ def update(transport: Transport, selectable: Selectable, now: float) -> None: try:

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-13 Thread via GitHub
jiridanek commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563846762 ## python/proton/_events.py: ## @@ -57,7 +57,6 @@ def more(self) -> bool: return pn_collector_more(self._impl) def pop(self) -> None: -ev =

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-12 Thread via GitHub
jiridanek commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563731989 ## python/setup.cfg: ## @@ -28,26 +28,4 @@ install_requires = cffi>=1.0.0 opentracing = opentracing; jaeger_client [flake8] -# TODO(PROTON-2322) decrease the

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-12 Thread via GitHub
jiridanek commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563730787 ## python/setup.cfg: ## @@ -28,26 +28,4 @@ install_requires = cffi>=1.0.0 opentracing = opentracing; jaeger_client [flake8] -# TODO(PROTON-2322) decrease the

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-12 Thread via GitHub
jiridanek commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563730121 ## python/setup.cfg: ## @@ -28,26 +28,4 @@ install_requires = cffi>=1.0.0 opentracing = opentracing; jaeger_client [flake8] -# TODO(PROTON-2322) decrease the

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-12 Thread via GitHub
jiridanek commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563729161 ## python/proton/_handlers.py: ## @@ -1305,15 +1305,15 @@ def update(transport: Transport, selectable: Selectable, now: float) -> None: try:

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-12 Thread via GitHub
jiridanek commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563727314 ## python/proton/_events.py: ## @@ -57,7 +57,6 @@ def more(self) -> bool: return pn_collector_more(self._impl) def pop(self) -> None: -ev =

[PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-12 Thread via GitHub
astitcher opened a new pull request, #423: URL: https://github.com/apache/qpid-proton/pull/423 This is a broad but shallow change, that changes a lot of files in fairly minor ways. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-12 Thread via GitHub
astitcher commented on PR #423: URL: https://github.com/apache/qpid-proton/pull/423#issuecomment-2052649323 I want to be sure this didn't break any build, and especially any version of python from 3.9 onwards. But assuming is doesn't then I'll commit it to main. -- This is an

[PR] Bump typescript from 4.6.2 to 5.4.5 in /console/react [qpid-dispatch]

2024-04-10 Thread via GitHub
dependabot[bot] opened a new pull request, #1704: URL: https://github.com/apache/qpid-dispatch/pull/1704 Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.6.2 to 5.4.5. Release notes Sourced from https://github.com/Microsoft/TypeScript/releases;>typescript's

Re: [PR] Bump typescript from 4.6.2 to 5.4.4 in /console/react [qpid-dispatch]

2024-04-10 Thread via GitHub
dependabot[bot] closed pull request #1703: Bump typescript from 4.6.2 to 5.4.4 in /console/react URL: https://github.com/apache/qpid-dispatch/pull/1703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Bump typescript from 4.6.2 to 5.4.4 in /console/react [qpid-dispatch]

2024-04-10 Thread via GitHub
dependabot[bot] commented on PR #1703: URL: https://github.com/apache/qpid-dispatch/pull/1703#issuecomment-2048273878 Superseded by #1704. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump typescript from 4.6.2 to 5.4.3 in /console/react [qpid-dispatch]

2024-04-05 Thread via GitHub
dependabot[bot] closed pull request #1700: Bump typescript from 4.6.2 to 5.4.3 in /console/react URL: https://github.com/apache/qpid-dispatch/pull/1700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Bump typescript from 4.6.2 to 5.4.3 in /console/react [qpid-dispatch]

2024-04-05 Thread via GitHub
dependabot[bot] commented on PR #1700: URL: https://github.com/apache/qpid-dispatch/pull/1700#issuecomment-2040313264 Superseded by #1703. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Bump typescript from 4.6.2 to 5.4.4 in /console/react [qpid-dispatch]

2024-04-05 Thread via GitHub
dependabot[bot] opened a new pull request, #1703: URL: https://github.com/apache/qpid-dispatch/pull/1703 Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.6.2 to 5.4.4. Release notes Sourced from https://github.com/Microsoft/TypeScript/releases;>typescript's

[PR] Bump express from 4.17.3 to 4.19.2 in /console/react [qpid-dispatch]

2024-03-27 Thread via GitHub
dependabot[bot] opened a new pull request, #1702: URL: https://github.com/apache/qpid-dispatch/pull/1702 Bumps [express](https://github.com/expressjs/express) from 4.17.3 to 4.19.2. Release notes Sourced from https://github.com/expressjs/express/releases;>express's releases.

[PR] Bump io.netty:netty-codec-http from 4.1.106.Final to 4.1.108.Final [qpid-broker-j]

2024-03-25 Thread via GitHub
dependabot[bot] opened a new pull request, #243: URL: https://github.com/apache/qpid-broker-j/pull/243 Bumps [io.netty:netty-codec-http](https://github.com/netty/netty) from 4.1.106.Final to 4.1.108.Final. Commits

[PR] Bump io.netty:netty-codec-http from 4.1.107.Final to 4.1.108.Final [qpid-jms]

2024-03-25 Thread via GitHub
dependabot[bot] opened a new pull request, #51: URL: https://github.com/apache/qpid-jms/pull/51 Bumps [io.netty:netty-codec-http](https://github.com/netty/netty) from 4.1.107.Final to 4.1.108.Final. Commits

[PR] Bump webpack-dev-middleware and react-scripts in /console/react [qpid-dispatch]

2024-03-22 Thread via GitHub
dependabot[bot] opened a new pull request, #1701: URL: https://github.com/apache/qpid-dispatch/pull/1701 Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) to 5.3.4 and updates ancestor dependency

Re: [PR] Bump typescript from 4.6.2 to 5.4.2 in /console/react [qpid-dispatch]

2024-03-21 Thread via GitHub
dependabot[bot] closed pull request #1698: Bump typescript from 4.6.2 to 5.4.2 in /console/react URL: https://github.com/apache/qpid-dispatch/pull/1698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Bump typescript from 4.6.2 to 5.4.2 in /console/react [qpid-dispatch]

2024-03-21 Thread via GitHub
dependabot[bot] commented on PR #1698: URL: https://github.com/apache/qpid-dispatch/pull/1698#issuecomment-2013128244 Superseded by #1700. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Bump typescript from 4.6.2 to 5.4.3 in /console/react [qpid-dispatch]

2024-03-21 Thread via GitHub
dependabot[bot] opened a new pull request, #1700: URL: https://github.com/apache/qpid-dispatch/pull/1700 Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.6.2 to 5.4.3. Release notes Sourced from https://github.com/Microsoft/TypeScript/releases;>typescript's

Re: [PR] PROTON-2792: [C++] check that scheduled tasks are active under lock [qpid-proton]

2024-03-19 Thread via GitHub
astitcher closed pull request #422: PROTON-2792: [C++] check that scheduled tasks are active under lock URL: https://github.com/apache/qpid-proton/pull/422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] PROTON-2792: [C++] check that scheduled tasks are active under lock [qpid-proton]

2024-03-18 Thread via GitHub
cliffjansen commented on PR #422: URL: https://github.com/apache/qpid-proton/pull/422#issuecomment-2005528774 +1 I will merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump follow-redirects from 1.14.8 to 1.15.4 in /console/react [qpid-dispatch]

2024-03-15 Thread via GitHub
dependabot[bot] commented on PR #1683: URL: https://github.com/apache/qpid-dispatch/pull/1683#issuecomment-1999619803 Superseded by #1699. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump follow-redirects from 1.14.8 to 1.15.4 in /console/react [qpid-dispatch]

2024-03-15 Thread via GitHub
dependabot[bot] closed pull request #1683: Bump follow-redirects from 1.14.8 to 1.15.4 in /console/react URL: https://github.com/apache/qpid-dispatch/pull/1683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] Bump follow-redirects from 1.14.8 to 1.15.6 in /console/react [qpid-dispatch]

2024-03-15 Thread via GitHub
dependabot[bot] opened a new pull request, #1699: URL: https://github.com/apache/qpid-dispatch/pull/1699 Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.8 to 1.15.6. Commits

Re: [PR] Correct typo in Max Reconnect Delay settings [qpid-protonj2]

2024-03-12 Thread via GitHub
tabish121 commented on PR #9: URL: https://github.com/apache/qpid-protonj2/pull/9#issuecomment-1992636684 I have already fixed this and added a test via ae7139f -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Correct typo in Max Reconnect Delay settings [qpid-protonj2]

2024-03-12 Thread via GitHub
tabish121 closed pull request #9: Correct typo in Max Reconnect Delay settings URL: https://github.com/apache/qpid-protonj2/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Correct typo in Max Reconnect Delay settings [qpid-protonj2]

2024-03-12 Thread via GitHub
ciaranj opened a new pull request, #9: URL: https://github.com/apache/qpid-protonj2/pull/9 The default Max Reconnect Delay setting was erroneously corrected in a previous commit to be be the Default Reconnect Delay. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] PROTON-2792: [cpp] Segmentation fault in container::impl::run_timer_jobs [qpid-proton]

2024-03-08 Thread via GitHub
zlomek commented on PR #421: URL: https://github.com/apache/qpid-proton/pull/421#issuecomment-1985483297 Closing this in favour of #422. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] PROTON-2792: [cpp] Segmentation fault in container::impl::run_timer_jobs [qpid-proton]

2024-03-08 Thread via GitHub
zlomek closed pull request #421: PROTON-2792: [cpp] Segmentation fault in container::impl::run_timer_jobs URL: https://github.com/apache/qpid-proton/pull/421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] PROTON-2792: [C++] check that scheduled tasks are active under lock [qpid-proton]

2024-03-08 Thread via GitHub
zlomek commented on PR #422: URL: https://github.com/apache/qpid-proton/pull/422#issuecomment-1985476033 Yes, this fixes the issue while preserving the semantics, thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] PROTON-2792: [cpp] Segmentation fault in container::impl::run_timer_jobs [qpid-proton]

2024-03-07 Thread via GitHub
astitcher commented on PR #421: URL: https://github.com/apache/qpid-proton/pull/421#issuecomment-1984937964 My suggested fix is #422. @zlomek please check it out and see if it fixes your crash. I'd like to add some tests before merging this so that we make sure the crrect semantics are

[PR] PROTON-2792: [C++] check that scheduled tasks are active under lock [qpid-proton]

2024-03-07 Thread via GitHub
astitcher opened a new pull request, #422: URL: https://github.com/apache/qpid-proton/pull/422 Previously we checked whether the tasks were active without locking which was bad. This is is an alternative fix (which has the correct semantics) to #421. I think it probably still

Re: [PR] Bump typescript from 4.6.2 to 5.3.3 in /console/react [qpid-dispatch]

2024-03-07 Thread via GitHub
dependabot[bot] commented on PR #1675: URL: https://github.com/apache/qpid-dispatch/pull/1675#issuecomment-1984062487 Superseded by #1698. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump typescript from 4.6.2 to 5.3.3 in /console/react [qpid-dispatch]

2024-03-07 Thread via GitHub
dependabot[bot] closed pull request #1675: Bump typescript from 4.6.2 to 5.3.3 in /console/react URL: https://github.com/apache/qpid-dispatch/pull/1675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] Bump typescript from 4.6.2 to 5.4.2 in /console/react [qpid-dispatch]

2024-03-07 Thread via GitHub
dependabot[bot] opened a new pull request, #1698: URL: https://github.com/apache/qpid-dispatch/pull/1698 Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.6.2 to 5.4.2. Release notes Sourced from https://github.com/Microsoft/TypeScript/releases;>typescript's

Re: [PR] PROTON-2792: [cpp] Segmentation fault in container::impl::run_timer_jobs [qpid-proton]

2024-03-06 Thread via GitHub
astitcher commented on PR #421: URL: https://github.com/apache/qpid-proton/pull/421#issuecomment-1981610822 There is a clear thread safety violation in ```run_timer_jobs`` use of ```is_active_``` without using the appropriate lock - in fact this is so obvious that I'm puzzled we haven't

Re: [PR] PROTON-2792: [cpp] Segmentation fault in container::impl::run_timer_jobs [qpid-proton]

2024-02-28 Thread via GitHub
DreamPearl commented on PR #421: URL: https://github.com/apache/qpid-proton/pull/421#issuecomment-1968552400 @astitcher @cliffjansen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] PROTON-2438: [cpp] Cancellable tasks [qpid-proton]

2024-02-28 Thread via GitHub
zlomek commented on code in PR #379: URL: https://github.com/apache/qpid-proton/pull/379#discussion_r1505518521 ## cpp/src/proactor_container_impl.cpp: ## @@ -532,7 +540,13 @@ void container::impl::run_timer_jobs() { // We've now taken the tasks to run from the deferred

[PR] PROTON-2792: [cpp] Segmentation fault in container::impl::run_timer_jobs [qpid-proton]

2024-02-28 Thread via GitHub
zlomek opened a new pull request, #421: URL: https://github.com/apache/qpid-proton/pull/421 [PROTON-2792](https://issues.apache.org/jira/browse/PROTON-2792) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] PROTON-2438: [cpp] Cancellable tasks [qpid-proton]

2024-02-27 Thread via GitHub
DreamPearl commented on code in PR #379: URL: https://github.com/apache/qpid-proton/pull/379#discussion_r1504081204 ## cpp/src/proactor_container_impl.cpp: ## @@ -532,7 +540,13 @@ void container::impl::run_timer_jobs() { // We've now taken the tasks to run from the

Re: [PR] PROTON-2791: Add MSG_MORE send flag on raw connections [qpid-proton]

2024-02-21 Thread via GitHub
astitcher merged PR #420: URL: https://github.com/apache/qpid-proton/pull/420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PROTON-2791: Add MSG_MORE send flag on raw connections [qpid-proton]

2024-02-21 Thread via GitHub
astitcher commented on PR #420: URL: https://github.com/apache/qpid-proton/pull/420#issuecomment-1957677202 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Bump ip from 1.1.5 to 1.1.9 in /console/react [qpid-dispatch]

2024-02-20 Thread via GitHub
dependabot[bot] opened a new pull request, #1697: URL: https://github.com/apache/qpid-dispatch/pull/1697 Bumps [ip](https://github.com/indutny/node-ip) from 1.1.5 to 1.1.9. Commits https://github.com/indutny/node-ip/commit/1ecbf2fd8c0cc85e44c3b587d2de641f50dc0217;>1ecbf2f

Re: [PR] Bump browserslist from 4.20.0 to 4.22.3 in /console/react [qpid-dispatch]

2024-02-14 Thread via GitHub
dependabot[bot] commented on PR #1691: URL: https://github.com/apache/qpid-dispatch/pull/1691#issuecomment-1944326373 Superseded by #1696. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump browserslist from 4.20.0 to 4.22.3 in /console/react [qpid-dispatch]

2024-02-14 Thread via GitHub
dependabot[bot] closed pull request #1691: Bump browserslist from 4.20.0 to 4.22.3 in /console/react URL: https://github.com/apache/qpid-dispatch/pull/1691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] Bump browserslist from 4.20.0 to 4.23.0 in /console/react [qpid-dispatch]

2024-02-14 Thread via GitHub
dependabot[bot] opened a new pull request, #1696: URL: https://github.com/apache/qpid-dispatch/pull/1696 Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.20.0 to 4.23.0. Release notes Sourced from

Re: [PR] NO-JIRA: Update cache, checkout and setup-java github actions to version 4 [qpid-broker-j]

2024-02-13 Thread via GitHub
vavrtom merged PR #241: URL: https://github.com/apache/qpid-broker-j/pull/241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] QPID-8669 - [Broker-J] Dependency updates for version 9.2.1+ [qpid-broker-j]

2024-02-12 Thread via GitHub
dakirily opened a new pull request, #242: URL: https://github.com/apache/qpid-broker-j/pull/242 This PR addresses JIRA [QPID-8669](https://issues.apache.org/jira/browse/QPID-8669), updating broker-j dependencies. Following dependencies are updated: **runtime dependencies**

[PR] NO-JIRA: Update cache, checkout and setup-java github actions to version 4 [qpid-broker-j]

2024-02-12 Thread via GitHub
dakirily opened a new pull request, #241: URL: https://github.com/apache/qpid-broker-j/pull/241 This PR updates github actions cache / checkout / setup-java to version 4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] PROTON-2791: Add MSG_MORE send flag on raw connections [qpid-proton]

2024-02-12 Thread via GitHub
cliffjansen opened a new pull request, #420: URL: https://github.com/apache/qpid-proton/pull/420 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] QPID-8667: [Broker-J] Database connection with client certificate authentication exposes keystore / truststore passwords [qpid-broker-j]

2024-02-08 Thread via GitHub
vavrtom merged PR #240: URL: https://github.com/apache/qpid-broker-j/pull/240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] QPID-8666: [Broker-J] Broker plugin jdbc-provider-bone replacement [qpid-broker-j]

2024-02-08 Thread via GitHub
dakirily opened a new pull request, #240: URL: https://github.com/apache/qpid-broker-j/pull/240 This PR addresses JIRA [QPID-8666](https://issues.apache.org/jira/browse/QPID-8666), adding a UI fix for the issue when creating a JSON Virtual Host Node with BDB Virtual host resulting in

Re: [PR] PROTON-2438: [cpp] Cancellable tasks [qpid-proton]

2024-02-07 Thread via GitHub
zlomek commented on code in PR #379: URL: https://github.com/apache/qpid-proton/pull/379#discussion_r1482476356 ## cpp/src/proactor_container_impl.cpp: ## @@ -532,7 +540,13 @@ void container::impl::run_timer_jobs() { // We've now taken the tasks to run from the deferred

Re: [PR] PROTON-2438: [cpp] Cancellable tasks [qpid-proton]

2024-02-07 Thread via GitHub
zlomek commented on code in PR #379: URL: https://github.com/apache/qpid-proton/pull/379#discussion_r1481809556 ## cpp/src/proactor_container_impl.cpp: ## @@ -532,7 +540,13 @@ void container::impl::run_timer_jobs() { // We've now taken the tasks to run from the deferred

  1   2   3   4   5   6   7   8   >