[GitHub] [qpid-proton] gemmellr commented on a change in pull request #310: PROTON-2377: [cpp] Make tag_counter in sender.cpp atomic

gemmellr commented on a change in pull request #310: URL: https://github.com/apache/qpid-proton/pull/310#discussion_r618516574 ## File path: cpp/src/sender.cpp ## @@ -60,14 +61,20 @@ class target sender::target() const { } namespace { -// TODO: revisit if thread safety requ

[GitHub] [qpid-proton] gemmellr commented on a change in pull request #310: PROTON-2377: [cpp] Make tag_counter in sender.cpp atomic

gemmellr commented on a change in pull request #310: URL: https://github.com/apache/qpid-proton/pull/310#discussion_r618593227 ## File path: cpp/src/sender.cpp ## @@ -60,14 +61,20 @@ class target sender::target() const { } namespace { -// TODO: revisit if thread safety requ

[GitHub] [qpid-proton] gemmellr commented on a change in pull request #310: PROTON-2377: [cpp] Make tag_counter in sender.cpp atomic

gemmellr commented on a change in pull request #310: URL: https://github.com/apache/qpid-proton/pull/310#discussion_r618594097 ## File path: cpp/src/sender.cpp ## @@ -60,14 +61,20 @@ class target sender::target() const { } namespace { -// TODO: revisit if thread safety requ

[GitHub] [qpid-proton] gemmellr commented on a change in pull request #310: PROTON-2377: [cpp] Make tag_counter in sender.cpp atomic

gemmellr commented on a change in pull request #310: URL: https://github.com/apache/qpid-proton/pull/310#discussion_r618593227 ## File path: cpp/src/sender.cpp ## @@ -60,14 +61,20 @@ class target sender::target() const { } namespace { -// TODO: revisit if thread safety requ