Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/157
Dropped this approch, see #160 for a public API using proton::option
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.a
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/157
On Fri, Sep 21, 2018 at 11:28 AM Andrew Stitcher
wrote:
> Honestly given the alternative, adding gets for the options seems fairly
> innocuous!
>
> To be (a little) le
Github user astitcher commented on the issue:
https://github.com/apache/qpid-proton/pull/157
Honestly given the alternative, adding gets for the options seems fairly
innocuous!
To be (a little) less flippant Unit testing is actually a good reason to
make the options readable
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/157
I want to unit test connection_config::parse by parsing various configs
into connection_options, and then verifying that the connection_options
receives the correct values. connection_options
Github user astitcher commented on the issue:
https://github.com/apache/qpid-proton/pull/157
Basically don't like this approach because it exposes implementation
details to the library interface.
As the unit tests don't only need to be built in the build environment.
Myself I
