[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-27 Thread mbroadst
Github user mbroadst closed the pull request at: https://github.com/apache/qpid/pull/9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-24 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68367813 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -79,6 +79,9 @@ OutgoingFromQueue::OutgoingFromQueue(Broker& broker, const std::string& source,

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-23 Thread mbroadst
Github user mbroadst commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68328482 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -79,6 +79,9 @@ OutgoingFromQueue::OutgoingFromQueue(Broker& broker, const std::string& source,

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-23 Thread mbroadst
Github user mbroadst commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68322985 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -79,6 +79,9 @@ OutgoingFromQueue::OutgoingFromQueue(Broker& broker, const std::string& source,

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-23 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68322398 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -79,6 +79,9 @@ OutgoingFromQueue::OutgoingFromQueue(Broker& broker, const std::string& source,

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-23 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68322267 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -142,11 +145,10 @@ void OutgoingFromQueue::handle(pn_delivery_t* delivery) if

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-23 Thread mbroadst
Github user mbroadst commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68313162 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -142,11 +145,10 @@ void OutgoingFromQueue::handle(pn_delivery_t* delivery) if

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-23 Thread mbroadst
Github user mbroadst commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68312642 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -79,6 +79,9 @@ OutgoingFromQueue::OutgoingFromQueue(Broker& broker, const std::string& source,

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-23 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68299958 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -142,11 +145,10 @@ void OutgoingFromQueue::handle(pn_delivery_t* delivery) if

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-23 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68299289 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -79,6 +79,9 @@ OutgoingFromQueue::OutgoingFromQueue(Broker& broker, const std::string& source,

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-23 Thread mbroadst
GitHub user mbroadst opened a pull request: https://github.com/apache/qpid/pull/9 feat(disposition): support undeliverable-here in modified outcomes Previously, specifying `undeliverable-here` as `true` in a modified outcome simply resulted in the message being rejected. This