Re: Review Request: QPID-3401 changes to the core client

2011-10-14 Thread rajith attapattu
> On 2011-10-14 13:46:19, Robbie Gemmell wrote: > > Alex and I have given the 2 posts a look over. This review represents both > > our thoughts and contains comments on https://reviews.apache.org/r/2364 and > > https://reviews.apache.org/r/2366 > > > > The lack of proper testing is for us a ba

Re: Review Request: QPID-3401 changes to the core client

2011-10-14 Thread rajith attapattu
> On 2011-10-14 15:09:04, Robbie Gemmell wrote: > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java, > > line 976 > > > > > > This new isTopic(Destination)

Re: Review Request: QPID-3401 changes to the core client

2011-10-14 Thread rajith attapattu
> On 2011-10-14 13:46:19, Robbie Gemmell wrote: > > Alex and I have given the 2 posts a look over. This review represents both > > our thoughts and contains comments on https://reviews.apache.org/r/2364 and > > https://reviews.apache.org/r/2366 > > > > The lack of proper testing is for us a ba

Re: Review Request: QPID-3401 changes to the core client

2011-10-14 Thread rajith attapattu
> On 2011-10-14 13:46:19, Robbie Gemmell wrote: > > Alex and I have given the 2 posts a look over. This review represents both > > our thoughts and contains comments on https://reviews.apache.org/r/2364 and > > https://reviews.apache.org/r/2366 > > > > The lack of proper testing is for us a ba

Re: Review Request: QPID-3401 changes to the core client

2011-10-14 Thread rajith attapattu
> On 2011-10-14 13:46:19, Robbie Gemmell wrote: > > Alex and I have given the 2 posts a look over. This review represents both > > our thoughts and contains comments on https://reviews.apache.org/r/2364 and > > https://reviews.apache.org/r/2366 > > > > The lack of proper testing is for us a ba

Re: Review Request: QPID-3401 changes to the core client

2011-10-14 Thread Robbie Gemmell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2364/#review2584 --- http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/

Re: Review Request: QPID-3401 changes to the core client

2011-10-14 Thread Robbie Gemmell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2364/#review2583 --- Alex and I have given the 2 posts a look over. This review represents

Re: Review Request: QPID-3401 changes to the core client

2011-10-12 Thread rajith attapattu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2364/ --- (Updated 2011-10-12 21:09:40.553855) Review request for qpid, Gordon Sim, Robbie