Re: Review Request 22975: bz693721 - Session names longer than 256 bytes cause errors when encoding session management objects

2014-06-27 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22975/#review46912 --- Actually it turns out when applying this patch that there is an issu

Re: Review Request 22975: bz693721 - Session names longer than 256 bytes cause errors when encoding session management objects

2014-06-26 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22975/#review46738 --- Ship it! Fair enough, thanks for the explanation. - Gordon Sim O

Re: Review Request 22975: bz693721 - Session names longer than 256 bytes cause errors when encoding session management objects

2014-06-26 Thread Ernie Allen
> On June 26, 2014, 8:18 a.m., Gordon Sim wrote: > > No objection to this change. However, what would be the impact of change > > the field type? I'm assuming the python tools wouldn't fail, would they? If > > we can get a solid understanding of the impact of just changing the type, > > and de

Re: Review Request 22975: bz693721 - Session names longer than 256 bytes cause errors when encoding session management objects

2014-06-26 Thread Ernie Allen
> On June 26, 2014, 8:18 a.m., Gordon Sim wrote: > > No objection to this change. However, what would be the impact of change > > the field type? I'm assuming the python tools wouldn't fail, would they? If > > we can get a solid understanding of the impact of just changing the type, > > and de

Re: Review Request 22975: bz693721 - Session names longer than 256 bytes cause errors when encoding session management objects

2014-06-26 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22975/#review46724 --- No objection to this change. However, what would be the impact of ch

Re: Review Request 22975: bz693721 - Session names longer than 256 bytes cause errors when encoding session management objects

2014-06-25 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22975/#review46707 --- Ship it! There's a typo in your "testing" comment - you say 1024 by

Review Request 22975: bz693721 - Session names longer than 256 bytes cause errors when encoding session management objects

2014-06-25 Thread Ernie Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22975/ --- Review request for qpid, Alan Conway and Gordon Sim. Repository: qpid Descrip